devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 1/2] arm64: dts: imx8mq: tqma8mq-mba8mx: Add missing USB vbus supply
@ 2024-02-20 15:33 Alexander Stein
  2024-02-20 15:33 ` [PATCH 2/2] arm64: dts: imx8mn: tqma8mqnl-mba8mx: Add missing USB PHY " Alexander Stein
  2024-02-25 12:47 ` [PATCH 1/2] arm64: dts: imx8mq: tqma8mq-mba8mx: Add missing USB " Shawn Guo
  0 siblings, 2 replies; 4+ messages in thread
From: Alexander Stein @ 2024-02-20 15:33 UTC (permalink / raw)
  To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Shawn Guo,
	Sascha Hauer, Fabio Estevam
  Cc: Alexander Stein, Pengutronix Kernel Team, NXP Linux Team, linux,
	devicetree, linux-arm-kernel

VBUS 5V is statically provided to both USB host and on-bard USB-hub.

Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
---
 arch/arm64/boot/dts/freescale/imx8mq-tqma8mq-mba8mx.dts | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm64/boot/dts/freescale/imx8mq-tqma8mq-mba8mx.dts b/arch/arm64/boot/dts/freescale/imx8mq-tqma8mq-mba8mx.dts
index b2e17d4f335eb..0165f3a259853 100644
--- a/arch/arm64/boot/dts/freescale/imx8mq-tqma8mq-mba8mx.dts
+++ b/arch/arm64/boot/dts/freescale/imx8mq-tqma8mq-mba8mx.dts
@@ -160,6 +160,7 @@ &usb_dwc3_0 {
 };
 
 &usb3_phy1 {
+	vbus-supply = <&reg_hub_vbus>;
 	status = "okay";
 };
 
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH 2/2] arm64: dts: imx8mn: tqma8mqnl-mba8mx: Add missing USB PHY vbus supply
  2024-02-20 15:33 [PATCH 1/2] arm64: dts: imx8mq: tqma8mq-mba8mx: Add missing USB vbus supply Alexander Stein
@ 2024-02-20 15:33 ` Alexander Stein
  2024-02-21  8:38   ` Alexander Stein
  2024-02-25 12:47 ` [PATCH 1/2] arm64: dts: imx8mq: tqma8mq-mba8mx: Add missing USB " Shawn Guo
  1 sibling, 1 reply; 4+ messages in thread
From: Alexander Stein @ 2024-02-20 15:33 UTC (permalink / raw)
  To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Shawn Guo,
	Sascha Hauer, Fabio Estevam
  Cc: Alexander Stein, Pengutronix Kernel Team, NXP Linux Team, linux,
	devicetree, linux-arm-kernel

VBUS 5V is statically provided to both USB host and on-bard USB-hub.

Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
---
 arch/arm64/boot/dts/freescale/imx8mn-tqma8mqnl-mba8mx.dts | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/arch/arm64/boot/dts/freescale/imx8mn-tqma8mqnl-mba8mx.dts b/arch/arm64/boot/dts/freescale/imx8mn-tqma8mqnl-mba8mx.dts
index c07d59147ab55..5b682dd907578 100644
--- a/arch/arm64/boot/dts/freescale/imx8mn-tqma8mqnl-mba8mx.dts
+++ b/arch/arm64/boot/dts/freescale/imx8mn-tqma8mqnl-mba8mx.dts
@@ -86,6 +86,10 @@ &usbotg1 {
 	status = "okay";
 };
 
+&usbphynop1 {
+	vbus-supply = <&reg_hub_vbus>;
+};
+
 &iomuxc {
 	pinctrl_ecspi1: ecspi1grp {
 		fsl,pins = <MX8MN_IOMUXC_ECSPI1_SCLK_ECSPI1_SCLK	0x00000146>,
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH 2/2] arm64: dts: imx8mn: tqma8mqnl-mba8mx: Add missing USB PHY vbus supply
  2024-02-20 15:33 ` [PATCH 2/2] arm64: dts: imx8mn: tqma8mqnl-mba8mx: Add missing USB PHY " Alexander Stein
@ 2024-02-21  8:38   ` Alexander Stein
  0 siblings, 0 replies; 4+ messages in thread
From: Alexander Stein @ 2024-02-21  8:38 UTC (permalink / raw)
  To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Shawn Guo,
	Sascha Hauer, Fabio Estevam
  Cc: Pengutronix Kernel Team, NXP Linux Team, linux, devicetree,
	linux-arm-kernel

Am Dienstag, 20. Februar 2024, 16:33:34 CET schrieb Alexander Stein:
> VBUS 5V is statically provided to both USB host and on-bard USB-hub.
> 
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> ---
>  arch/arm64/boot/dts/freescale/imx8mn-tqma8mqnl-mba8mx.dts | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx8mn-tqma8mqnl-mba8mx.dts b/arch/arm64/boot/dts/freescale/imx8mn-tqma8mqnl-mba8mx.dts
> index c07d59147ab55..5b682dd907578 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mn-tqma8mqnl-mba8mx.dts
> +++ b/arch/arm64/boot/dts/freescale/imx8mn-tqma8mqnl-mba8mx.dts
> @@ -86,6 +86,10 @@ &usbotg1 {
>  	status = "okay";
>  };
>  
> +&usbphynop1 {
> +	vbus-supply = <&reg_hub_vbus>;
> +};
> +

Okay, this is kinda confusing. While checking imx8mm platform as well, it turns out
vbus-supply in drivers/usb/phy/phy-generic.c is not used at all, because i.MX
chipidea host doesn't use PHY vbus control at all.

Please drop this, thanks.
Alexander

>  &iomuxc {
>  	pinctrl_ecspi1: ecspi1grp {
>  		fsl,pins = <MX8MN_IOMUXC_ECSPI1_SCLK_ECSPI1_SCLK	0x00000146>,
> 


-- 
TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
Amtsgericht München, HRB 105018
Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
http://www.tq-group.com/



^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH 1/2] arm64: dts: imx8mq: tqma8mq-mba8mx: Add missing USB vbus supply
  2024-02-20 15:33 [PATCH 1/2] arm64: dts: imx8mq: tqma8mq-mba8mx: Add missing USB vbus supply Alexander Stein
  2024-02-20 15:33 ` [PATCH 2/2] arm64: dts: imx8mn: tqma8mqnl-mba8mx: Add missing USB PHY " Alexander Stein
@ 2024-02-25 12:47 ` Shawn Guo
  1 sibling, 0 replies; 4+ messages in thread
From: Shawn Guo @ 2024-02-25 12:47 UTC (permalink / raw)
  To: Alexander Stein
  Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Shawn Guo,
	Sascha Hauer, Fabio Estevam, Pengutronix Kernel Team,
	NXP Linux Team, linux, devicetree, linux-arm-kernel

On Tue, Feb 20, 2024 at 04:33:33PM +0100, Alexander Stein wrote:
> VBUS 5V is statically provided to both USB host and on-bard USB-hub.
> 
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>

Applied, thanks!


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2024-02-25 12:47 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-02-20 15:33 [PATCH 1/2] arm64: dts: imx8mq: tqma8mq-mba8mx: Add missing USB vbus supply Alexander Stein
2024-02-20 15:33 ` [PATCH 2/2] arm64: dts: imx8mn: tqma8mqnl-mba8mx: Add missing USB PHY " Alexander Stein
2024-02-21  8:38   ` Alexander Stein
2024-02-25 12:47 ` [PATCH 1/2] arm64: dts: imx8mq: tqma8mq-mba8mx: Add missing USB " Shawn Guo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).