Re: [PATCH v13 1/3] dt-bindings: adc: add AD7173

David Lechner
2024-02-20T20:54:23Z

On Tue, Feb 20, 2024 at 3:43 AM Dumitru Ceclan <mitrutzceclan@gmail.com> wrote:
>

...

> +
> + avdd-supply:
> + description: Avdd supply, can be used as reference for conversion.
> + This supply is referenced to AVSS, voltage specified here
> + represens (AVDD - AVSS).

The datasheets call this AVDD1, not AVDD. Would be nice to use the
correct name to avoid ambiguity.

Also check spelling `represents` above and below.

> +
> + avdd2-supply:
> + description: Avdd2 supply, used as the input to the internal voltage regulator.
> + This supply is referenced to AVSS, voltage specified here
> + represens (AVDD2 - AVSS).
> +
> + iovdd-supply:
> + description: iovdd supply, used for the chip digital interface.
> +
> + clocks:
> + maxItems: 1
> + description: |

Don't need `|` here.

> + Optional external clock source. Can include one clock source: external
> + clock or external crystal.
> +
> + clock-names:
> + enum:
> + - ext-clk
> + - xtal
> +
> + '#clock-cells':
> + const: 0
> +
> +patternProperties:
> + "^channel@[0-9a-f]$":
> + type: object
> + $ref: adc.yaml
> + unevaluatedProperties: false
> +
> + properties:
> + reg:
> + minimum: 0
> + maximum: 15

Parts ending in -2 only have four channels.

> +
> + diff-channels:
> + items:
> + minimum: 0
> + maximum: 31
> +

Are we missing `bipolar: true` here? (since we have
unevaluatedProperties: false)

> + adi,reference-select:
> + description: |
> + Select the reference source to use when converting on
> + the specific channel. Valid values are:
> + vref : REF+ /REF−
> + vref2 : REF2+ /REF2−
> + refout-avss: REFOUT/AVSS (Internal reference)
> + avdd : AVDD /AVSS
> +
> + External reference ref2 only available on ad7173-8.
> + If not specified, internal reference used.
> + $ref: /schemas/types.yaml#/definitions/string
> + enum:
> + - vref
> + - vref2
> + - refout-avss
> + - avdd
> + default: refout-avss
> +
> + required:
> + - reg
> + - diff-channels
> +
> +required:
> + - compatible
> + - reg

Aren't the various power supplies supposed to be required?

- avdd-supply
- avdd2-supply
- iovdd-supply