Re: [PATCH v13 1/3] dt-bindings: adc: add AD7173

Conor Dooley
2024-02-21T20:00:48Z

[-- Attachment #1: Type: text/plain, Size: 706 bytes --]

> >> +
> >> + diff-channels:
> >> + items:
> >> + minimum: 0
> >> + maximum: 31
> >> +
> >
> > Are we missing `bipolar: true` here? (since we have
> > unevaluatedProperties: false)
> >
>
> No, since we are referencing the adc schema "$ref: adc.yaml"
> Which contains:
> """
> bipolar:
>
> $ref: /schemas/types.yaml#/definitions/flag
>
> description: If provided, the channel is to be used in bipolar mode.
> """

FWIW, the difference here is whether or not the binding for the device
contains "additionalProperties: false" or "unevaluatedProperties: false".
The former requires "bipolar: true", the latter does not.

Cheers,
Conor.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]