Re: [PATCH] dt-bindings: fpga: microchip,mpf-spi-fpga-mgr: document CPOL/CPHA support

[Conor Dooley <conor@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 1480 bytes --]

On Wed, Feb 21, 2024 at 08:12:47PM +0100, Marco Felsch wrote:
> Microchip FPGAs can communicate in different modes, so document them to
> avoid dt-validate warnings.

Are you sure it can "communicate in different modes"? The documentation
actually says "Motorla SPI Mode 3 is required to communicate with M2S,
M2GL, and MPF devices using dedicated system controller SPI port" with
mode 3 being SPO = SPH = 1:
https://www.microsemi.com/document-portal/doc_view/137543-spi-directc-sp1-v2-0-user-guide

I suspect the answer is that it can actually communicate in different
modes (because I don't recall setting those options), but the binding
should enforce the correct way of doing it IMO.

Cheers,
Conor.

> 
> Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
> ---
>  .../devicetree/bindings/fpga/microchip,mpf-spi-fpga-mgr.yaml   | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/fpga/microchip,mpf-spi-fpga-mgr.yaml b/Documentation/devicetree/bindings/fpga/microchip,mpf-spi-fpga-mgr.yaml
> index a157eecfb5fc..bb9a7d16db60 100644
> --- a/Documentation/devicetree/bindings/fpga/microchip,mpf-spi-fpga-mgr.yaml
> +++ b/Documentation/devicetree/bindings/fpga/microchip,mpf-spi-fpga-mgr.yaml
> @@ -22,6 +22,9 @@ properties:
>      description: SPI chip select
>      maxItems: 1
>  
> +  spi-cpol: true
> +  spi-cpha: true
> +
>  required:
>    - compatible
>    - reg
> -- 
> 2.39.2
> 
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]