From: Conor Dooley <conor@kernel.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>, Xin Ji <xji@analogixsemi.com>,
linux-usb@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, Pavel Machek <pavel@ucw.cz>
Subject: Re: [PATCH] dt-bindings: usb: analogix,anx7411: drop redundant connector properties
Date: Thu, 22 Feb 2024 17:30:37 +0000 [thread overview]
Message-ID: <20240222-runny-routing-8e7801a09113@spud> (raw)
In-Reply-To: <838ed10f-7f0a-48e8-a195-a155e4766f49@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 1751 bytes --]
On Thu, Feb 22, 2024 at 05:56:12PM +0100, Krzysztof Kozlowski wrote:
> On 22/02/2024 17:08, Conor Dooley wrote:
> > On Thu, Feb 22, 2024 at 09:28:19AM +0100, Krzysztof Kozlowski wrote:
> >> The binding references usb-connector.yaml schema, which lists all
> >> allowed properties and ends with unevaluatedProperties:false, so we can
> >> simplify analogix,anx7411 binding by dropping everything covered by
> >> usb-connector.yaml.
> >>
> >> Suggested-by: Pavel Machek <pavel@ucw.cz>
> >> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> >> ---
> >> .../devicetree/bindings/usb/analogix,anx7411.yaml | 13 -------------
> >> 1 file changed, 13 deletions(-)
> >>
> >> diff --git a/Documentation/devicetree/bindings/usb/analogix,anx7411.yaml b/Documentation/devicetree/bindings/usb/analogix,anx7411.yaml
> >> index e4d893369d57..3f5857aee3b0 100644
> >> --- a/Documentation/devicetree/bindings/usb/analogix,anx7411.yaml
> >> +++ b/Documentation/devicetree/bindings/usb/analogix,anx7411.yaml
> >> @@ -23,24 +23,11 @@ properties:
> >> connector:
> >> type: object
> >> $ref: ../connector/usb-connector.yaml
> >> - unevaluatedProperties: false
> >
> > The connector schema sets `additionalProperties: true`. Is removing this
> > correct?
> >
>
> I think you look at some old version:
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/connector/usb-connector.yaml?h=v6.8-rc5#n327
Huh, you are correct. I had a stable kernel checked out somehow in the
git worktree I apply dt patches to while reviewing them rather than
linux-next. Sorry about that..
Acked-by: Conor Dooley <conor.dooley@microchip.com>
Cheers,
Conor.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2024-02-22 17:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-22 8:28 [PATCH] dt-bindings: usb: analogix,anx7411: drop redundant connector properties Krzysztof Kozlowski
2024-02-22 16:08 ` Conor Dooley
2024-02-22 16:56 ` Krzysztof Kozlowski
2024-02-22 17:30 ` Conor Dooley [this message]
2024-02-22 21:29 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240222-runny-routing-8e7801a09113@spud \
--to=conor@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=robh+dt@kernel.org \
--cc=xji@analogixsemi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox