From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A81D979F9 for ; Thu, 22 Feb 2024 05:40:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708580407; cv=none; b=ATF0LHI22/qzKw+6wUIRQP2eaxz+rlsz/ZiW04B4gQh00+8lKDoSnImgXJogaY8OTpDZNiRdFpdy9WJpC2KS3iOX8ymw/M6IH5rndhU0mr8RSLLU573aBp7JECOP88KhGG65NCoHcI0fO3S4MqaetfYgzp5nC9LugjVAUg3jntA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708580407; c=relaxed/simple; bh=yQg5gh5MmRiYiePzpcNDaEGQQlXwpQVZ5S9UlbGqOKk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=c+ng9vepjYd/0Gda7hahoIhX924zRoZ6QmSXgVtdFvM4hkapFTCFXzmV+w+ivf7Li4WsvurJPQP8uuxGI5jWdYOac5zK3qbA6lQxE1KWVuVQJFPETqd5n+/eyG4VJRrzNeLeuI6q7O1UovTRS75Fmzwsk1mhgf+ipmDhuvhLFxo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=yA3a6G4Y; arc=none smtp.client-ip=209.85.214.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="yA3a6G4Y" Received: by mail-pl1-f174.google.com with SMTP id d9443c01a7336-1dc49afb495so3347605ad.2 for ; Wed, 21 Feb 2024 21:40:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1708580405; x=1709185205; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=3Y9cstFcLJ3tBNiN3xZNH0htetDh7AF1BjirZ0v0JP4=; b=yA3a6G4YY3W2ec4pZWFbuAw3o8YsO/DpZ2v/bxDBVZXjb6RSSNLWbRjCuTBWSjjxEM NyvHIpg3xvN1xo+e+aK7q6SvTF5gmP+L3n9C9rK9DTl7RiGPhjecrrI7cOaaHt8ovH+u yPk7P4y5E/ka7uJVrXEv6qbPkytJrSy0syBAT7GvC8p5AqgVtfVdopE9xAcae3DeY3WB TOZt0F3khXRZZnQTqCZyZnre/ku4PmO2gMhG4oHu3ITmO9tOHYhAJ6ZTYrrB+AO0/QKn RnVYum/M8Bqh/dhKJF17oH6GkQm/lKR2J+IgntYQiwuTQGzzkgP3JDMT6/ZacTRN6tDu YPZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708580405; x=1709185205; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=3Y9cstFcLJ3tBNiN3xZNH0htetDh7AF1BjirZ0v0JP4=; b=GCTBWNE/zUZqxT1AxV/yv++7tDrjsCpqs50UcC2Nbd0sqGmfoi7FBT5miiK2Jg+axI s3FxZHjcfUGVaw10IM+x/GDBLyezWdkB+ZrwkQeCP3HH08rWR5c8BO4gNdD2ua5BhiUo iwX9Lzcsr0rB7de6vHWT5u7/vCSiJ5K1i5kL8W7zdKFlO/DPJM5zb2Io2t4Oxa85BR4R qc5GVAGqwOKc3JyW98iNiOLIiSsRieSIsP49oGDY/JudU5VlAwRO9vNRYM3bJop0qzw/ xoD9O23U9zJ3fBevNK5c5MB3nLUencyNA9Vv7HT0Ld5fLaNFLBi3SSIF/WDKyOmmFz62 mWdQ== X-Forwarded-Encrypted: i=1; AJvYcCXCr31Rs1e3d2sNitRGrAWl3axElMo+QKpLI3YI9QTVR6faQ08hSPybCTkZllOBH7tjpC3vdT57AdrGshPl+xMDqs3LQiP+A+HKMg== X-Gm-Message-State: AOJu0YzKulF3DMJOqqa9NFIPLoONKxiCybrtK7ETVZK2YOTK01lSOjLV FFdQAsXpGaesl7Q+YeT9mGFWSfkG17Dx4Me2Lj7QSxyPbRKiq9gQqxnVyvKzfPXiMUWvM5UVa30 = X-Google-Smtp-Source: AGHT+IFn4K4spZaFAlnGs4H1E3Uij1heQB4mMHjFctMYMEn7odiUXiBji21giUzbHQ3n3f4SslXQMg== X-Received: by 2002:a17:902:c402:b0:1db:28bd:2949 with SMTP id k2-20020a170902c40200b001db28bd2949mr28591618plk.0.1708580405108; Wed, 21 Feb 2024 21:40:05 -0800 (PST) Received: from thinkpad ([117.193.212.166]) by smtp.gmail.com with ESMTPSA id lf5-20020a170902fb4500b001db43f3629dsm9043678plb.140.2024.02.21.21.40.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 21 Feb 2024 21:40:04 -0800 (PST) Date: Thu, 22 Feb 2024 11:09:58 +0530 From: Manivannan Sadhasivam To: Konrad Dybcio Cc: Bjorn Andersson , Rob Herring , Krzysztof Kozlowski , Conor Dooley , cros-qcom-dts-watchers@chromium.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 09/21] arm64: dts: qcom: sc8280xp: Add PCIe bridge node Message-ID: <20240222053958.GF3374@thinkpad> References: <20240221-pcie-qcom-bridge-dts-v1-0-6c6df0f9450d@linaro.org> <20240221-pcie-qcom-bridge-dts-v1-9-6c6df0f9450d@linaro.org> <9d6c617a-bc3a-47c4-a988-b41b804d8cfe@linaro.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <9d6c617a-bc3a-47c4-a988-b41b804d8cfe@linaro.org> On Wed, Feb 21, 2024 at 01:39:01PM +0100, Konrad Dybcio wrote: > On 21.02.2024 04:41, Manivannan Sadhasivam wrote: > > On Qcom SoCs, the PCIe host bridge is connected to a single PCIe bridge > > for each controller instance. Hence, add a node to represent the bridge. > > > > While at it, let's remove the bridge properties from board dts as they are > > now redundant. > > > > Signed-off-by: Manivannan Sadhasivam > > --- > > .../dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts | 8 ----- > > arch/arm64/boot/dts/qcom/sc8280xp.dtsi | 40 ++++++++++++++++++++++ > > 2 files changed, 40 insertions(+), 8 deletions(-) > > > > diff --git a/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts b/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts > > index def3976bd5bb..f0a0115e08fa 100644 > > --- a/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts > > +++ b/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts > > @@ -733,14 +733,6 @@ &pcie4 { > > status = "okay"; > > > > pcie@0 { > > - device_type = "pci"; > > - reg = <0x0 0x0 0x0 0x0 0x0>; > > - #address-cells = <3>; > > - #size-cells = <2>; > > - ranges; > > - > > - bus-range = <0x01 0xff>; > > - > > wifi@0 { > > This doesn't seem right, pleas use a label > Why? A node label is useful if we want to reference it at the root level in board dts, but here it is not. - Mani -- மணிவண்ணன் சதாசிவம்