* [PATCH v2] dt-bindings: mmc: fsl-imx-mmc: Document the required clocks
@ 2024-02-22 14:39 Fabio Estevam
2024-02-22 15:47 ` Krzysztof Kozlowski
2024-02-28 13:03 ` Ulf Hansson
0 siblings, 2 replies; 3+ messages in thread
From: Fabio Estevam @ 2024-02-22 14:39 UTC (permalink / raw)
To: ulf.hansson
Cc: robh, krzysztof.kozlowski+dt, conor+dt, linux-mmc, devicetree,
Fabio Estevam
From: Fabio Estevam <festevam@denx.de>
The fsl-imx-mmc hardware needs two clocks to operate: ipg and per.
Document these required clocks.
This fixes the following schema warning:
imx27-apf27dev.dtb: mmc@10014000: Unevaluated properties are not allowed ('clock-names', 'clocks' were unexpected)
from schema $id: http://devicetree.org/schemas/mmc/fsl-imx-mmc.yaml#
Signed-off-by: Fabio Estevam <festevam@denx.de>
---
Changes since v2:
- None. Just fixed a typo in the dt list.
.../devicetree/bindings/mmc/fsl-imx-mmc.yaml | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/Documentation/devicetree/bindings/mmc/fsl-imx-mmc.yaml b/Documentation/devicetree/bindings/mmc/fsl-imx-mmc.yaml
index 221f5bc047bd..7911316fbd6a 100644
--- a/Documentation/devicetree/bindings/mmc/fsl-imx-mmc.yaml
+++ b/Documentation/devicetree/bindings/mmc/fsl-imx-mmc.yaml
@@ -24,6 +24,14 @@ properties:
reg:
maxItems: 1
+ clocks:
+ maxItems: 2
+
+ clock-names:
+ items:
+ - const: ipg
+ - const: per
+
interrupts:
maxItems: 1
@@ -34,6 +42,8 @@ properties:
const: rx-tx
required:
+ - clocks
+ - clock-names
- compatible
- reg
- interrupts
@@ -46,6 +56,8 @@ examples:
compatible = "fsl,imx27-mmc", "fsl,imx21-mmc";
reg = <0x10014000 0x1000>;
interrupts = <11>;
+ clocks = <&clks 29>, <&clks 60>;
+ clock-names = "ipg", "per";
dmas = <&dma 7>;
dma-names = "rx-tx";
bus-width = <4>;
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] dt-bindings: mmc: fsl-imx-mmc: Document the required clocks
2024-02-22 14:39 [PATCH v2] dt-bindings: mmc: fsl-imx-mmc: Document the required clocks Fabio Estevam
@ 2024-02-22 15:47 ` Krzysztof Kozlowski
2024-02-28 13:03 ` Ulf Hansson
1 sibling, 0 replies; 3+ messages in thread
From: Krzysztof Kozlowski @ 2024-02-22 15:47 UTC (permalink / raw)
To: Fabio Estevam, ulf.hansson
Cc: robh, krzysztof.kozlowski+dt, conor+dt, linux-mmc, devicetree,
Fabio Estevam
On 22/02/2024 15:39, Fabio Estevam wrote:
> From: Fabio Estevam <festevam@denx.de>
>
> The fsl-imx-mmc hardware needs two clocks to operate: ipg and per.
>
> Document these required clocks.
>
> This fixes the following schema warning:
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] dt-bindings: mmc: fsl-imx-mmc: Document the required clocks
2024-02-22 14:39 [PATCH v2] dt-bindings: mmc: fsl-imx-mmc: Document the required clocks Fabio Estevam
2024-02-22 15:47 ` Krzysztof Kozlowski
@ 2024-02-28 13:03 ` Ulf Hansson
1 sibling, 0 replies; 3+ messages in thread
From: Ulf Hansson @ 2024-02-28 13:03 UTC (permalink / raw)
To: Fabio Estevam
Cc: robh, krzysztof.kozlowski+dt, conor+dt, linux-mmc, devicetree,
Fabio Estevam
On Thu, 22 Feb 2024 at 15:39, Fabio Estevam <festevam@gmail.com> wrote:
>
> From: Fabio Estevam <festevam@denx.de>
>
> The fsl-imx-mmc hardware needs two clocks to operate: ipg and per.
>
> Document these required clocks.
>
> This fixes the following schema warning:
>
> imx27-apf27dev.dtb: mmc@10014000: Unevaluated properties are not allowed ('clock-names', 'clocks' were unexpected)
> from schema $id: http://devicetree.org/schemas/mmc/fsl-imx-mmc.yaml#
>
> Signed-off-by: Fabio Estevam <festevam@denx.de>
Applied for next, thanks!
Kind regards
Uffe
> ---
> Changes since v2:
> - None. Just fixed a typo in the dt list.
>
> .../devicetree/bindings/mmc/fsl-imx-mmc.yaml | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/mmc/fsl-imx-mmc.yaml b/Documentation/devicetree/bindings/mmc/fsl-imx-mmc.yaml
> index 221f5bc047bd..7911316fbd6a 100644
> --- a/Documentation/devicetree/bindings/mmc/fsl-imx-mmc.yaml
> +++ b/Documentation/devicetree/bindings/mmc/fsl-imx-mmc.yaml
> @@ -24,6 +24,14 @@ properties:
> reg:
> maxItems: 1
>
> + clocks:
> + maxItems: 2
> +
> + clock-names:
> + items:
> + - const: ipg
> + - const: per
> +
> interrupts:
> maxItems: 1
>
> @@ -34,6 +42,8 @@ properties:
> const: rx-tx
>
> required:
> + - clocks
> + - clock-names
> - compatible
> - reg
> - interrupts
> @@ -46,6 +56,8 @@ examples:
> compatible = "fsl,imx27-mmc", "fsl,imx21-mmc";
> reg = <0x10014000 0x1000>;
> interrupts = <11>;
> + clocks = <&clks 29>, <&clks 60>;
> + clock-names = "ipg", "per";
> dmas = <&dma 7>;
> dma-names = "rx-tx";
> bus-width = <4>;
> --
> 2.34.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-02-28 13:04 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-02-22 14:39 [PATCH v2] dt-bindings: mmc: fsl-imx-mmc: Document the required clocks Fabio Estevam
2024-02-22 15:47 ` Krzysztof Kozlowski
2024-02-28 13:03 ` Ulf Hansson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).