Re: [PATCH 1/2] dt-bindings: hwmon: add common properties with label

[Rob Herring <robh@kernel.org>]

On Sat, Feb 17, 2024 at 09:21:46AM +0100, Krzysztof Kozlowski wrote:
> On 16/02/2024 18:11, Guenter Roeck wrote:
> > On 2/15/24 23:55, Krzysztof Kozlowski wrote:
> >> Linux hwmon core code parses "label" property for each device, so add a
> >> common schema for that.
> >>
> >> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> > 
> >  From hwmon perspective:
> > 
> > Acked-by: Guenter Roeck <linux@roeck-us.net>
> > 
> >> ---
> >>   .../devicetree/bindings/hwmon/hwmon-common.yaml          | 16 ++++++++++++++++
> >>   1 file changed, 16 insertions(+)
> >>
> >> diff --git a/Documentation/devicetree/bindings/hwmon/hwmon-common.yaml b/Documentation/devicetree/bindings/hwmon/hwmon-common.yaml
> >> new file mode 100644
> >> index 000000000000..d83f4180f622
> >> --- /dev/null
> >> +++ b/Documentation/devicetree/bindings/hwmon/hwmon-common.yaml
> >> @@ -0,0 +1,16 @@
> >> +# SPDX-License-Identifier: GPL-2.0 OR BSD-2-Clause
> >> +%YAML 1.2
> >> +---
> >> +$id: http://devicetree.org/schemas/hwmon/hwmon-common.yaml#
> >> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> >> +
> >> +title: Hardware Monitoring Devices Common Properties
> >> +
> >> +maintainers:
> >> +  - Guenter Roeck <linux@roeck-us.net>
> >> +
> >> +properties:
> >> +  label:
> >> +    description: A descriptive name for this device.
> >> +
> > 
> > Would it make sense to also add shunt-resistor-micro-ohms ?
> 
> It's not present on many devices, I think, so it is also not parsed by
> hwmon core. I plan to add above $ref to hwmon-common to each hwmon
> binding, so this would mean all of them will get shunt-resistor. I would
> not add it, but I also don't mind if I am overruled.

I count 11 users. That's enough for me to add it here.

I care less if a device uses a defined property it doesn't need. I'm 
more worried about having any undefined property allowed.

Rob