Re: [PATCH] dt-bindings: leds: pwm-multicolour: re-allow active-low

[Conor Dooley <conor@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 2985 bytes --]

On Fri, Feb 23, 2024 at 03:43:04PM +0000, Lee Jones wrote:
> On Tue, 13 Feb 2024, Conor Dooley wrote:
> 
> > From: Conor Dooley <conor.dooley@microchip.com>
> > 
> > active-low was lifted to the common schema for leds, but it went
> > unnoticed that the leds-multicolour binding had "additionalProperties:
> > false" where the other users had "unevaluatedProperties: false", thereby
> > disallowing active-low for multicolour leds. Explicitly permit it again.
> > 
> > Fixes: c94d1783136e ("dt-bindings: net: phy: Make LED active-low property common")
> > Signed-off-by: Conor Dooley <conor.dooley@microchip.com>
> > ---
> > 
> > I'm just assuming this is intentionally restrictive, if its not, we
> > could easily just change this to uneval: false.
> > 
> > CC: Pavel Machek <pavel@ucw.cz>
> > CC: Lee Jones <lee@kernel.org>
> > CC: Rob Herring <robh@kernel.org>
> > CC: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
> > CC: Conor Dooley <conor+dt@kernel.org>
> > CC: Sven Schwermer <sven.schwermer@disruptive-technologies.com>
> > CC: Christian Marangi <ansuelsmth@gmail.com>
> > CC: linux-leds@vger.kernel.org
> > CC: devicetree@vger.kernel.org
> > CC: linux-kernel@vger.kernel.org
> > ---
> >  Documentation/devicetree/bindings/leds/leds-pwm-multicolor.yaml | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/leds/leds-pwm-multicolor.yaml b/Documentation/devicetree/bindings/leds/leds-pwm-multicolor.yaml
> > index 5edfbe347341..a31a202afe5c 100644
> > --- a/Documentation/devicetree/bindings/leds/leds-pwm-multicolor.yaml
> > +++ b/Documentation/devicetree/bindings/leds/leds-pwm-multicolor.yaml
> > @@ -41,6 +41,8 @@ properties:
> >  
> >            pwm-names: true
> >  
> > +          active-low: true
> > +
> >            color: true
> >  
> >          required:
> > -- 
> > 2.43.0
> 
> Neither checkpatch.pl or Git appear to be happy with this:

18:15:26 conor /stuff/linux$ shazam 20240213-verse-clinic-e6de06e1f18d@spud
Grabbing thread from lore.kernel.org/all/20240213-verse-clinic-e6de06e1f18d@spud/t.mbox.gz
Checking for newer revisions
Grabbing search results from lore.kernel.org
Analyzing 3 messages in the thread
Looking for additional code-review trailers on lore.kernel.org
Checking attestation on all messages, may take a moment...
Retrieving CI status, may take a moment...
---
  ✓ [PATCH] dt-bindings: leds: pwm-multicolour: re-allow active-low
    + Acked-by: Rob Herring <robh@kernel.org> (✓ DKIM/kernel.org)
  ---
  ✓ Signed: openpgp/conor.dooley@microchip.com (From: conor@kernel.org)
  ✓ Signed: DKIM/kernel.org
---
Total patches: 1
---
Applying: dt-bindings: leds: pwm-multicolour: re-allow active-low
18:15:39 conor /stuff/linux$ git show HEAD~1
commit 2d5c7b7eb345249cb34d42cbc2b97b4c57ea944e (tag: next-20240220, korg-next/master)

What do you use to apply patches? b4 seems to have no trouble.

Cheers,
Conor.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]