From: Lee Jones <lee@kernel.org>
To: "Jernej Škrabec" <jernej.skrabec@gmail.com>
Cc: linux-kernel@vger.kernel.org,
Aren Moynihan <aren@peacevolution.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
devicetree@vger.kernel.org,
Jean-Jacques Hiblot <jjhiblot@traphandler.com>,
Chen-Yu Tsai <wens@csie.org>, Ondrej Jirman <megi@xff.cz>,
linux-sunxi@lists.linux.dev, Pavel Machek <pavel@ucw.cz>,
linux-arm-kernel@lists.infradead.org, linux-leds@vger.kernel.org,
Conor Dooley <conor+dt@kernel.org>, Miles Alan <m@milesalan.com>,
Samuel Holland <samuel@sholland.org>
Subject: Re: [PATCH v2 4/4] arm64: dts: sun50i-a64-pinephone: change led type to status
Date: Fri, 23 Feb 2024 10:29:14 +0000 [thread overview]
Message-ID: <20240223102914.GO10170@google.com> (raw)
In-Reply-To: <2792937.BEx9A2HvPv@jernej-laptop>
On Thu, 22 Feb 2024, Jernej Škrabec wrote:
> Dne torek, 06. februar 2024 ob 19:13:20 CET je Aren Moynihan napisal(a):
> > The status function is described in the documentation as being a rgb led
> > used for system notifications on phones[1][2]. This is exactly what this
> > led is used for on the PinePhone, so using status is probably more
> > accurate than indicator.
> >
> > 1: Documentation/leds/well-known-leds.txt
> > 2: include/dt-bindings/leds/common.h
> >
> > Signed-off-by: Aren Moynihan <aren@peacevolution.org>
>
> Sorry for late review.
>
> Please update subject in patches 2-3. Instead of "sun50i-a64-pinephone:"
> use "allwinner: pinephone:" (check commit history of sun50i-a64-pinephone.dtsi).
> Also rgb -> RGB, led -> LED. Last, please reword commit message to exclude
> links and just say DT bindings documentation.
>
> Note that I'll merge patches 2-3 once patch 1 is merged.
Works for me - I'll go apply it now.
--
Lee Jones [李琼斯]
next prev parent reply other threads:[~2024-02-23 10:29 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-06 18:13 [PATCH v2 1/4] leds: rgb: leds-group-multicolor: allow leds to stay on in suspend Aren Moynihan
2024-02-06 18:13 ` [PATCH v2 2/4] arm64: dts: sun50i-a64-pinephone: Retain leds state " Aren Moynihan
2024-02-06 18:13 ` [PATCH v2 3/4] arm64: dts: sun50i-a64-pinephone: add multicolor led node Aren Moynihan
2024-02-23 8:46 ` Ondřej Jirman
2024-02-23 15:22 ` Aren
2024-02-23 23:28 ` Ondřej Jirman
2024-02-24 2:52 ` Aren
2024-02-06 18:13 ` [PATCH v2 4/4] arm64: dts: sun50i-a64-pinephone: change led type to status Aren Moynihan
2024-02-22 20:57 ` Jernej Škrabec
2024-02-23 10:29 ` Lee Jones [this message]
2024-02-23 16:30 ` Aren
2024-02-23 16:36 ` Jernej Škrabec
2024-02-22 21:36 ` [PATCH v2 1/4] leds: rgb: leds-group-multicolor: allow leds to stay on in suspend Pavel Machek
2024-02-23 10:28 ` Lee Jones
2024-02-23 10:31 ` (subset) " Lee Jones
2024-02-23 10:35 ` Lee Jones
2024-02-23 15:32 ` Aren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240223102914.GO10170@google.com \
--to=lee@kernel.org \
--cc=aren@peacevolution.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jernej.skrabec@gmail.com \
--cc=jjhiblot@traphandler.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=m@milesalan.com \
--cc=megi@xff.cz \
--cc=pavel@ucw.cz \
--cc=robh+dt@kernel.org \
--cc=samuel@sholland.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).