* [PATCH] dt-bindings: mfd: dlg,da9063: Make #interrupt-cells required
@ 2024-02-14 15:03 Geert Uytterhoeven
2024-02-14 15:58 ` Conor Dooley
2024-02-23 15:16 ` Lee Jones
0 siblings, 2 replies; 3+ messages in thread
From: Geert Uytterhoeven @ 2024-02-14 15:03 UTC (permalink / raw)
To: Support Opensource, Lee Jones, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Steve Twiss
Cc: devicetree, linux-kernel, Geert Uytterhoeven
'#interrupt-cells' is a required property for interrupt providers, hence
make it required.
While at it, move '#interrupt-cells' in the example to match common sort
order.
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
Documentation/devicetree/bindings/mfd/dlg,da9063.yaml | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/mfd/dlg,da9063.yaml b/Documentation/devicetree/bindings/mfd/dlg,da9063.yaml
index c5a7e10d7d80e8d7..e5ccc2708f0bb0f8 100644
--- a/Documentation/devicetree/bindings/mfd/dlg,da9063.yaml
+++ b/Documentation/devicetree/bindings/mfd/dlg,da9063.yaml
@@ -87,6 +87,7 @@ required:
- reg
- interrupts
- interrupt-controller
+ - '#interrupt-cells'
additionalProperties: false
@@ -99,10 +100,10 @@ examples:
pmic@58 {
compatible = "dlg,da9063";
reg = <0x58>;
- #interrupt-cells = <2>;
interrupt-parent = <&gpio6>;
interrupts = <11 IRQ_TYPE_LEVEL_LOW>;
interrupt-controller;
+ #interrupt-cells = <2>;
rtc {
compatible = "dlg,da9063-rtc";
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] dt-bindings: mfd: dlg,da9063: Make #interrupt-cells required
2024-02-14 15:03 [PATCH] dt-bindings: mfd: dlg,da9063: Make #interrupt-cells required Geert Uytterhoeven
@ 2024-02-14 15:58 ` Conor Dooley
2024-02-23 15:16 ` Lee Jones
1 sibling, 0 replies; 3+ messages in thread
From: Conor Dooley @ 2024-02-14 15:58 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Support Opensource, Lee Jones, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Steve Twiss, devicetree, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1640 bytes --]
Hey,
On Wed, Feb 14, 2024 at 04:03:42PM +0100, Geert Uytterhoeven wrote:
> '#interrupt-cells' is a required property for interrupt providers, hence
> make it required.
I actually meant to send this patch yesterday but I forgot, thanks for
doing it - the only riscv violation of what Rob reported was also a
da9063..
> While at it, move '#interrupt-cells' in the example to match common sort
> order.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
I think:
Fixes: 361104b05684 ("dt-bindings: mfd: Convert da9063 to yaml")
and
Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
Cheers,
Conor.
> ---
> Documentation/devicetree/bindings/mfd/dlg,da9063.yaml | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/mfd/dlg,da9063.yaml b/Documentation/devicetree/bindings/mfd/dlg,da9063.yaml
> index c5a7e10d7d80e8d7..e5ccc2708f0bb0f8 100644
> --- a/Documentation/devicetree/bindings/mfd/dlg,da9063.yaml
> +++ b/Documentation/devicetree/bindings/mfd/dlg,da9063.yaml
> @@ -87,6 +87,7 @@ required:
> - reg
> - interrupts
> - interrupt-controller
> + - '#interrupt-cells'
>
> additionalProperties: false
>
> @@ -99,10 +100,10 @@ examples:
> pmic@58 {
> compatible = "dlg,da9063";
> reg = <0x58>;
> - #interrupt-cells = <2>;
> interrupt-parent = <&gpio6>;
> interrupts = <11 IRQ_TYPE_LEVEL_LOW>;
> interrupt-controller;
> + #interrupt-cells = <2>;
>
> rtc {
> compatible = "dlg,da9063-rtc";
> --
> 2.34.1
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] dt-bindings: mfd: dlg,da9063: Make #interrupt-cells required
2024-02-14 15:03 [PATCH] dt-bindings: mfd: dlg,da9063: Make #interrupt-cells required Geert Uytterhoeven
2024-02-14 15:58 ` Conor Dooley
@ 2024-02-23 15:16 ` Lee Jones
1 sibling, 0 replies; 3+ messages in thread
From: Lee Jones @ 2024-02-23 15:16 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Support Opensource, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Steve Twiss, devicetree, linux-kernel
On Wed, 14 Feb 2024, Geert Uytterhoeven wrote:
> '#interrupt-cells' is a required property for interrupt providers, hence
> make it required.
>
> While at it, move '#interrupt-cells' in the example to match common sort
> order.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> Documentation/devicetree/bindings/mfd/dlg,da9063.yaml | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/mfd/dlg,da9063.yaml b/Documentation/devicetree/bindings/mfd/dlg,da9063.yaml
> index c5a7e10d7d80e8d7..e5ccc2708f0bb0f8 100644
> --- a/Documentation/devicetree/bindings/mfd/dlg,da9063.yaml
> +++ b/Documentation/devicetree/bindings/mfd/dlg,da9063.yaml
> @@ -87,6 +87,7 @@ required:
> - reg
> - interrupts
> - interrupt-controller
> + - '#interrupt-cells'
This doesn't seem to apply.
> additionalProperties: false
>
> @@ -99,10 +100,10 @@ examples:
> pmic@58 {
> compatible = "dlg,da9063";
> reg = <0x58>;
> - #interrupt-cells = <2>;
> interrupt-parent = <&gpio6>;
> interrupts = <11 IRQ_TYPE_LEVEL_LOW>;
> interrupt-controller;
> + #interrupt-cells = <2>;
>
> rtc {
> compatible = "dlg,da9063-rtc";
> --
> 2.34.1
>
--
Lee Jones [李琼斯]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-02-23 15:16 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-02-14 15:03 [PATCH] dt-bindings: mfd: dlg,da9063: Make #interrupt-cells required Geert Uytterhoeven
2024-02-14 15:58 ` Conor Dooley
2024-02-23 15:16 ` Lee Jones
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).