Re: [PATCH v3 3/4] iio: magnetometer: add a driver for Voltafield AF8133J magnetometer

[Jonathan Cameron <jic23@kernel.org>]

Hi Ondřej,

Quick process comment. 

Please crop replies to avoid never ending scrolling and more importantly
a high chance of what you actually want to say being missed!


> > +static int af8133j_probe(struct i2c_client *client)
> > +{

...

> > +	ret = devm_iio_triggered_buffer_setup(dev, indio_dev, NULL,
> > +					      &af8133j_trigger_handler, NULL);
> > +	if (ret)
> > +		return dev_err_probe(&client->dev, ret,
> > +				     "Failed to setup iio triggered buffer\n");
> > +
> > +	ret = devm_iio_device_register(dev, indio_dev);
> > +	if (ret)
> > +		return dev_err_probe(dev, ret, "Failed to register iio device");
> > +
> > +	pm_runtime_get_noresume(dev);
> > +	pm_runtime_use_autosuspend(dev);
> > +	pm_runtime_set_autosuspend_delay(dev, 500);
> > +	ret = devm_pm_runtime_enable(dev);
> > +	if (ret)
> > +		return ret;  
> 
> Ah, forgot to move this up. Oh, well. I'll send v4.
> 
> kind regards,
> 	o.
> 
> > +	pm_runtime_put_autosuspend(dev);
> > +
> > +	return 0;
> > +}
> > +