From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from relay8-d.mail.gandi.net (relay8-d.mail.gandi.net [217.70.183.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6EBD71C6A3; Mon, 26 Feb 2024 08:19:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.70.183.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708935584; cv=none; b=OkylQflu1ibdtctJnNHDQY048TCHJyV79pNYtfIJvMEhor4DBHBso4F1VRy/esZss+7fuKLVil0ywChuyt9M9OPCDOo0NUhVjrfOBbc3Hp8HBJCFBoEBxnbiSeHZOOHdZeza2mX4hykw1rojABFWmgyZBoXCviz0xURSjlmWkiI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708935584; c=relaxed/simple; bh=ll48MJwAP66eEE4I1mxVSojHViPUkd6NS79nXsjLCi0=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=PQg4QAsY3d3/z4k8t7473NiOQA9rIk7LwJ+C2ILla7DFrVgsF02aBAhZ2vKgKTNIx2nV215reTUBM41QTAQwaKXanthEY/QIat0m+Z74fuc0RjxlUz9wDiCfCgEGvbrd9NhNp14VIkEMMK3tvbJ0ylfJEKNn9jDPnjZUX/Rx9kM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=edDb6HqW; arc=none smtp.client-ip=217.70.183.201 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="edDb6HqW" Received: by mail.gandi.net (Postfix) with ESMTPSA id B1B221BF20A; Mon, 26 Feb 2024 08:19:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1708935574; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=lIvDXxGeo51SInc9MmWiuWKt5CaioIotY1PibSab+q4=; b=edDb6HqW+23DlG3IR4K7W1sKpq7+g2Mi4GEa9/PHxn471OHUsIfql/37IOwKqYQcmckmJy 9CwLpZOVAx2+K3ATxpKSmns9PRxwjW47tdx62GkQyUtY1RmvvV8CJM3hLD5aB/SJGmpR0a Lo15g3MVTuAlsHCu3BFQ6JkUyQVFNuW0lHXRduc7xf2XlXGKlhZotXgMdWGxSxI/DtyjNR 71G/IqLSe7UvOs0TzfIT75FzfbrY7xhOBHErauIzB/WTMdkZTzAmul0GHjPGZsEHvRsUPS H1gqEWyFtoWQSZH03MPQsVIK0/FYoluH8M/9stD9HzPiV9QeoKNwYTf/ZTIAbw== Date: Mon, 26 Feb 2024 09:19:32 +0100 From: Luca Ceresoli To: Saravana Kannan Cc: Rob Herring , Frank Rowand , "=?UTF-8?Q?Herv=C3=A9?= Codina" , kernel-team@android.com, Rob Herring , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] of: property: fw_devlink: Fix stupid bug in remote-endpoint parsing Message-ID: <20240226091932.3f39e2c5@booty> In-Reply-To: <20240224052436.3552333-1-saravanak@google.com> References: <20240224052436.3552333-1-saravanak@google.com> Organization: Bootlin X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.33; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-GND-Sasl: luca.ceresoli@bootlin.com On Fri, 23 Feb 2024 21:24:35 -0800 Saravana Kannan wrote: > Introduced a stupid bug in commit 782bfd03c3ae ("of: property: Improve > finding the supplier of a remote-endpoint property") due to a last minute > incorrect edit of "index !=0" into "!index". This patch fixes it to be > "index > 0" to match the comment right next to it. > > Reported-by: Luca Ceresoli > Link: https://lore.kernel.org/lkml/20240223171849.10f9901d@booty/ > Fixes: 782bfd03c3ae ("of: property: Improve finding the supplier of a remote-endpoint property") > Signed-off-by: Saravana Kannan Reviewed-by: Luca Ceresoli Tested-by: Luca Ceresoli -- Luca Ceresoli, Bootlin Embedded Linux and Kernel engineering https://bootlin.com