From: Rob Herring <robh@kernel.org>
To: "Ondřej Jirman" <megi@xff.cz>
Cc: linux-kernel@vger.kernel.org, Liam Girdwood <lgirdwood@gmail.com>,
Conor Dooley <conor+dt@kernel.org>,
Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>, Chen-Yu Tsai <wens@csie.org>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
Samuel Holland <samuel@sholland.org>,
Arnaud Ferraris <arnaud.ferraris@collabora.com>,
linux-sound@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-sunxi@lists.linux.dev
Subject: Re: [RESEND PATCH v2 1/5] dt-bindings: sound: Add jack-type property to sun8i-a33-codec
Date: Mon, 26 Feb 2024 13:47:27 -0600 [thread overview]
Message-ID: <20240226194727.GA1320480-robh@kernel.org> (raw)
In-Reply-To: <20240224135501.3822390-2-megi@xff.cz>
On Sat, Feb 24, 2024 at 02:54:54PM +0100, Ondřej Jirman wrote:
> From: Ondrej Jirman <megi@xff.cz>
>
> The codec driver needs to know what jack connector it is connected to
> on the board. Add proprty to describe the type of connector.
>
> Signed-off-by: Ondrej Jirman <megi@xff.cz>
> ---
> .../bindings/sound/allwinner,sun8i-a33-codec.yaml | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/sound/allwinner,sun8i-a33-codec.yaml b/Documentation/devicetree/bindings/sound/allwinner,sun8i-a33-codec.yaml
> index 63eadc4200ac..399fc00ad3f4 100644
> --- a/Documentation/devicetree/bindings/sound/allwinner,sun8i-a33-codec.yaml
> +++ b/Documentation/devicetree/bindings/sound/allwinner,sun8i-a33-codec.yaml
> @@ -44,6 +44,15 @@ properties:
> - const: bus
> - const: mod
>
> + jack-type:
I'm all for a generic property name, but it needs to be documented
somewhere common. Perhaps dai-common.yaml.
I'm sure there is some prior art here to consider as well.
Rob
next prev parent reply other threads:[~2024-02-26 19:47 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-24 13:54 [RESEND PATCH v2 0/5] Add support for jack detection to codec present in A64 SoC Ondřej Jirman
2024-02-24 13:54 ` [RESEND PATCH v2 1/5] dt-bindings: sound: Add jack-type property to sun8i-a33-codec Ondřej Jirman
2024-02-26 19:47 ` Rob Herring [this message]
2024-02-26 23:57 ` Ondřej Jirman
2024-03-01 21:36 ` Rob Herring
2024-02-24 13:54 ` [RESEND PATCH v2 2/5] ASoC: sun50i-codec-analog: Move suspend/resume to set_bias_level Ondřej Jirman
2024-02-24 13:54 ` [RESEND PATCH v2 3/5] ASoC: sun8i-codec: Enable bus clock at STANDBY and higher bias Ondřej Jirman
2024-02-24 13:54 ` [RESEND PATCH v2 4/5] ASoC: sun50i-codec-analog: Enable jack detection on startup Ondřej Jirman
2024-02-24 13:54 ` [RESEND PATCH v2 5/5] ASoC: sun8i-codec: Implement jack and accessory detection Ondřej Jirman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240226194727.GA1320480-robh@kernel.org \
--to=robh@kernel.org \
--cc=arnaud.ferraris@collabora.com \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jernej.skrabec@gmail.com \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=megi@xff.cz \
--cc=perex@perex.cz \
--cc=samuel@sholland.org \
--cc=tiwai@suse.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).