Re: [PATCH v4] dt-bindings: gpio: aspeed,ast2400-gpio: Convert to DT schema

[Rob Herring <robh@kernel.org>]

On Mon, Feb 26, 2024 at 08:16:43PM -0600, Rob Herring wrote:
> 
> On Tue, 27 Feb 2024 11:14:14 +1030, Andrew Jeffery wrote:
> > Squash warnings such as:
> > 
> > ```
> > arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-galaxy100.dtb: /ahb/apb@1e600000/gpio@1e780000: failed to match any schema with compatible: ['aspeed,ast2400-gpio']
> > ```
> > 
> > Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>
> > ---
> > v4: Add constraints for gpio-line-names, ngpios as requested by Krzysztof:
> >     https://lore.kernel.org/all/458becdb-fb1e-4808-87b6-3037ec945647@linaro.org/
> > 
> >     Add more examples to exercise constraints.
> > 
> > v3: https://lore.kernel.org/all/20240226051645.414935-1-andrew@codeconstruct.com.au/
> > 
> >     Base on v6.8-rc6, fix yamllint warning
> > 
> >     Rob's bot picked the missing `#interrupt-cells` in the example on v2[1]. The
> >     patch was based on v6.8-rc1, and going back over my shell history I missed
> >     the following output from `make dt_binding_check`:
> > 
> >     ```
> >     ...
> >       LINT    Documentation/devicetree/bindings
> >       usage: yamllint [-h] [-] [-c CONFIG_FILE | -d CONFIG_DATA] [--list-files] [-f {parsable,standard,colored,github,auto}] [-s] [--no-warnings] [-v] [FILE_OR_DIR ...]
> >       yamllint: error: one of the arguments FILE_OR_DIR - is required
> >     ...
> >     ```
> > 
> >     I've rebased on v6.8-rc6 and no-longer see the issue with the invocation
> >     of `yamllint`.
> > 
> > [1]: https://lore.kernel.org/all/170892197611.2260479.15343562563553959436.robh@kernel.org/
> > 
> > v2: https://lore.kernel.org/all/20240226031951.284847-1-andrew@codeconstruct.com.au/
> > 
> >     Address feedback from Krzysztof:
> >     https://lore.kernel.org/all/0d1dd262-b6dd-4d71-9239-8b0aec8cceff@linaro.org/
> > 
> > v1: https://lore.kernel.org/all/20240220052918.742793-1-andrew@codeconstruct.com.au/
> > 
> >  .../bindings/gpio/aspeed,ast2400-gpio.yaml    | 149 ++++++++++++++++++
> >  .../devicetree/bindings/gpio/gpio-aspeed.txt  |  39 -----
> >  2 files changed, 149 insertions(+), 39 deletions(-)
> >  create mode 100644 Documentation/devicetree/bindings/gpio/aspeed,ast2400-gpio.yaml
> >  delete mode 100644 Documentation/devicetree/bindings/gpio/gpio-aspeed.txt
> > 
> 
> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
> on your patch (DT_CHECKER_FLAGS is new in v5.13):
> 
> yamllint warnings/errors:
> 
> dtschema/dtc warnings/errors:
> In file included from Documentation/devicetree/bindings/gpio/aspeed,ast2400-gpio.example.dts:91:
> ./scripts/dtc/include-prefixes/dt-bindings/clock/ast2600-clock.h:14: warning: "ASPEED_CLK_GATE_LCLK" redefined
>    14 | #define ASPEED_CLK_GATE_LCLK            6

The examples aren't isolated from each other, so you can't have 
conflicting includes. You'll have to drop some of the examples or drop 
their use of the conflicting include.

Rob