From: Bastien Curutchet <bastien.curutchet@bootlin.com>
To: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>, Pavel Machek <pavel@ucw.cz>,
Lee Jones <lee@kernel.org>,
Richard Cochran <richardcochran@gmail.com>,
Andrew Lunn <andrew@lunn.ch>,
Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
Bastien Curutchet <bastien.curutchet@bootlin.com>
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
devicetree@vger.kernel.org, linux-leds@vger.kernel.org,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
herve.codina@bootlin.com, maxime.chevallier@bootlin.com,
christophercordahi@nanometrics.ca
Subject: [PATCH v2 4/6] net: phy: DP83640: Add EDPD management
Date: Tue, 27 Feb 2024 10:39:43 +0100 [thread overview]
Message-ID: <20240227093945.21525-5-bastien.curutchet@bootlin.com> (raw)
In-Reply-To: <20240227093945.21525-1-bastien.curutchet@bootlin.com>
The driver does not support enabling/disabling Energy Detect Power Down
(EDPD).
The PHY itself support EDPD.
Add missing part in the driver in order to have this support based on
ethtool {set,get}_phy_tunable functions.
Signed-off-by: Bastien Curutchet <bastien.curutchet@bootlin.com>
---
drivers/net/phy/dp83640.c | 62 +++++++++++++++++++++++++++++++++++
drivers/net/phy/dp83640_reg.h | 4 +++
2 files changed, 66 insertions(+)
diff --git a/drivers/net/phy/dp83640.c b/drivers/net/phy/dp83640.c
index c46c81ef0ad0..16c9fda50b19 100644
--- a/drivers/net/phy/dp83640.c
+++ b/drivers/net/phy/dp83640.c
@@ -1531,6 +1531,66 @@ static void dp83640_remove(struct phy_device *phydev)
kfree(dp83640);
}
+static int dp83640_get_edpd(struct phy_device *phydev, u16 *edpd)
+{
+ int val;
+
+ phy_write(phydev, PAGESEL, 0);
+ val = phy_read(phydev, EDCR);
+ if (val & ED_EN)
+ *edpd = 2000; /* 2 seconds */
+ else
+ *edpd = ETHTOOL_PHY_EDPD_DISABLE;
+
+ return 0;
+}
+
+static int dp83640_set_edpd(struct phy_device *phydev, u16 edpd)
+{
+ int val;
+
+ phy_write(phydev, PAGESEL, 0);
+ val = phy_read(phydev, EDCR);
+
+ switch (edpd) {
+ case ETHTOOL_PHY_EDPD_DFLT_TX_MSECS:
+ case 2000: /* 2 seconds */
+ val |= ED_EN;
+ break;
+ case ETHTOOL_PHY_EDPD_DISABLE:
+ val &= ~ED_EN;
+ break;
+ default:
+ return -EINVAL;
+ }
+
+ phy_write(phydev, EDCR, val);
+
+ return 0;
+}
+
+static int dp83640_get_tunable(struct phy_device *phydev,
+ struct ethtool_tunable *tuna, void *data)
+{
+ switch (tuna->id) {
+ case ETHTOOL_PHY_EDPD:
+ return dp83640_get_edpd(phydev, data);
+ default:
+ return -EOPNOTSUPP;
+ }
+}
+
+static int dp83640_set_tunable(struct phy_device *phydev,
+ struct ethtool_tunable *tuna, const void *data)
+{
+ switch (tuna->id) {
+ case ETHTOOL_PHY_EDPD:
+ return dp83640_set_edpd(phydev, *(u16 *)data);
+ default:
+ return -EOPNOTSUPP;
+ }
+}
+
static int dp83640_led_brightness_set(struct phy_device *phydev, u8 index,
enum led_brightness brightness)
{
@@ -1692,6 +1752,8 @@ static struct phy_driver dp83640_driver = {
.name = "NatSemi DP83640",
/* PHY_BASIC_FEATURES */
.probe = dp83640_probe,
+ .get_tunable = dp83640_get_tunable,
+ .set_tunable = dp83640_set_tunable,
.remove = dp83640_remove,
.soft_reset = dp83640_soft_reset,
.config_init = dp83640_config_init,
diff --git a/drivers/net/phy/dp83640_reg.h b/drivers/net/phy/dp83640_reg.h
index 09dd2d2527c7..bf34d422d91e 100644
--- a/drivers/net/phy/dp83640_reg.h
+++ b/drivers/net/phy/dp83640_reg.h
@@ -9,6 +9,7 @@
#define LEDCR 0x0018 /* PHY Control Register */
#define PHYCR 0x0019 /* PHY Control Register */
#define PHYCR2 0x001c /* PHY Control Register 2 */
+#define EDCR 0x001D /* Energy Detect Control Register */
#define PAGE4 0x0004
#define PTP_CTL 0x0014 /* PTP Control Register */
@@ -64,6 +65,9 @@
/* Bit definitions for the PHYCR2 register */
#define BC_WRITE (1<<11) /* Broadcast Write Enable */
+/* Bit definitions for the EDCR register */
+#define ED_EN BIT(15) /* Enable Energy Detect Mode */
+
/* Bit definitions for the PTP_CTL register */
#define TRIG_SEL_SHIFT (10) /* PTP Trigger Select */
#define TRIG_SEL_MASK (0x7)
--
2.43.0
next prev parent reply other threads:[~2024-02-27 9:40 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-27 9:39 [PATCH v2 0/6] net: phy: Add TI's DP83640 device tree binding Bastien Curutchet
2024-02-27 9:39 ` [PATCH v2 1/6] dt-bindings: net: Add bindings for PHY DP83640 Bastien Curutchet
2024-02-28 11:37 ` Conor Dooley
2024-02-27 9:39 ` [PATCH v2 2/6] leds: trigger: Create a new LED netdev trigger for collision Bastien Curutchet
2024-02-27 16:03 ` Andrew Lunn
2024-02-27 16:26 ` Russell King (Oracle)
2024-02-29 7:24 ` Bastien Curutchet
2024-02-29 15:17 ` Andrew Lunn
2024-02-29 16:58 ` Russell King (Oracle)
2024-02-27 9:39 ` [PATCH v2 3/6] net: phy: DP83640: Add LED handling Bastien Curutchet
2024-02-27 9:58 ` Maxime Chevallier
2024-02-27 10:50 ` Russell King (Oracle)
2024-02-28 15:04 ` Andrew Lunn
2024-02-29 7:28 ` Bastien Curutchet
2024-02-27 9:39 ` Bastien Curutchet [this message]
2024-02-27 10:02 ` [PATCH v2 4/6] net: phy: DP83640: Add EDPD management Maxime Chevallier
2024-02-27 9:39 ` [PATCH v2 5/6] net: phy: DP83640: Explicitly disabling PHY Control Frames Bastien Curutchet
2024-02-27 10:08 ` Maxime Chevallier
2024-02-27 9:39 ` [PATCH v2 6/6] net: phy: DP83640: Add fiber mode enabling/disabling from device tree Bastien Curutchet
2024-02-27 11:01 ` Russell King (Oracle)
2024-02-27 16:18 ` Andrew Lunn
2024-02-29 7:31 ` Bastien Curutchet
2024-02-29 15:23 ` Andrew Lunn
2024-03-01 10:37 ` Maxime Chevallier
2024-03-01 14:00 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240227093945.21525-5-bastien.curutchet@bootlin.com \
--to=bastien.curutchet@bootlin.com \
--cc=andrew@lunn.ch \
--cc=christophercordahi@nanometrics.ca \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=herve.codina@bootlin.com \
--cc=hkallweit1@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=maxime.chevallier@bootlin.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pavel@ucw.cz \
--cc=richardcochran@gmail.com \
--cc=robh+dt@kernel.org \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).