From: Simon Horman <horms@kernel.org>
To: Justin Chen <justin.chen@broadcom.com>
Cc: netdev@vger.kernel.org, florian.fainelli@broadcom.com,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
opendmb@gmail.com, bcm-kernel-feedback-list@broadcom.com,
andrew@lunn.ch, hkallweit1@gmail.com, linux@armlinux.org.uk,
rafal@milecki.pl, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v2 5/6] net: bcmasp: Keep buffers through power management
Date: Wed, 28 Feb 2024 09:45:41 +0000 [thread overview]
Message-ID: <20240228094541.GA292522@kernel.org> (raw)
In-Reply-To: <20240227185454.2767610-6-justin.chen@broadcom.com>
On Tue, Feb 27, 2024 at 10:54:53AM -0800, Justin Chen wrote:
> There is no advantage of freeing and re-allocating buffers through
> suspend and resume. This waste cycles and makes suspend/resume time
> longer. We also open ourselves to failed allocations in systems with
> heavy memory fragmentation.
>
> Signed-off-by: Justin Chen <justin.chen@broadcom.com>
> Acked-by: Florian Fainelli <florian.fainelli@broadcom.com>
...
> @@ -1118,6 +1083,10 @@ static int bcmasp_open(struct net_device *dev)
>
> netif_dbg(intf, ifup, dev, "bcmasp open\n");
>
> + ret = bcmasp_alloc_buffers(intf);
> + if (ret)
> + return ret;
> +
Hi Justin,
Do the resources allocated by bcmasp_alloc_buffers() need
to be released if an error occurs in bcmasp_open() below this line?
> ret = clk_prepare_enable(intf->parent->clk);
> if (ret)
> return ret;
> --
> 2.34.1
>
next prev parent reply other threads:[~2024-02-28 9:45 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-27 18:54 [PATCH net-next v2 0/6] Support for ASP 2.2 and optimizations Justin Chen
2024-02-27 18:54 ` [PATCH net-next v2 1/6] dt-bindings: net: brcm,unimac-mdio: Add asp-v2.2 Justin Chen
2024-02-27 18:54 ` [PATCH net-next v2 2/6] dt-bindings: net: brcm,asp-v2.0: " Justin Chen
2024-02-28 8:12 ` Krzysztof Kozlowski
2024-02-27 18:54 ` [PATCH net-next v2 3/6] net: bcmasp: Add support for ASP 2.2 Justin Chen
2024-02-27 18:54 ` [PATCH net-next v2 4/6] net: phy: mdio-bcm-unimac: Add asp v2.2 support Justin Chen
2024-02-27 18:54 ` [PATCH net-next v2 5/6] net: bcmasp: Keep buffers through power management Justin Chen
2024-02-28 9:45 ` Simon Horman [this message]
2024-02-28 17:53 ` Justin Chen
2024-02-27 18:54 ` [PATCH net-next v2 6/6] net: bcmasp: Add support for PHY interrupts Justin Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240228094541.GA292522@kernel.org \
--to=horms@kernel.org \
--cc=andrew@lunn.ch \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=florian.fainelli@broadcom.com \
--cc=hkallweit1@gmail.com \
--cc=justin.chen@broadcom.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=opendmb@gmail.com \
--cc=pabeni@redhat.com \
--cc=rafal@milecki.pl \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).