From: Conor Dooley <conor@kernel.org>
To: Frank Li <Frank.Li@nxp.com>
Cc: helgaas@kernel.org, bhelgaas@google.com, conor+dt@kernel.org,
devicetree@vger.kernel.org, imx@lists.linux.dev,
krzysztof.kozlowski+dt@linaro.org, kw@linux.com,
linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org,
lpieralisi@kernel.org, robh@kernel.org
Subject: Re: [PATCH v5 5/5] dt-bindings: pci: layerscape-pci-ep: Remove 'fsl,pcie-scfg' and 'dma-coherence' from required
Date: Thu, 29 Feb 2024 18:16:39 +0000 [thread overview]
Message-ID: <20240229-putdown-gyration-6aaa6d156547@spud> (raw)
In-Reply-To: <20240228190321.580846-6-Frank.Li@nxp.com>
[-- Attachment #1: Type: text/plain, Size: 1162 bytes --]
On Wed, Feb 28, 2024 at 02:03:21PM -0500, Frank Li wrote:
> Remove 'fsl,pcie-scfg' and 'dma-coherence' properties from required because
> not all chips is dma coherenced and have supplement configuration unit
> (scfg).
>
> Signed-off-by: Frank Li <Frank.Li@nxp.com>
I'd squash this with 3/5 and move both of them before the addition of
the reference to the main snps stuff. That way you'll not get
dt_binding_check complaints on multiple patches.
Cheers,
Conor.
> ---
> .../devicetree/bindings/pci/fsl,layerscape-pcie-ep.yaml | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/pci/fsl,layerscape-pcie-ep.yaml b/Documentation/devicetree/bindings/pci/fsl,layerscape-pcie-ep.yaml
> index e75b8853dca8c..07965683beece 100644
> --- a/Documentation/devicetree/bindings/pci/fsl,layerscape-pcie-ep.yaml
> +++ b/Documentation/devicetree/bindings/pci/fsl,layerscape-pcie-ep.yaml
> @@ -67,8 +67,6 @@ required:
> - compatible
> - reg
> - interrupt-names
> - - fsl,pcie-scfg
> - - dma-coherence
>
> allOf:
> - $ref: /schemas/pci/snps,dw-pcie-ep.yaml#
> --
> 2.34.1
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
prev parent reply other threads:[~2024-02-29 18:16 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-28 19:03 [PATCH v5 0/5] dt-bindings: pci: layerscape-pci: Convert to yaml format Frank Li
2024-02-28 19:03 ` [PATCH v5 1/5] " Frank Li
2024-02-28 21:03 ` Rob Herring
2024-02-29 17:43 ` Frank Li
2024-02-29 18:08 ` Conor Dooley
2024-03-01 14:47 ` Rob Herring
2024-02-28 19:03 ` [PATCH v5 2/5] dt-bindings: pci: layerscape-pci: Add snps,dw-pcie.yaml reference Frank Li
2024-02-28 19:03 ` [PATCH v5 3/5] dt-bindings: pci: layerscape-pci: Remove 'fsl,pcie-scfg' and 'dma-coherence' from required Frank Li
2024-02-28 19:03 ` [PATCH v5 4/5] dt-bindings: pci: layerscape-pci-ep: Add snps,dw-pcie-ep.yaml reference Frank Li
2024-02-28 21:03 ` Rob Herring
2024-02-28 19:03 ` [PATCH v5 5/5] dt-bindings: pci: layerscape-pci-ep: Remove 'fsl,pcie-scfg' and 'dma-coherence' from required Frank Li
2024-02-29 18:16 ` Conor Dooley [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240229-putdown-gyration-6aaa6d156547@spud \
--to=conor@kernel.org \
--cc=Frank.Li@nxp.com \
--cc=bhelgaas@google.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=helgaas@kernel.org \
--cc=imx@lists.linux.dev \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kw@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox