[PATCH AUTOSEL 6.1 04/12] riscv: dts: sifive: add missing #interrupt-cells to pmic

devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed

* [PATCH AUTOSEL 6.1 04/12] riscv: dts: sifive: add missing #interrupt-cells to pmic
       [not found] <20240229204039.2861519-1-sashal@kernel.org>
@ 2024-02-29 20:40 ` Sasha Levin
  2024-02-29 20:40 ` [PATCH AUTOSEL 6.1 12/12] arm64: dts: Fix dtc interrupt_provider warnings Sasha Levin
  1 sibling, 0 replies; 7+ messages in thread
From: Sasha Levin @ 2024-02-29 20:40 UTC (permalink / raw)
  To: linux-kernel, stable
  Cc: Conor Dooley, Samuel Holland, Sasha Levin, conor, robh+dt,
	krzysztof.kozlowski+dt, palmer, paul.walmsley, aou, linux-riscv,
	devicetree

From: Conor Dooley <conor.dooley@microchip.com>

[ Upstream commit ce6b6d1513965f500a05f3facf223fa01fd74920 ]

At W=2 dtc complains:
hifive-unmatched-a00.dts:120.10-238.4: Warning (interrupt_provider): /soc/i2c@10030000/pmic@58: Missing '#interrupt-cells' in interrupt provider

Add the missing property.

Reviewed-by: Samuel Holland <samuel.holland@sifive.com>
Signed-off-by: Conor Dooley <conor.dooley@microchip.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
 arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts b/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts
index 07387f9c135ca..72b87b08ab444 100644
--- a/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts
+++ b/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts
@@ -123,6 +123,7 @@ pmic@58 {
 		interrupt-parent = <&gpio>;
 		interrupts = <1 IRQ_TYPE_LEVEL_LOW>;
 		interrupt-controller;
+		#interrupt-cells = <2>;
 
 		onkey {
 			compatible = "dlg,da9063-onkey";
-- 
2.43.0


^ permalink raw reply related	[flat|nested] 7+ messages in thread

* [PATCH AUTOSEL 6.1 12/12] arm64: dts: Fix dtc interrupt_provider warnings
       [not found] <20240229204039.2861519-1-sashal@kernel.org>
  2024-02-29 20:40 ` [PATCH AUTOSEL 6.1 04/12] riscv: dts: sifive: add missing #interrupt-cells to pmic Sasha Levin
@ 2024-02-29 20:40 ` Sasha Levin
  2024-03-11 21:04   ` Pavel Machek
  1 sibling, 1 reply; 7+ messages in thread
From: Sasha Levin @ 2024-02-29 20:40 UTC (permalink / raw)
  To: linux-kernel, stable
  Cc: Rob Herring, AngeloGioacchino Del Regno, Geert Uytterhoeven,
	Florian Fainelli, Chanho Min, Arnd Bergmann, Sasha Levin, tsahee,
	atenart, robh+dt, krzysztof.kozlowski+dt, conor+dt, rjui,
	sbranden, andrew, gregory.clement, sebastian.hesselbarth,
	matthias.bgg, magnus.damm, linux-arm-kernel, devicetree,
	linux-mediatek, linux-renesas-soc

From: Rob Herring <robh@kernel.org>

[ Upstream commit 91adecf911e5df78ea3e8f866e69db2c33416a5c ]

The dtc interrupt_provider warning is off by default. Fix all the warnings
so it can be enabled.

Signed-off-by: Rob Herring <robh@kernel.org>
Reviewed-By: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> #
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Acked-by: Geert Uytterhoeven <geert+renesas@glider.be>
Acked-by: Florian Fainelli <florian.fainelli@broadcom.com> #Broadcom
Acked-by: Chanho Min <chanho.min@lge.com>
Link: https://lore.kernel.org/r/20240213-arm-dt-cleanups-v1-3-f2dee1292525@kernel.org
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
 arch/arm64/boot/dts/amazon/alpine-v2.dtsi           | 1 -
 arch/arm64/boot/dts/amazon/alpine-v3.dtsi           | 1 -
 arch/arm64/boot/dts/broadcom/northstar2/ns2.dtsi    | 1 +
 arch/arm64/boot/dts/broadcom/stingray/stingray.dtsi | 1 +
 arch/arm64/boot/dts/lg/lg1312.dtsi                  | 1 -
 arch/arm64/boot/dts/lg/lg1313.dtsi                  | 1 -
 arch/arm64/boot/dts/marvell/armada-ap80x.dtsi       | 1 -
 arch/arm64/boot/dts/mediatek/mt8195-demo.dts        | 1 +
 arch/arm64/boot/dts/renesas/ulcb-kf.dtsi            | 4 ++++
 9 files changed, 7 insertions(+), 5 deletions(-)

diff --git a/arch/arm64/boot/dts/amazon/alpine-v2.dtsi b/arch/arm64/boot/dts/amazon/alpine-v2.dtsi
index 4eb2cd14e00b0..9b6da84deae7a 100644
--- a/arch/arm64/boot/dts/amazon/alpine-v2.dtsi
+++ b/arch/arm64/boot/dts/amazon/alpine-v2.dtsi
@@ -145,7 +145,6 @@ pci@fbc00000 {
 		msix: msix@fbe00000 {
 			compatible = "al,alpine-msix";
 			reg = <0x0 0xfbe00000 0x0 0x100000>;
-			interrupt-controller;
 			msi-controller;
 			al,msi-base-spi = <160>;
 			al,msi-num-spis = <160>;
diff --git a/arch/arm64/boot/dts/amazon/alpine-v3.dtsi b/arch/arm64/boot/dts/amazon/alpine-v3.dtsi
index 73a352ea8fd5c..b30014d4dc29c 100644
--- a/arch/arm64/boot/dts/amazon/alpine-v3.dtsi
+++ b/arch/arm64/boot/dts/amazon/alpine-v3.dtsi
@@ -351,7 +351,6 @@ pcie@fbd00000 {
 		msix: msix@fbe00000 {
 			compatible = "al,alpine-msix";
 			reg = <0x0 0xfbe00000 0x0 0x100000>;
-			interrupt-controller;
 			msi-controller;
 			al,msi-base-spi = <336>;
 			al,msi-num-spis = <959>;
diff --git a/arch/arm64/boot/dts/broadcom/northstar2/ns2.dtsi b/arch/arm64/boot/dts/broadcom/northstar2/ns2.dtsi
index fda97c47f4e97..d5778417455c0 100644
--- a/arch/arm64/boot/dts/broadcom/northstar2/ns2.dtsi
+++ b/arch/arm64/boot/dts/broadcom/northstar2/ns2.dtsi
@@ -584,6 +584,7 @@ gpio_g: gpio@660a0000 {
 			#gpio-cells = <2>;
 			gpio-controller;
 			interrupt-controller;
+			#interrupt-cells = <2>;
 			interrupts = <GIC_SPI 400 IRQ_TYPE_LEVEL_HIGH>;
 		};
 
diff --git a/arch/arm64/boot/dts/broadcom/stingray/stingray.dtsi b/arch/arm64/boot/dts/broadcom/stingray/stingray.dtsi
index 8f8c25e51194d..473d7d0ddf369 100644
--- a/arch/arm64/boot/dts/broadcom/stingray/stingray.dtsi
+++ b/arch/arm64/boot/dts/broadcom/stingray/stingray.dtsi
@@ -442,6 +442,7 @@ gpio_hsls: gpio@d0000 {
 			#gpio-cells = <2>;
 			gpio-controller;
 			interrupt-controller;
+			#interrupt-cells = <2>;
 			interrupts = <GIC_SPI 183 IRQ_TYPE_LEVEL_HIGH>;
 			gpio-ranges = <&pinmux 0 0 16>,
 					<&pinmux 16 71 2>,
diff --git a/arch/arm64/boot/dts/lg/lg1312.dtsi b/arch/arm64/boot/dts/lg/lg1312.dtsi
index 78ae73d0cf365..98ff17b14b2a5 100644
--- a/arch/arm64/boot/dts/lg/lg1312.dtsi
+++ b/arch/arm64/boot/dts/lg/lg1312.dtsi
@@ -124,7 +124,6 @@ eth0: ethernet@c1b00000 {
 	amba {
 		#address-cells = <2>;
 		#size-cells = <1>;
-		#interrupt-cells = <3>;
 
 		compatible = "simple-bus";
 		interrupt-parent = <&gic>;
diff --git a/arch/arm64/boot/dts/lg/lg1313.dtsi b/arch/arm64/boot/dts/lg/lg1313.dtsi
index 2173316573bee..8e9410d8f46c0 100644
--- a/arch/arm64/boot/dts/lg/lg1313.dtsi
+++ b/arch/arm64/boot/dts/lg/lg1313.dtsi
@@ -124,7 +124,6 @@ eth0: ethernet@c3700000 {
 	amba {
 		#address-cells = <2>;
 		#size-cells = <1>;
-		#interrupt-cells = <3>;
 
 		compatible = "simple-bus";
 		interrupt-parent = <&gic>;
diff --git a/arch/arm64/boot/dts/marvell/armada-ap80x.dtsi b/arch/arm64/boot/dts/marvell/armada-ap80x.dtsi
index a06a0a889c43f..73d8803b54d8b 100644
--- a/arch/arm64/boot/dts/marvell/armada-ap80x.dtsi
+++ b/arch/arm64/boot/dts/marvell/armada-ap80x.dtsi
@@ -133,7 +133,6 @@ pmu {
 
 			odmi: odmi@300000 {
 				compatible = "marvell,odmi-controller";
-				interrupt-controller;
 				msi-controller;
 				marvell,odmi-frames = <4>;
 				reg = <0x300000 0x4000>,
diff --git a/arch/arm64/boot/dts/mediatek/mt8195-demo.dts b/arch/arm64/boot/dts/mediatek/mt8195-demo.dts
index 5117b2e7985af..998c2e78168a6 100644
--- a/arch/arm64/boot/dts/mediatek/mt8195-demo.dts
+++ b/arch/arm64/boot/dts/mediatek/mt8195-demo.dts
@@ -111,6 +111,7 @@ mt6360: pmic@34 {
 		compatible = "mediatek,mt6360";
 		reg = <0x34>;
 		interrupt-controller;
+		#interrupt-cells = <1>;
 		interrupts-extended = <&pio 101 IRQ_TYPE_EDGE_FALLING>;
 		interrupt-names = "IRQB";
 
diff --git a/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi b/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi
index 588b14b66b6fb..f37abfc13fe59 100644
--- a/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi
+++ b/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi
@@ -251,6 +251,7 @@ gpio_exp_74: gpio@74 {
 		gpio-controller;
 		#gpio-cells = <2>;
 		interrupt-controller;
+		#interrupt-cells = <2>;
 		interrupt-parent = <&gpio6>;
 		interrupts = <8 IRQ_TYPE_EDGE_FALLING>;
 
@@ -311,6 +312,7 @@ gpio_exp_75: gpio@75 {
 		gpio-controller;
 		#gpio-cells = <2>;
 		interrupt-controller;
+		#interrupt-cells = <2>;
 		interrupt-parent = <&gpio6>;
 		interrupts = <4 IRQ_TYPE_EDGE_FALLING>;
 	};
@@ -331,6 +333,7 @@ gpio_exp_76: gpio@76 {
 		gpio-controller;
 		#gpio-cells = <2>;
 		interrupt-controller;
+		#interrupt-cells = <2>;
 		interrupt-parent = <&gpio7>;
 		interrupts = <3 IRQ_TYPE_EDGE_FALLING>;
 	};
@@ -341,6 +344,7 @@ gpio_exp_77: gpio@77 {
 		gpio-controller;
 		#gpio-cells = <2>;
 		interrupt-controller;
+		#interrupt-cells = <2>;
 		interrupt-parent = <&gpio5>;
 		interrupts = <9 IRQ_TYPE_EDGE_FALLING>;
 	};
-- 
2.43.0


^ permalink raw reply related	[flat|nested] 7+ messages in thread

* Re: [PATCH AUTOSEL 6.1 12/12] arm64: dts: Fix dtc interrupt_provider warnings
  2024-02-29 20:40 ` [PATCH AUTOSEL 6.1 12/12] arm64: dts: Fix dtc interrupt_provider warnings Sasha Levin
@ 2024-03-11 21:04   ` Pavel Machek
  2024-03-12  8:20     ` Geert Uytterhoeven
  0 siblings, 1 reply; 7+ messages in thread
From: Pavel Machek @ 2024-03-11 21:04 UTC (permalink / raw)
  To: Sasha Levin
  Cc: linux-kernel, stable, Rob Herring, AngeloGioacchino Del Regno,
	Geert Uytterhoeven, Florian Fainelli, Chanho Min, Arnd Bergmann,
	tsahee, atenart, robh+dt, krzysztof.kozlowski+dt, conor+dt, rjui,
	sbranden, andrew, gregory.clement, sebastian.hesselbarth,
	matthias.bgg, magnus.damm, linux-arm-kernel, devicetree,
	linux-mediatek, linux-renesas-soc

[-- Attachment #1: Type: text/plain, Size: 419 bytes --]

Hi!

> From: Rob Herring <robh@kernel.org>
> 
> [ Upstream commit 91adecf911e5df78ea3e8f866e69db2c33416a5c ]
> 
> The dtc interrupt_provider warning is off by default. Fix all the warnings
> so it can be enabled.

We don't have that warning in 6.1 and likely won't enable it, so we
should not need this.

Best regards,
								Pavel
-- 
People of Russia, stop Putin before his war on Ukraine escalates.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH AUTOSEL 6.1 12/12] arm64: dts: Fix dtc interrupt_provider warnings
  2024-03-11 21:04   ` Pavel Machek
@ 2024-03-12  8:20     ` Geert Uytterhoeven
  2024-03-12  8:38       ` Pavel Machek
  0 siblings, 1 reply; 7+ messages in thread
From: Geert Uytterhoeven @ 2024-03-12  8:20 UTC (permalink / raw)
  To: Pavel Machek
  Cc: Sasha Levin, linux-kernel, stable, Rob Herring,
	AngeloGioacchino Del Regno, Geert Uytterhoeven, Florian Fainelli,
	Chanho Min, Arnd Bergmann, tsahee, atenart, robh+dt,
	krzysztof.kozlowski+dt, conor+dt, rjui, sbranden, andrew,
	gregory.clement, sebastian.hesselbarth, matthias.bgg, magnus.damm,
	linux-arm-kernel, devicetree, linux-mediatek, linux-renesas-soc

Hi Pavel,

On Mon, Mar 11, 2024 at 10:04 PM Pavel Machek <pavel@ucw.cz> wrote:
> > From: Rob Herring <robh@kernel.org>
> >
> > [ Upstream commit 91adecf911e5df78ea3e8f866e69db2c33416a5c ]
> >
> > The dtc interrupt_provider warning is off by default. Fix all the warnings
> > so it can be enabled.
>
> We don't have that warning in 6.1 and likely won't enable it, so we
> should not need this.

Still, this fixes issues in DTS that were not noticed before because
the checks were disabled.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH AUTOSEL 6.1 12/12] arm64: dts: Fix dtc interrupt_provider warnings
  2024-03-12  8:20     ` Geert Uytterhoeven
@ 2024-03-12  8:38       ` Pavel Machek
  2024-03-12  8:43         ` Geert Uytterhoeven
  2024-03-12  9:12         ` AngeloGioacchino Del Regno
  0 siblings, 2 replies; 7+ messages in thread
From: Pavel Machek @ 2024-03-12  8:38 UTC (permalink / raw)
  To: Geert Uytterhoeven
  Cc: Sasha Levin, linux-kernel, stable, Rob Herring,
	AngeloGioacchino Del Regno, Geert Uytterhoeven, Florian Fainelli,
	Chanho Min, Arnd Bergmann, tsahee, atenart, robh+dt,
	krzysztof.kozlowski+dt, conor+dt, rjui, sbranden, andrew,
	gregory.clement, sebastian.hesselbarth, matthias.bgg, magnus.damm,
	linux-arm-kernel, devicetree, linux-mediatek, linux-renesas-soc

[-- Attachment #1: Type: text/plain, Size: 611 bytes --]

Hi!

> > > From: Rob Herring <robh@kernel.org>
> > >
> > > [ Upstream commit 91adecf911e5df78ea3e8f866e69db2c33416a5c ]
> > >
> > > The dtc interrupt_provider warning is off by default. Fix all the warnings
> > > so it can be enabled.
> >
> > We don't have that warning in 6.1 and likely won't enable it, so we
> > should not need this.
> 
> Still, this fixes issues in DTS that were not noticed before because
> the checks were disabled.

Is this patch known to fix user-visible behaviour?

Best regards,
								Pavel
-- 
People of Russia, stop Putin before his war on Ukraine escalates.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH AUTOSEL 6.1 12/12] arm64: dts: Fix dtc interrupt_provider warnings
  2024-03-12  8:38       ` Pavel Machek
@ 2024-03-12  8:43         ` Geert Uytterhoeven
  2024-03-12  9:12         ` AngeloGioacchino Del Regno
  1 sibling, 0 replies; 7+ messages in thread
From: Geert Uytterhoeven @ 2024-03-12  8:43 UTC (permalink / raw)
  To: Pavel Machek
  Cc: Sasha Levin, linux-kernel, stable, Rob Herring,
	AngeloGioacchino Del Regno, Florian Fainelli, Chanho Min,
	Arnd Bergmann, tsahee, atenart, robh+dt, krzysztof.kozlowski+dt,
	conor+dt, rjui, sbranden, andrew, gregory.clement,
	sebastian.hesselbarth, matthias.bgg, magnus.damm,
	linux-arm-kernel, devicetree, linux-mediatek, linux-renesas-soc

Hi Pavel,

On Tue, Mar 12, 2024 at 9:38 AM Pavel Machek <pavel@ucw.cz> wrote:
> > > > From: Rob Herring <robh@kernel.org>
> > > >
> > > > [ Upstream commit 91adecf911e5df78ea3e8f866e69db2c33416a5c ]
> > > >
> > > > The dtc interrupt_provider warning is off by default. Fix all the warnings
> > > > so it can be enabled.
> > >
> > > We don't have that warning in 6.1 and likely won't enable it, so we
> > > should not need this.
> >
> > Still, this fixes issues in DTS that were not noticed before because
> > the checks were disabled.
>
> Is this patch known to fix user-visible behaviour?

None that I am aware of.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH AUTOSEL 6.1 12/12] arm64: dts: Fix dtc interrupt_provider warnings
  2024-03-12  8:38       ` Pavel Machek
  2024-03-12  8:43         ` Geert Uytterhoeven
@ 2024-03-12  9:12         ` AngeloGioacchino Del Regno
  1 sibling, 0 replies; 7+ messages in thread
From: AngeloGioacchino Del Regno @ 2024-03-12  9:12 UTC (permalink / raw)
  To: Pavel Machek, Geert Uytterhoeven
  Cc: Sasha Levin, linux-kernel, stable, Rob Herring,
	Geert Uytterhoeven, Florian Fainelli, Chanho Min, Arnd Bergmann,
	tsahee, atenart, robh+dt, krzysztof.kozlowski+dt, conor+dt, rjui,
	sbranden, andrew, gregory.clement, sebastian.hesselbarth,
	matthias.bgg, magnus.damm, linux-arm-kernel, devicetree,
	linux-mediatek, linux-renesas-soc

Il 12/03/24 09:38, Pavel Machek ha scritto:
> Hi!
> 
>>>> From: Rob Herring <robh@kernel.org>
>>>>
>>>> [ Upstream commit 91adecf911e5df78ea3e8f866e69db2c33416a5c ]
>>>>
>>>> The dtc interrupt_provider warning is off by default. Fix all the warnings
>>>> so it can be enabled.
>>>
>>> We don't have that warning in 6.1 and likely won't enable it, so we
>>> should not need this.
>>
>> Still, this fixes issues in DTS that were not noticed before because
>> the checks were disabled.
> 
> Is this patch known to fix user-visible behaviour?
> 

No, doesn't fix any user-visible issue.

Cheers,
Angelo

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2024-03-12  9:13 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <20240229204039.2861519-1-sashal@kernel.org>
2024-02-29 20:40 ` [PATCH AUTOSEL 6.1 04/12] riscv: dts: sifive: add missing #interrupt-cells to pmic Sasha Levin
2024-02-29 20:40 ` [PATCH AUTOSEL 6.1 12/12] arm64: dts: Fix dtc interrupt_provider warnings Sasha Levin
2024-03-11 21:04   ` Pavel Machek
2024-03-12  8:20     ` Geert Uytterhoeven
2024-03-12  8:38       ` Pavel Machek
2024-03-12  8:43         ` Geert Uytterhoeven
2024-03-12  9:12         ` AngeloGioacchino Del Regno

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).