From: Rob Herring <robh@kernel.org>
To: Frank Li <Frank.li@nxp.com>
Cc: imx@lists.linux.dev, conor@kernel.org,
krzysztof.kozlowski+dt@linaro.org, kw@linux.com,
linux-kernel@vger.kernel.org, conor+dt@kernel.org,
linux-pci@vger.kernel.org, lpieralisi@kernel.org,
helgaas@kernel.org, bhelgaas@google.com,
devicetree@vger.kernel.org
Subject: Re: [PATCH v5 1/5] dt-bindings: pci: layerscape-pci: Convert to yaml format
Date: Fri, 1 Mar 2024 08:47:38 -0600 [thread overview]
Message-ID: <20240301144738.GA2110767-robh@kernel.org> (raw)
In-Reply-To: <ZeDCQezI2zj8bWBP@lizhi-Precision-Tower-5810>
On Thu, Feb 29, 2024 at 12:43:29PM -0500, Frank Li wrote:
> On Wed, Feb 28, 2024 at 03:03:31PM -0600, Rob Herring wrote:
> >
> > On Wed, 28 Feb 2024 14:03:17 -0500, Frank Li wrote:
> > > Split layerscape-pci.txt into two yaml files: fsl,layerscape-pcie-ep.yaml
> > > and fsl,layerscape-pcie.yaml.
> > > yaml files contain the same content as the original txt file.
> > >
> > > The subsequent commit will fix DTB_CHECK failure.
> > >
> > > Signed-off-by: Frank Li <Frank.Li@nxp.com>
> > > ---
> > > .../bindings/pci/fsl,layerscape-pcie-ep.yaml | 89 +++++++++++++
> > > .../bindings/pci/fsl,layerscape-pcie.yaml | 123 ++++++++++++++++++
> > > .../bindings/pci/layerscape-pci.txt | 79 -----------
> > > 3 files changed, 212 insertions(+), 79 deletions(-)
> > > create mode 100644 Documentation/devicetree/bindings/pci/fsl,layerscape-pcie-ep.yaml
> > > create mode 100644 Documentation/devicetree/bindings/pci/fsl,layerscape-pcie.yaml
> > > delete mode 100644 Documentation/devicetree/bindings/pci/layerscape-pci.txt
> > >
> >
> > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
> > on your patch (DT_CHECKER_FLAGS is new in v5.13):
>
> Please omit these errors. Bjorn require create a identical version as
> old txt file.
>
> Origial txt will cause DTB_CHECK error. The problem will be fixed at next
> patches.
Nope. We can't have warnings. Please fix them in the conversion. Call
out the changes in the commit message.
Rob
next prev parent reply other threads:[~2024-03-01 14:47 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-28 19:03 [PATCH v5 0/5] dt-bindings: pci: layerscape-pci: Convert to yaml format Frank Li
2024-02-28 19:03 ` [PATCH v5 1/5] " Frank Li
2024-02-28 21:03 ` Rob Herring
2024-02-29 17:43 ` Frank Li
2024-02-29 18:08 ` Conor Dooley
2024-03-01 14:47 ` Rob Herring [this message]
2024-02-28 19:03 ` [PATCH v5 2/5] dt-bindings: pci: layerscape-pci: Add snps,dw-pcie.yaml reference Frank Li
2024-02-28 19:03 ` [PATCH v5 3/5] dt-bindings: pci: layerscape-pci: Remove 'fsl,pcie-scfg' and 'dma-coherence' from required Frank Li
2024-02-28 19:03 ` [PATCH v5 4/5] dt-bindings: pci: layerscape-pci-ep: Add snps,dw-pcie-ep.yaml reference Frank Li
2024-02-28 21:03 ` Rob Herring
2024-02-28 19:03 ` [PATCH v5 5/5] dt-bindings: pci: layerscape-pci-ep: Remove 'fsl,pcie-scfg' and 'dma-coherence' from required Frank Li
2024-02-29 18:16 ` Conor Dooley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240301144738.GA2110767-robh@kernel.org \
--to=robh@kernel.org \
--cc=Frank.li@nxp.com \
--cc=bhelgaas@google.com \
--cc=conor+dt@kernel.org \
--cc=conor@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=helgaas@kernel.org \
--cc=imx@lists.linux.dev \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kw@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).