From: skseofh@gmail.com
To: robh+dt@kernel.org, frowand.list@gmail.com
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Daero Lee <skseofh@gmail.com>
Subject: [PATCH] of: fdt: add size 0 check after page align
Date: Sat, 2 Mar 2024 23:03:35 +0900 [thread overview]
Message-ID: <20240302140335.117769-1-skseofh@gmail.com> (raw)
From: Daero Lee <skseofh@gmail.com>
After page aligning, the size may become zero. So I added exception
handling code for size 0.
example : 4K page size
[before page align]
base = 0x1800
size = 0x1100
[after page align]
size = 0x900
base = 0x2000
size &= PAGE_MASK(~0x7FFF) = 0
Signed-off-by: Daero Lee <skseofh@gmail.com>
---
drivers/of/fdt.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/of/fdt.c b/drivers/of/fdt.c
index bf502ba8da95..01156088fbb4 100644
--- a/drivers/of/fdt.c
+++ b/drivers/of/fdt.c
@@ -1232,6 +1232,11 @@ void __init __weak early_init_dt_add_memory_arch(u64 base, u64 size)
base = PAGE_ALIGN(base);
}
size &= PAGE_MASK;
+ if (!size) {
+ pr_warn("Ignoring memory block 0x%llx - 0x%llx\n",
+ base, base + size);
+ return;
+ }
if (base > MAX_MEMBLOCK_ADDR) {
pr_warn("Ignoring memory block 0x%llx - 0x%llx\n",
--
2.25.1
next reply other threads:[~2024-03-02 14:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-02 14:03 skseofh [this message]
2024-03-04 13:26 ` [PATCH] of: fdt: add size 0 check after page align Rob Herring
2024-03-04 14:51 ` skseofh
2024-03-04 15:02 ` [PATCH] of: fdt: modify small size memory check skseofh
2024-03-04 17:05 ` Rob Herring
2024-03-04 22:38 ` skseofh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240302140335.117769-1-skseofh@gmail.com \
--to=skseofh@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).