From: Jonathan Cameron <jic23@kernel.org>
To: David Lechner <dlechner@baylibre.com>
Cc: linux-iio@vger.kernel.org,
"Michael Hennerich" <Michael.Hennerich@analog.com>,
"Rob Herring" <robh+dt@kernel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Nuno Sá" <nuno.sa@analog.com>,
"Liam Girdwood" <lgirdwood@gmail.com>,
"Mark Brown" <broonie@kernel.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 1/2] dt-bindings: iio: adc: add ad7944 ADCs
Date: Sun, 3 Mar 2024 13:23:46 +0000 [thread overview]
Message-ID: <20240303132346.3db77d20@jic23-huawei> (raw)
In-Reply-To: <20240229-ad7944-mainline-v4-1-f88b5ec4baed@baylibre.com>
On Thu, 29 Feb 2024 10:25:50 -0600
David Lechner <dlechner@baylibre.com> wrote:
> This adds a new binding for the Analog Devices, Inc. AD7944, AD7985, and
> AD7986 ADCs.
>
> Signed-off-by: David Lechner <dlechner@baylibre.com>
Hi David,
One trivial comment. If this is all that comes up I can tweak that whilst applying.
Jonathan
...
> + adi,spi-mode:
> + $ref: /schemas/types.yaml#/definitions/string
> + enum: [ single, chain ]
> + description: |
> + This property indicates the SPI wiring configuration.
> +
> + When this property is omitted, it is assumed that the device is using what
> + the he datasheet calls "4-wire mode". This is the conventional SPI mode
Stray "he"?
> + used when there are multiple devices on the same bus. In this mode, the
> + CNV line is used to initiate the conversion and the SDI line is connected
> + to CS on the SPI controller.
>
next prev parent reply other threads:[~2024-03-03 13:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-29 16:25 [PATCH v4 0/2] iio: adc: ad7944: new driver David Lechner
2024-02-29 16:25 ` [PATCH v4 1/2] dt-bindings: iio: adc: add ad7944 ADCs David Lechner
2024-03-03 13:23 ` Jonathan Cameron [this message]
2024-03-04 16:28 ` Rob Herring
2024-02-29 16:25 ` [PATCH v4 2/2] iio: adc: ad7944: add driver for AD7944/AD7985/AD7986 David Lechner
2024-03-03 13:43 ` Jonathan Cameron
2024-03-04 14:28 ` David Lechner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240303132346.3db77d20@jic23-huawei \
--to=jic23@kernel.org \
--cc=Michael.Hennerich@analog.com \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).