From: Rob Herring <robh@kernel.org>
To: Frank Li <Frank.Li@nxp.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
Shengjiu Wang <shengjiu.wang@nxp.com>,
linux-sound@vger.kernel.org, devicetree@vger.kernel.org,
imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 3/4] ASoC: dt-bindings: fsl-sai: allow only one dma-names
Date: Mon, 4 Mar 2024 08:58:59 -0600 [thread overview]
Message-ID: <20240304145859.GA208747-robh@kernel.org> (raw)
In-Reply-To: <20240228-asrc_8qxp-v3-3-d4d5935fd3aa@nxp.com>
On Wed, Feb 28, 2024 at 02:14:15PM -0500, Frank Li wrote:
> Some sai only connect one direction. So allow only "rx" or "tx" for
> dma-names.
>
> Signed-off-by: Frank Li <Frank.Li@nxp.com>
> ---
> Documentation/devicetree/bindings/sound/fsl,sai.yaml | 12 ++++++++----
> 1 file changed, 8 insertions(+), 4 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/sound/fsl,sai.yaml b/Documentation/devicetree/bindings/sound/fsl,sai.yaml
> index 2456d958adeef..0302752d58a2b 100644
> --- a/Documentation/devicetree/bindings/sound/fsl,sai.yaml
> +++ b/Documentation/devicetree/bindings/sound/fsl,sai.yaml
> @@ -86,10 +86,14 @@ properties:
> - description: DMA controller phandle and request line for TX
>
> dma-names:
> - minItems: 1
> - items:
> - - const: rx
Just this change is enough:
- enum: [ rx, tx ]
(We enforce unique items elsewhere already)
> - - const: tx
> + oneOf:
> + - items:
> + - const: rx
> + - const: tx
> + - items:
> + - enum:
> + - rx
> + - tx
next prev parent reply other threads:[~2024-03-04 14:59 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-28 19:14 [PATCH v3 0/4] arm64: dts: imx8qxp add asrc and sai Frank Li
2024-02-28 19:14 ` [PATCH v3 1/4] ASoC: dt-bindings: fsl,imx-asrc/spdif: Add power-domains requirement Frank Li
2024-02-29 9:44 ` Krzysztof Kozlowski
2024-03-01 4:01 ` Frank Li
2024-03-01 6:30 ` Krzysztof Kozlowski
2024-03-01 15:42 ` Frank Li
2024-03-04 15:05 ` Krzysztof Kozlowski
2024-03-04 15:39 ` Frank Li
2024-02-28 19:14 ` [PATCH v3 2/4] ASoC: dt-bindings: fsl,imx-asrc: update max interrupt numbers Frank Li
2024-02-29 9:44 ` Krzysztof Kozlowski
2024-03-01 4:03 ` Frank Li
2024-03-01 6:30 ` Krzysztof Kozlowski
2024-03-01 15:39 ` Frank Li
2024-03-04 14:56 ` Rob Herring
2024-02-28 19:14 ` [PATCH v3 3/4] ASoC: dt-bindings: fsl-sai: allow only one dma-names Frank Li
2024-02-29 9:46 ` Krzysztof Kozlowski
2024-03-01 4:06 ` Frank Li
2024-03-04 14:58 ` Rob Herring [this message]
2024-02-28 19:14 ` [PATCH v3 4/4] arm64: dts: imx8qxp: add asrc[0,1], esai0, spdif[0,1] and sai[4,5] Frank Li
2024-03-01 4:53 ` [PATCH v3 0/4] arm64: dts: imx8qxp add asrc and sai Frank Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240304145859.GA208747-robh@kernel.org \
--to=robh@kernel.org \
--cc=Frank.Li@nxp.com \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=imx@lists.linux.dev \
--cc=kernel@pengutronix.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=shengjiu.wang@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).