From: skseofh@gmail.com
To: robh+dt@kernel.org
Cc: devicetree@vger.kernel.org, frowand.list@gmail.com,
linux-kernel@vger.kernel.org, skseofh@gmail.com
Subject: [PATCH] of: fdt: modify small size memory check
Date: Tue, 5 Mar 2024 07:38:30 +0900 [thread overview]
Message-ID: <20240304223831.11288-1-skseofh@gmail.com> (raw)
In-Reply-To: <CAL_JsqKaZ4KcvfNZmn2gj+yXa8eLgzMpdhJJ=+OmMJPvzm-1Qg@mail.gmail.com>
> >
> >
> > >>
> > >> From: Daero Lee <skseofh@gmail.com>
> > >>
> > >> After page aligning, the size may become zero. So I added exception
> > >> handling code for size 0.
> > >
> > >That may be true, but when would anyone only have memory regions of
> > >less than 2 pages. In any case memblock_add will just do nothing. What
> > >is the actual problem you are having?
> > >
> > >Rob
> >
> > Ignore the previous mail.
> > I modified the patch to clear this size check routine. Please check
>
> You still haven't answered my questions above.
>
> Though the patch below is a bit more readable than what we currently have...
Well.. I don't see any 'real' problem with this.
But I'm not sure if it's appropriate to leave a part that will be returned
directly in the next fuction called. Wouldn't it be better to handle the part
can be handled in this function, rather than expecting the next function to
handle this exception?
prev parent reply other threads:[~2024-03-04 22:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-02 14:03 [PATCH] of: fdt: add size 0 check after page align skseofh
2024-03-04 13:26 ` Rob Herring
2024-03-04 14:51 ` skseofh
2024-03-04 15:02 ` [PATCH] of: fdt: modify small size memory check skseofh
2024-03-04 17:05 ` Rob Herring
2024-03-04 22:38 ` skseofh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240304223831.11288-1-skseofh@gmail.com \
--to=skseofh@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).