[PATCH v3] dt-bindings: hwmon: tda38640: Add interrupt & regulator properties

[PATCH v3] dt-bindings: hwmon: tda38640: Add interrupt & regulator properties

[Naresh Solanki]

Add properties for interrupt & regulator.
Also update example.

Signed-off-by: Naresh Solanki <naresh.solanki@9elements.com>

---
Changes in V3:
1. Update regulator node from vout0 to vout.

Changes in V2:
1. Remove TEST=..
2. Update regulator subnode property as vout0
3. Restore commented line in example
4. blank line after interrupts property in example.
---
 .../hwmon/pmbus/infineon,tda38640.yaml        | 28 +++++++++++++++++++
 1 file changed, 28 insertions(+)

diff --git a/Documentation/devicetree/bindings/hwmon/pmbus/infineon,tda38640.yaml b/Documentation/devicetree/bindings/hwmon/pmbus/infineon,tda38640.yaml
index ded1c115764b..5c4e52b472ad 100644
--- a/Documentation/devicetree/bindings/hwmon/pmbus/infineon,tda38640.yaml
+++ b/Documentation/devicetree/bindings/hwmon/pmbus/infineon,tda38640.yaml
@@ -30,6 +30,23 @@ properties:
       unconnected(has internal pull-down).
     type: boolean
 
+  interrupts:
+    maxItems: 1
+
+  regulators:
+    type: object
+    description:
+      list of regulators provided by this controller.
+
+    properties:
+      vout:
+        $ref: /schemas/regulator/regulator.yaml#
+        type: object
+
+        unevaluatedProperties: false
+
+    additionalProperties: false
+
 required:
   - compatible
   - reg
@@ -38,6 +55,7 @@ additionalProperties: false
 
 examples:
   - |
+    #include <dt-bindings/interrupt-controller/irq.h>
     i2c {
         #address-cells = <1>;
         #size-cells = <0>;
@@ -45,5 +63,15 @@ examples:
         tda38640@40 {
             compatible = "infineon,tda38640";
             reg = <0x40>;
+
+            interrupt-parent = <&smb_pex_cpu0_event>;
+            interrupts = <10 IRQ_TYPE_LEVEL_LOW>;
+
+            regulators {
+                pvnn_main_cpu0: vout {
+                    regulator-name = "pvnn_main_cpu0";
+                    regulator-enable-ramp-delay = <200>;
+                };
+            };
         };
     };

base-commit: 78cc80d834ed3b792605bc9c2215ed9e63825459
-- 
2.42.0

Re: [PATCH v3] dt-bindings: hwmon: tda38640: Add interrupt & regulator properties

[Krzysztof Kozlowski]

On 05/03/2024 22:07, Naresh Solanki wrote:
> Add properties for interrupt & regulator.
> Also update example.

Nothing improved.

Broken record. You got the same comment 3rd or 4th time!

NAK

Best regards,
Krzysztof

Re: [PATCH v3] dt-bindings: hwmon: tda38640: Add interrupt & regulator properties

[Naresh Solanki]

Hi Krzysztof,


On Wed, 6 Mar 2024 at 12:44, Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
>
> On 05/03/2024 22:07, Naresh Solanki wrote:
> > Add properties for interrupt & regulator.
> > Also update example.
>
> Nothing improved.
Yes, Just aligned the regulator node name in this revision.
I missed aligning the commit message.

I'll fix in next revision & update commit message as:

tda38640 has a single regulator output along with
CAT_FAULT# pin to report internal events.
Hence add properties for regulator & interrupt.

Let me know if any others changes needed.

Regards,
Naresh

>
> Broken record. You got the same comment 3rd or 4th time!
>
> NAK
>
> Best regards,
> Krzysztof
>

Re: [PATCH v3] dt-bindings: hwmon: tda38640: Add interrupt & regulator properties

[Conor Dooley]

[-- Attachment #1: Type: text/plain, Size: 837 bytes --]

On Wed, Mar 06, 2024 at 03:20:02PM +0530, Naresh Solanki wrote:
> Hi Krzysztof,
> 
> 
> On Wed, 6 Mar 2024 at 12:44, Krzysztof Kozlowski
> <krzysztof.kozlowski@linaro.org> wrote:
> >
> > On 05/03/2024 22:07, Naresh Solanki wrote:
> > > Add properties for interrupt & regulator.
> > > Also update example.
> >
> > Nothing improved.
> Yes, Just aligned the regulator node name in this revision.
> I missed aligning the commit message.
> 
> I'll fix in next revision & update commit message as:
> 
> tda38640 has a single regulator output along with
> CAT_FAULT# pin to report internal events.
> Hence add properties for regulator & interrupt.
> 
> Let me know if any others changes needed.

That should be fine - but your line wrapping is really odd, you can make
use of 72 characters but you are wrapping at ~50.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: [PATCH v3] dt-bindings: hwmon: tda38640: Add interrupt & regulator properties

[Naresh Solanki]

Hi,


On Thu, 7 Mar 2024 at 00:08, Conor Dooley <conor@kernel.org> wrote:
>
> On Wed, Mar 06, 2024 at 03:20:02PM +0530, Naresh Solanki wrote:
> > Hi Krzysztof,
> >
> >
> > On Wed, 6 Mar 2024 at 12:44, Krzysztof Kozlowski
> > <krzysztof.kozlowski@linaro.org> wrote:
> > >
> > > On 05/03/2024 22:07, Naresh Solanki wrote:
> > > > Add properties for interrupt & regulator.
> > > > Also update example.
> > >
> > > Nothing improved.
> > Yes, Just aligned the regulator node name in this revision.
> > I missed aligning the commit message.
> >
> > I'll fix in next revision & update commit message as:
> >
> > tda38640 has a single regulator output along with
> > CAT_FAULT# pin to report internal events.
> > Hence add properties for regulator & interrupt.
> >
> > Let me know if any others changes needed.
>
> That should be fine - but your line wrapping is really odd, you can make
> use of 72 characters but you are wrapping at ~50.
Sure. Will push another revision with the changes.

Thanks & Regards,
Naresh