From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f170.google.com (mail-pg1-f170.google.com [209.85.215.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5D18A5D904 for ; Wed, 6 Mar 2024 09:39:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709717946; cv=none; b=LNy/JOTC88hqlswPhmhPvO7bwbJn6ERpoDA1ZKZNK/Zp2s1u3N60hGSRjUJRrWxZuH64MgzHZ/XiwT6iShPWu5v5Bj1YaYFu9wxKh8mOZ4NXjgALL9zgmbCOPMuvFh6H0Z9ny2sKc3Ly7YnF4uE/3qsoYFDt3/RrsqQ2vjbrYcE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709717946; c=relaxed/simple; bh=tZqOWl/U+Elbnt1R7UGa8ygGo0JWMb8haTOc9kpg6ZA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=JTCbskXpZDXgxHvDU/Tk2j2wMQE0kuG8jRhFYi0JAoIC/9NUgw4sytjYVx/Jnn61TBSouO3BBNbU6iyyvrs+/qj46h4q3WDaOMeiJH5AG8OjVGaGNdaM5g1wrla2zmBbDhndbxdUpsmjQTinsGjRDIDjfCv4/y5sYyfc0xAlV4A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=L6prxrGX; arc=none smtp.client-ip=209.85.215.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="L6prxrGX" Received: by mail-pg1-f170.google.com with SMTP id 41be03b00d2f7-5d42e7ab8a9so4645452a12.3 for ; Wed, 06 Mar 2024 01:39:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1709717945; x=1710322745; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=B9/QgTMyt6fHk74mMOMoiAquWcsGjb450gZKkLexk1U=; b=L6prxrGXTA52RVYVPuhlpSGRlK7POfhoePJeok+mqUHFwsHncqxj5XtbELkyfy7RJP ZDvVz50pKFpzHk0V2jea7EJdQiacSjRRgH8ypAggOndXlDHamMY2oYTie+cBlLfhdPhb Xwv0Im/OXk2p8Y4UQHsepXuwWMMBOgdKre6cu8QpowzdjtD9R7x37IDHJ4iQttgXNWHW MwWS6h7/5lLa1+gpFEBAbRqoA3xBAHU3OE4osAuut7jtBH2kKZ/kccKquBDI2ZabX7uV 2f5rsf83Av5HCGVVW4jmFYSyUh+vNHWTuhNYE02Y29jrpZ1+DMT25jT4NcOxz7QIEvZc c9nw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709717945; x=1710322745; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=B9/QgTMyt6fHk74mMOMoiAquWcsGjb450gZKkLexk1U=; b=dTMNI8JMa5rwFp9M6W0j+tmnYITX2sYhoawbSCvHnWusEr2UHGTdBQJ3Ho318PvINP ADGK8lEaHsfGIbeQlzhZOpQ0BrIuXBbGhPau53qDvX6icMXYYkuEpWPrF3qWiG6yc/Zy JiO9qLYUrpVs8mnmegxnOU0pgFl3mc2uzSMmQkjIPD1CdsytGZSWcCKV3aEIo6TM5yYf dMCYSvPvTvbuj/78NimkMP5XdJ5zSrrmJyyQa/6mDN208UaigtRozsIm+OQor23hoTbN A4lWWwjBc+5+xHpvqkg+3NFLLzEZ8+2mm66EqEnQwE/HdgY+FPrAelrJjYZkvjiJEZQ2 u2gg== X-Forwarded-Encrypted: i=1; AJvYcCWfAPE41xGj0UN4DZ8RyYpKrpSgxVtzEbO4CB1vrWu81dFCBKJblv8FOJrgs8M+s3txN+fg6x5/+r8FWBKaCMCD26pb6fkpfsKglw== X-Gm-Message-State: AOJu0YxlrSNn2nJ6Cxherm/QSIJ0NtUu1vrBzSCN6dRLkpYSEQJdRcAG zNxwf0vUOCBzJuOPqT+yaVOO/Oqn0deMmeeI0blG14npplsudWk7l02Jr9dSVg== X-Google-Smtp-Source: AGHT+IHbO1CHuqg+60eRdVkKVCxleqZt9OqbjKUuy5Fd7mfWIapm625mEDrgXo2J1vMHZLAWyc1MHQ== X-Received: by 2002:a17:90a:688c:b0:29a:bdbe:5859 with SMTP id a12-20020a17090a688c00b0029abdbe5859mr10903212pjd.7.1709717944519; Wed, 06 Mar 2024 01:39:04 -0800 (PST) Received: from thinkpad ([117.248.1.194]) by smtp.gmail.com with ESMTPSA id oj13-20020a17090b4d8d00b0029b13f233f6sm10337019pjb.11.2024.03.06.01.39.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Mar 2024 01:39:04 -0800 (PST) Date: Wed, 6 Mar 2024 15:08:57 +0530 From: Manivannan Sadhasivam To: Johan Hovold Cc: Dmitry Baryshkov , Johan Hovold , Bjorn Helgaas , Bjorn Andersson , Konrad Dybcio , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-msm@vger.kernel.org, linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 00/10] arm64: dts: qcom: sc8280xp: PCIe fixes and GICv3 ITS enable Message-ID: <20240306093857.GC4129@thinkpad> References: <20240305081105.11912-1-johan+linaro@kernel.org> <20240306063302.GA4129@thinkpad> <20240306083925.GB4129@thinkpad> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Wed, Mar 06, 2024 at 10:12:31AM +0100, Johan Hovold wrote: > On Wed, Mar 06, 2024 at 10:48:30AM +0200, Dmitry Baryshkov wrote: > > On Wed, 6 Mar 2024 at 10:39, Manivannan Sadhasivam > > wrote: > > > On Wed, Mar 06, 2024 at 08:20:16AM +0100, Johan Hovold wrote: > > > > On Wed, Mar 06, 2024 at 12:03:02PM +0530, Manivannan Sadhasivam wrote: > > > > > > Just received confirmation from Qcom that L0s is not supported for any of the > > > > > PCIe instances in sc8280xp (and its derivatives). Please move the property to > > > > > SoC dtsi. > > > > > Ok, thanks for confirming. But then the devicetree property is not the > > > > right way to handle this, and we should disable L0s based on the > > > > compatible string instead. > > > > Hmm. I checked further and got the info that there is no change in the IP, but > > > the PHY sequence is not tuned correctly for L0s (as I suspected earlier). So > > > there will be AERs when L0s is enabled on any controller instance. And there > > > will be no updated PHY sequence in the future also for this chipset. > > > > Why? If it is a bug in the PHY driver, it should be fixed there > > instead of adding workarounds. > > ASPM L0s is currently broken on these platforms and, as far as I > understand, both under Windows and Linux. Since Qualcomm hasn't been > able to come up with the necessary PHY init sequences for these > platforms yet, I doubt they will suddenly appear in the near future. > > So we need to disable L0s for now. If an updated PHY init sequence later > appears, we can always enable it again. > It could be the same case for all 'non-mobile' chipsets (automotive, compute, modem). So instead of using the compatible, please add a flag and set that for all non-mobile SoCs. Like the ones starting with SAxxx, SCxxx, SDxxx. - Mani -- மணிவண்ணன் சதாசிவம்