[PATCH 0/4] Random 8280 bits

[PATCH 0/4] Random 8280 bits

[Konrad Dybcio]

As the series title and patch titles say

p1 for Srini/nvmem, rest for qcom

Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
---
Konrad Dybcio (4):
      dt-bindings: nvmem: Add compatible for SC8280XP
      arm64: dts: qcom: sc8280xp: Add QFPROM node
      arm64: dts: qcom: sc8280xp: Add PS_HOLD restart
      arm64: dts: qcom: sc8280xp: Describe TCSR download mode register

 .../devicetree/bindings/nvmem/qcom,qfprom.yaml         |  1 +
 arch/arm64/boot/dts/qcom/sc8280xp.dtsi                 | 18 ++++++++++++++++++
 2 files changed, 19 insertions(+)
---
base-commit: 1843e16d2df9d98427ef8045589571749d627cf7
change-id: 20240307-topic-8280_nodes-da70ee866935

Best regards,
-- 
Konrad Dybcio <konrad.dybcio@linaro.org>

[PATCH 1/4] dt-bindings: nvmem: Add compatible for SC8280XP

[Konrad Dybcio]

Document the QFPROM block found on SC8280XP.

Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
---
 Documentation/devicetree/bindings/nvmem/qcom,qfprom.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/nvmem/qcom,qfprom.yaml b/Documentation/devicetree/bindings/nvmem/qcom,qfprom.yaml
index 8c8f05d9eaf1..65df38bfc17c 100644
--- a/Documentation/devicetree/bindings/nvmem/qcom,qfprom.yaml
+++ b/Documentation/devicetree/bindings/nvmem/qcom,qfprom.yaml
@@ -34,6 +34,7 @@ properties:
           - qcom,qcs404-qfprom
           - qcom,sc7180-qfprom
           - qcom,sc7280-qfprom
+          - qcom,sc8280xp-qfprom
           - qcom,sdm630-qfprom
           - qcom,sdm670-qfprom
           - qcom,sdm845-qfprom

-- 
2.40.1

Re: [PATCH 1/4] dt-bindings: nvmem: Add compatible for SC8280XP

[Rob Herring]

On Thu, Mar 07, 2024 at 09:25:54PM +0100, Konrad Dybcio wrote:
> Document the QFPROM block found on SC8280XP.
> 
> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
> ---
>  Documentation/devicetree/bindings/nvmem/qcom,qfprom.yaml | 1 +
>  1 file changed, 1 insertion(+)

Acked-by: Rob Herring <robh@kernel.org>

[PATCH 2/4] arm64: dts: qcom: sc8280xp: Add QFPROM node

[Konrad Dybcio]

Describe the QFPROM NVMEM block. Also, add a subnode to represent the
GPU speed bin region within it.

Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
---
 arch/arm64/boot/dts/qcom/sc8280xp.dtsi | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
index a5b194813079..a3725d917bef 100644
--- a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
@@ -862,6 +862,18 @@ ipcc: mailbox@408000 {
 			#mbox-cells = <2>;
 		};
 
+		qfprom: efuse@784000 {
+			compatible = "qcom,sc8280xp-qfprom", "qcom,qfprom";
+			reg = <0 0x00784000 0 0x3000>;
+			#address-cells = <1>;
+			#size-cells = <1>;
+
+			gpu_speed_bin: gpu-speed-bin@18b {
+				reg = <0x18b 0x1>;
+				bits = <5 3>;
+			};
+		};
+
 		qup2: geniqup@8c0000 {
 			compatible = "qcom,geni-se-qup";
 			reg = <0 0x008c0000 0 0x2000>;

-- 
2.40.1

[PATCH 3/4] arm64: dts: qcom: sc8280xp: Add PS_HOLD restart

[Konrad Dybcio]

Killing the platform with a single write and no firmware involvement is
pretty cool, add support for it.

Note that due to restart notifier priority settings, PSCI reset will
be used instead, unless:

a) PSCI is not exposed by the firmware (e.g. because the fw was replaced)
or
b) PSCI restart fails for some reason

Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
---
 arch/arm64/boot/dts/qcom/sc8280xp.dtsi | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
index a3725d917bef..44c8d543eb67 100644
--- a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
@@ -4460,6 +4460,11 @@ tsens0: thermal-sensor@c263000 {
 			#thermal-sensor-cells = <1>;
 		};
 
+		restart@c264000 {
+			compatible = "qcom,pshold";
+			reg = <0 0x0c264000 0 0x4>;
+		};
+
 		tsens1: thermal-sensor@c265000 {
 			compatible = "qcom,sc8280xp-tsens", "qcom,tsens-v2";
 			reg = <0 0x0c265000 0 0x1ff>, /* TM */

-- 
2.40.1

[PATCH 4/4] arm64: dts: qcom: sc8280xp: Describe TCSR download mode register

[Konrad Dybcio]

To allow for swift EDL reboots, describe the respective register under
the scm node.

Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
---
 arch/arm64/boot/dts/qcom/sc8280xp.dtsi | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
index 44c8d543eb67..505cae44f828 100644
--- a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
@@ -300,6 +300,7 @@ firmware {
 		scm: scm {
 			compatible = "qcom,scm-sc8280xp", "qcom,scm";
 			interconnects = <&aggre2_noc MASTER_CRYPTO 0 &mc_virt SLAVE_EBI1 0>;
+			qcom,dload-mode = <&tcsr 0x13000>;
 		};
 	};
 

-- 
2.40.1

Re: (subset) [PATCH 0/4] Random 8280 bits

[Bjorn Andersson]

On Thu, 07 Mar 2024 21:25:53 +0100, Konrad Dybcio wrote:
> As the series title and patch titles say
> 
> p1 for Srini/nvmem, rest for qcom
> 
> 

Applied, thanks!

[2/4] arm64: dts: qcom: sc8280xp: Add QFPROM node
      commit: dc6cb3854c44de4c7ac9fd173208f5d19ed5d882
[3/4] arm64: dts: qcom: sc8280xp: Add PS_HOLD restart
      commit: 865ff2e6f5daf4ea822120c873f4ba43eb2d8db7
[4/4] arm64: dts: qcom: sc8280xp: Describe TCSR download mode register
      commit: 27ef06ebd289992ad4469632b440cd0b072be562

Best regards,
-- 
Bjorn Andersson <andersson@kernel.org>

Re: (subset) [PATCH 0/4] Random 8280 bits

[Srinivas Kandagatla]

On Thu, 07 Mar 2024 21:25:53 +0100, Konrad Dybcio wrote:
> As the series title and patch titles say
> 
> p1 for Srini/nvmem, rest for qcom
> 
> 

Applied, thanks!

[1/4] dt-bindings: nvmem: Add compatible for SC8280XP
      commit: 2ce7240c076fbd9a4c9c787c8c81596644199196

Best regards,
-- 
Srinivas Kandagatla <srinivas.kandagatla@linaro.org>

Re: [PATCH 0/4] Random 8280 bits

[Steev Klimaszewski]

On Thu, Mar 7, 2024 at 2:26 PM Konrad Dybcio <konrad.dybcio@linaro.org> wrote:
>
> As the series title and patch titles say
>
> p1 for Srini/nvmem, rest for qcom
>
> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
> ---
> Konrad Dybcio (4):
>       dt-bindings: nvmem: Add compatible for SC8280XP
>       arm64: dts: qcom: sc8280xp: Add QFPROM node
>       arm64: dts: qcom: sc8280xp: Add PS_HOLD restart
>       arm64: dts: qcom: sc8280xp: Describe TCSR download mode register
>
>  .../devicetree/bindings/nvmem/qcom,qfprom.yaml         |  1 +
>  arch/arm64/boot/dts/qcom/sc8280xp.dtsi                 | 18 ++++++++++++++++++
>  2 files changed, 19 insertions(+)
> ---
> base-commit: 1843e16d2df9d98427ef8045589571749d627cf7
> change-id: 20240307-topic-8280_nodes-da70ee866935
>
> Best regards,
> --
> Konrad Dybcio <konrad.dybcio@linaro.org>
>
>

My apologies for sending this so late, since this is now in -next,
but, I'd gotten reports of people with the X13s not shutting down when
using "my kernel" - I finally had the chance to dig through and do
some testing today and it seems that with this patchset applied, is
when the X13s will no longer power off.  Telling the system to
poweroff or shutdown simply causes a reboot instead.