From: Rob Herring <robh@kernel.org>
To: Xu Yang <xu.yang_2@nxp.com>
Cc: gregkh@linuxfoundation.org, krzysztof.kozlowski+dt@linaro.org,
shawnguo@kernel.org, conor+dt@kernel.org, s.hauer@pengutronix.de,
kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com,
peter.chen@kernel.org, jun.li@nxp.com, linux-usb@vger.kernel.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
imx@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v9 05/11] dt-bindings: usb: ci-hdrc-usb2-imx: add restrictions for reg, interrupts, clock and clock-names properties
Date: Sun, 17 Mar 2024 13:55:24 -0600 [thread overview]
Message-ID: <20240317195524.GA2109053-robh@kernel.org> (raw)
In-Reply-To: <20240315072455.2481613-5-xu.yang_2@nxp.com>
On Fri, Mar 15, 2024 at 03:24:49PM +0800, Xu Yang wrote:
> Add restrictions for reg, interrupts, clock and clock-names properties
> for imx Socs.
>
> Signed-off-by: Xu Yang <xu.yang_2@nxp.com>
>
> ---
[...]
> + # imx7d Soc need one clock
> + - if:
> + properties:
> + compatible:
> + items:
> + - const: fsl,imx7d-usb
> + - const: fsl,imx27-usb
> + then:
> + properties:
> + clocks:
> + maxItems: 1
> + clock-names: false
> +
> + # other Soc need one clock
> + - if:
> + properties:
> + compatible:
> + contains:
> + enum:
> + - fsl,imx23-usb
> + - fsl,imx28-usb
> + - fsl,imx50-usb
> + - fsl,imx51-usb
> + - fsl,imx53-usb
> + - fsl,imx6q-usb
> + - fsl,imx6sl-usb
> + - fsl,imx6sx-usb
> + - fsl,imx6ul-usb
> + - fsl,imx8mm-usb
> + - fsl,imx8mn-usb
> + - fsl,vf610-usb
Can't you add 'fsl,imx7d-usb' here and drop the previous if/then?
With that,
Reviewed-by: Rob Herring <robh@kernel.org>
> + then:
> + properties:
> + clocks:
> + maxItems: 1
> + clock-names: false
> +
> unevaluatedProperties: false
>
> examples:
> --
> 2.34.1
>
next prev parent reply other threads:[~2024-03-17 19:55 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-15 7:24 [PATCH v9 01/11] dt-bindings: usb: usbmisc-imx: add fsl,imx8ulp-usbmisc compatible Xu Yang
2024-03-15 7:24 ` [PATCH v9 02/11] arm64: dts: imx8ulp: add usb nodes Xu Yang
2024-03-15 7:24 ` [PATCH v9 03/11] arm64: dts: imx8ulp-evk: enable usb nodes and add ptn5150 nodes Xu Yang
2024-03-15 7:24 ` [PATCH v9 04/11] dt-bindings: usb: chipidea,usb2-imx: move imx parts to dedicated schema Xu Yang
2024-03-15 7:24 ` [PATCH v9 05/11] dt-bindings: usb: ci-hdrc-usb2-imx: add restrictions for reg, interrupts, clock and clock-names properties Xu Yang
2024-03-17 19:55 ` Rob Herring [this message]
2024-03-18 3:41 ` [EXT] " Xu Yang
2024-03-15 7:24 ` [PATCH v9 06/11] dt-bindings: usb: ci-hdrc-usb2-imx: add compatible and clock-names restriction for imx93 Xu Yang
2024-03-15 7:24 ` [PATCH v9 07/11] ARM: dts: imx6: remove fsl,anatop property from usb controller node Xu Yang
2024-03-15 7:24 ` [PATCH v9 08/11] arm64: dts: imx93: add usb nodes Xu Yang
2024-03-15 7:24 ` [PATCH v9 09/11] arm64: dts: imx93-11x11-evk: enable usb and typec nodes Xu Yang
2024-03-15 7:24 ` [PATCH v9 10/11] arm64: dts: imx8m* remove clock-names property from usb controller node Xu Yang
2024-03-15 7:24 ` [PATCH v9 11/11] usb: chipidea: ci_hdrc_imx: align usb wakeup clock name with dt-bindings Xu Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240317195524.GA2109053-robh@kernel.org \
--to=robh@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=imx@lists.linux.dev \
--cc=jun.li@nxp.com \
--cc=kernel@pengutronix.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=peter.chen@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=xu.yang_2@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).