From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B80BD79C8; Thu, 21 Mar 2024 17:10:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711041053; cv=none; b=S41tDKqxnpiw+NnDC/EJ6Xcu7DdW3/PZS76Hvtjp+vvvd7+xVtDvJGD4Qe9tMy4CQM+DoDC+9QtHSeWU4NirRJ3fRRbNe5MTRgGk9wOpHNk2CqWn8CqE7flF9vyYm9GZukja/z//VsnpvPVdKRHOwKK85TWfqKChJAw657mzeIk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711041053; c=relaxed/simple; bh=UkRBA9m/bMZZJvffQTihUXbWdPF0Er76xufEfdcCUN4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=fl7QCAkxhuC7cXxQe+9CmRWWa0WNHABBQHv/WjZUVmO8ppptN+J/NEDxcHfNolcnGj5lFbBC6Q0XFCfILJTNEEIBlMRtE0V64RPYoRKvwLxrmBxFqWkwWtIUMEujU4cfSq6ykv8jn223nSzJtERHo023cG7BNbsa3NWWTmYpYc4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=kVFJRTie; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="kVFJRTie" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B8816C433F1; Thu, 21 Mar 2024 17:10:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1711041053; bh=UkRBA9m/bMZZJvffQTihUXbWdPF0Er76xufEfdcCUN4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=kVFJRTied2TKQUlnrJFstv2V+6Tbgc6Y2xON57K5nFft6DGpzAwHcMVsjE9jPaTp4 eCG6telo3hioMcSp8Gw6j8hRwG18vCJdhvwgbnASXpQt0gmiEQFGoejR2PP1qswSeY dqNtG7NZ48/A60BEBj5BcCpUhOLaTrPGLkPY2E94mRvILvQ+ZFrhIFALdgkgR6/epr n6hG8lElYJxkUCPLWohcz8bA/+jhfTEO+g5GcmQW04rNY0zVr8sAdEYoiduiQTZdh/ xaFxGsEPvw9YWczy+gaG54bS5u8azyVageijosILeHM5elsbNGZD6iFQ10eUeTKpNh 74wCiw4gpn4hA== Date: Thu, 21 Mar 2024 17:10:48 +0000 From: Lee Jones To: Andre Przywara Cc: Liam Girdwood , Mark Brown , Chen-Yu Tsai , Rob Herring , Krzysztof Kozlowski , Conor Dooley , devicetree@vger.kernel.org, Samuel Holland , Jernej Skrabec , Chris Morgan , linux-kernel@vger.kernel.org, linux-sunxi@lists.linux.dev Subject: Re: [PATCH 0/4] regulator: Add X-Powers AXP717 PMIC support Message-ID: <20240321171048.GD13211@google.com> References: <20240310010211.28653-1-andre.przywara@arm.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20240310010211.28653-1-andre.przywara@arm.com> On Sun, 10 Mar 2024, Andre Przywara wrote: > This patch series adds support for the X-Powers AXP717 PMIC, which is > used recently on new boards with Allwinner SoCs. > Allwinner's BSP code often speaks of the AXP2202, this seems to be the > same chip, at least a boot0 AXP2202 driver happily drove a chip labelled > AXP717. > > Patch 1 fixes a typo in some macro names for the AXP313a PMIC, I just > realised that during some copy&paste action. It's just an identifier > rename, so not a backport candidate, I'd say. > Patch 2 adds the compatible string to the binding document. > Patch 3 is the MFD part, describing the regmap and all the interrupts. > So far we support the regulator and power key devices, the USB and > charging devices will follow later. > Patch 4 adds the voltage regulator rails, this part is crucial to enable > any board using this PMIC, as we depend on those rails even for basic > devices. > > Please note that I could not test this driver myself, but had success > messages from others. It would be good to hear from Ryan and Chris > here on the list, with a Tested-by: tag. > > This series is based on next-20240308 for now. I will send a rebased > update after the merge window, but wanted to start discussion and review > now. > > Please have a look! > > Cheers, > Andre > > Andre Przywara (4): > regulator: axp20x: fix typo-ed identifier > dt-bindings: mfd: x-powers,axp152: document AXP717 > mfd: axp20x: add support for AXP717 PMIC > regulator: axp20x: add support for the AXP717 > > .../bindings/mfd/x-powers,axp152.yaml | 2 + > drivers/mfd/axp20x-i2c.c | 2 + > drivers/mfd/axp20x-rsb.c | 1 + > drivers/mfd/axp20x.c | 90 +++++++++++++++++ > drivers/regulator/axp20x-regulator.c | 94 +++++++++++++++++- > include/linux/mfd/axp20x.h | 98 ++++++++++++++++++- > 6 files changed, 277 insertions(+), 10 deletions(-) All applied and sent for build testing. If everything works out, I'll send out a pull-request to an immutable branch shortly. -- Lee Jones [李琼斯]