From: Rob Herring <robh@kernel.org>
To: Javier Carrasco <javier.carrasco.cruz@gmail.com>
Cc: Alexandre Belloni <alexandre.belloni@bootlin.com>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Baruch Siach <baruch@tkos.co.il>,
linux-rtc@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/4] dt-bindings: rtc: armada-380-rtc: convert to dtschema
Date: Mon, 25 Mar 2024 11:02:31 -0500 [thread overview]
Message-ID: <20240325160231.GB4035876-robh@kernel.org> (raw)
In-Reply-To: <6e68e0ca-2f3e-41a7-bb96-00fbdadc4436@gmail.com>
On Sun, Mar 24, 2024 at 01:02:31AM +0100, Javier Carrasco wrote:
> On 3/24/24 00:37, Alexandre Belloni wrote:
> > On 23/03/2024 23:46:13+0100, Javier Carrasco wrote:
> >> Convert existing binding to dtschema to support validation.
> >>
> >> +required:
> >> + - compatible
> >> + - reg
> >> + - reg-names
> >> + - interrupts
> >> +
> >> +additionalProperties: false
> >
> > This is not correct because at least start-year is supported. Please
> > check for all your other submissions too.
> >
>
> allOf:
> - $ref: rtc.yaml#
>
> is missing, and then
>
> unvealuatedProperties: false
>
> to account for that.
>
> "start-year" is read in the RTC base class, so I wonder why so many RTC
> bindings add a reference to rtc.yaml, but then use
>
> additionalProperties: false
They may have pre-dated support for 'unevaluatedProperties', or you can
list out which properties are used from a referenced schema which
disallows unlisted properties. There's no hard rule here. Either way is
fine.
Other than this and my 1 other comment, this series looks fine to me.
Rob
next prev parent reply other threads:[~2024-03-25 16:02 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-23 22:46 [PATCH 0/4] dt-bindings: rtc: convert multiple devices to dtschema Javier Carrasco
2024-03-23 22:46 ` [PATCH 1/4] dt-bindings: rtc: armada-380-rtc: convert " Javier Carrasco
2024-03-23 23:37 ` Alexandre Belloni
2024-03-24 0:02 ` Javier Carrasco
2024-03-25 16:02 ` Rob Herring [this message]
2024-03-23 22:46 ` [PATCH 2/4] dt-bindings: rtc: alphascale,asm9260: " Javier Carrasco
2024-03-23 22:46 ` [PATCH 3/4] dt-bindings: rtc: digicolor-rtc: " Javier Carrasco
2024-03-25 16:01 ` Rob Herring
2024-03-25 19:46 ` Javier Carrasco
2024-03-25 20:03 ` Krzysztof Kozlowski
2024-03-23 22:46 ` [PATCH 4/4] dt-bindings: rtc: nxp,lpc1788-rtc: " Javier Carrasco
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240325160231.GB4035876-robh@kernel.org \
--to=robh@kernel.org \
--cc=alexandre.belloni@bootlin.com \
--cc=baruch@tkos.co.il \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=javier.carrasco.cruz@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).