* [PATCH 0/2] arm64: dts: qcom: msm8916/8216-samsung-fortuna: Add samsung,fortuna binding
@ 2024-03-26 14:12 Raymond Hackley
2024-03-26 14:12 ` [PATCH 1/2] " Raymond Hackley
2024-03-26 14:12 ` [PATCH 2/2] dt-bindings: qcom: Document samsung,fortuna Raymond Hackley
0 siblings, 2 replies; 5+ messages in thread
From: Raymond Hackley @ 2024-03-26 14:12 UTC (permalink / raw)
To: linux-kernel
Cc: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Stephan Gerhold, Nikita Travkin, linux-arm-msm,
devicetree, ~postmarketos/upstreaming
Add common binding samsung,fortuna used by the following
Samsung Galaxy Grand Prime devices:
- SM-G530FZ (msm8916-samsung-grandprimelte)
- SM-G530H (msm8216-samsung-fortuna3g)
- SM-G530W (msm8916-gprimeltecan)
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH 1/2] arm64: dts: qcom: msm8916/8216-samsung-fortuna: Add samsung,fortuna binding
2024-03-26 14:12 [PATCH 0/2] arm64: dts: qcom: msm8916/8216-samsung-fortuna: Add samsung,fortuna binding Raymond Hackley
@ 2024-03-26 14:12 ` Raymond Hackley
2024-03-30 18:42 ` Krzysztof Kozlowski
2024-03-26 14:12 ` [PATCH 2/2] dt-bindings: qcom: Document samsung,fortuna Raymond Hackley
1 sibling, 1 reply; 5+ messages in thread
From: Raymond Hackley @ 2024-03-26 14:12 UTC (permalink / raw)
To: linux-kernel
Cc: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Stephan Gerhold, Nikita Travkin, linux-arm-msm,
devicetree, ~postmarketos/upstreaming
Add common binding samsung,fortuna used by the following
Samsung Galaxy Grand Prime devices:
- SM-G530FZ (msm8916-samsung-grandprimelte)
- SM-G530H (msm8216-samsung-fortuna3g)
- SM-G530W (msm8916-gprimeltecan)
Signed-off-by: Raymond Hackley <raymondhackley@protonmail.com>
---
arch/arm64/boot/dts/qcom/msm8216-samsung-fortuna3g.dts | 2 +-
arch/arm64/boot/dts/qcom/msm8916-samsung-gprimeltecan.dts | 2 +-
arch/arm64/boot/dts/qcom/msm8916-samsung-grandprimelte.dts | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/msm8216-samsung-fortuna3g.dts b/arch/arm64/boot/dts/qcom/msm8216-samsung-fortuna3g.dts
index 366914be7d53..877fd2d7bb57 100644
--- a/arch/arm64/boot/dts/qcom/msm8216-samsung-fortuna3g.dts
+++ b/arch/arm64/boot/dts/qcom/msm8216-samsung-fortuna3g.dts
@@ -6,6 +6,6 @@
/ {
model = "Samsung Galaxy Grand Prime (SM-G530H)";
- compatible = "samsung,fortuna3g", "qcom,msm8916";
+ compatible = "samsung,fortuna3g", "samsung,fortuna", "qcom,msm8916";
chassis-type = "handset";
};
diff --git a/arch/arm64/boot/dts/qcom/msm8916-samsung-gprimeltecan.dts b/arch/arm64/boot/dts/qcom/msm8916-samsung-gprimeltecan.dts
index 9d65fa58ba92..8c7d71e05da3 100644
--- a/arch/arm64/boot/dts/qcom/msm8916-samsung-gprimeltecan.dts
+++ b/arch/arm64/boot/dts/qcom/msm8916-samsung-gprimeltecan.dts
@@ -6,7 +6,7 @@
/ {
model = "Samsung Galaxy Grand Prime (SM-G530W)";
- compatible = "samsung,gprimeltecan", "qcom,msm8916";
+ compatible = "samsung,gprimeltecan", "samsung,fortuna", "qcom,msm8916";
chassis-type = "handset";
reserved-memory {
diff --git a/arch/arm64/boot/dts/qcom/msm8916-samsung-grandprimelte.dts b/arch/arm64/boot/dts/qcom/msm8916-samsung-grandprimelte.dts
index a66ce4b13547..1781e04a25c9 100644
--- a/arch/arm64/boot/dts/qcom/msm8916-samsung-grandprimelte.dts
+++ b/arch/arm64/boot/dts/qcom/msm8916-samsung-grandprimelte.dts
@@ -6,7 +6,7 @@
/ {
model = "Samsung Galaxy Grand Prime (SM-G530FZ)";
- compatible = "samsung,grandprimelte", "qcom,msm8916";
+ compatible = "samsung,grandprimelte", "samsung,fortuna", "qcom,msm8916";
chassis-type = "handset";
};
--
2.39.2
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH 2/2] dt-bindings: qcom: Document samsung,fortuna
2024-03-26 14:12 [PATCH 0/2] arm64: dts: qcom: msm8916/8216-samsung-fortuna: Add samsung,fortuna binding Raymond Hackley
2024-03-26 14:12 ` [PATCH 1/2] " Raymond Hackley
@ 2024-03-26 14:12 ` Raymond Hackley
2024-03-27 15:43 ` Rob Herring
1 sibling, 1 reply; 5+ messages in thread
From: Raymond Hackley @ 2024-03-26 14:12 UTC (permalink / raw)
To: linux-kernel
Cc: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Stephan Gerhold, Nikita Travkin, linux-arm-msm,
devicetree, ~postmarketos/upstreaming
Document common binding samsung,fortuna used by the following
Samsung Galaxy Grand Prime devices below:
- SM-G530FZ (msm8916-samsung-grandprimelte)
- SM-G530H (msm8216-samsung-fortuna3g)
- SM-G530W (msm8916-gprimeltecan)
Signed-off-by: Raymond Hackley <raymondhackley@protonmail.com>
---
Documentation/devicetree/bindings/arm/qcom.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
index 66beaac60e1d..2db776d78d22 100644
--- a/Documentation/devicetree/bindings/arm/qcom.yaml
+++ b/Documentation/devicetree/bindings/arm/qcom.yaml
@@ -204,6 +204,7 @@ properties:
- samsung,a5u-eur
- samsung,e5
- samsung,e7
+ - samsung,fortuna
- samsung,fortuna3g
- samsung,gprimeltecan
- samsung,grandmax
--
2.39.2
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 2/2] dt-bindings: qcom: Document samsung,fortuna
2024-03-26 14:12 ` [PATCH 2/2] dt-bindings: qcom: Document samsung,fortuna Raymond Hackley
@ 2024-03-27 15:43 ` Rob Herring
0 siblings, 0 replies; 5+ messages in thread
From: Rob Herring @ 2024-03-27 15:43 UTC (permalink / raw)
To: Raymond Hackley
Cc: linux-kernel, Bjorn Andersson, Konrad Dybcio, Krzysztof Kozlowski,
Conor Dooley, Stephan Gerhold, Nikita Travkin, linux-arm-msm,
devicetree, ~postmarketos/upstreaming
On Tue, Mar 26, 2024 at 02:12:58PM +0000, Raymond Hackley wrote:
> Document common binding samsung,fortuna used by the following
> Samsung Galaxy Grand Prime devices below:
> - SM-G530FZ (msm8916-samsung-grandprimelte)
> - SM-G530H (msm8216-samsung-fortuna3g)
> - SM-G530W (msm8916-gprimeltecan)
Commit messages should answer "why?". Why do you need this?
Please test this binding change against your dts changes. I think you
will find it fails.
>
> Signed-off-by: Raymond Hackley <raymondhackley@protonmail.com>
> ---
> Documentation/devicetree/bindings/arm/qcom.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
> index 66beaac60e1d..2db776d78d22 100644
> --- a/Documentation/devicetree/bindings/arm/qcom.yaml
> +++ b/Documentation/devicetree/bindings/arm/qcom.yaml
> @@ -204,6 +204,7 @@ properties:
> - samsung,a5u-eur
> - samsung,e5
> - samsung,e7
> + - samsung,fortuna
> - samsung,fortuna3g
> - samsung,gprimeltecan
> - samsung,grandmax
> --
> 2.39.2
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/2] arm64: dts: qcom: msm8916/8216-samsung-fortuna: Add samsung,fortuna binding
2024-03-26 14:12 ` [PATCH 1/2] " Raymond Hackley
@ 2024-03-30 18:42 ` Krzysztof Kozlowski
0 siblings, 0 replies; 5+ messages in thread
From: Krzysztof Kozlowski @ 2024-03-30 18:42 UTC (permalink / raw)
To: Raymond Hackley, linux-kernel
Cc: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Stephan Gerhold, Nikita Travkin, linux-arm-msm,
devicetree, ~postmarketos/upstreaming
On 26/03/2024 15:12, Raymond Hackley wrote:
> Add common binding samsung,fortuna used by the following
> Samsung Galaxy Grand Prime devices:
> - SM-G530FZ (msm8916-samsung-grandprimelte)
> - SM-G530H (msm8216-samsung-fortuna3g)
> - SM-G530W (msm8916-gprimeltecan)
>
> Signed-off-by: Raymond Hackley <raymondhackley@protonmail.com>
> ---
> arch/arm64/boot/dts/qcom/msm8216-samsung-fortuna3g.dts | 2 +-
> arch/arm64/boot/dts/qcom/msm8916-samsung-gprimeltecan.dts | 2 +-
> arch/arm64/boot/dts/qcom/msm8916-samsung-grandprimelte.dts | 2 +-
> 3 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/msm8216-samsung-fortuna3g.dts b/arch/arm64/boot/dts/qcom/msm8216-samsung-fortuna3g.dts
> index 366914be7d53..877fd2d7bb57 100644
> --- a/arch/arm64/boot/dts/qcom/msm8216-samsung-fortuna3g.dts
> +++ b/arch/arm64/boot/dts/qcom/msm8216-samsung-fortuna3g.dts
> @@ -6,6 +6,6 @@
>
> / {
> model = "Samsung Galaxy Grand Prime (SM-G530H)";
> - compatible = "samsung,fortuna3g", "qcom,msm8916";
> + compatible = "samsung,fortuna3g", "samsung,fortuna", "qcom,msm8916";
It does not look like you tested the DTS against bindings. Please run
`make dtbs_check W=1` (see
Documentation/devicetree/bindings/writing-schema.rst or
https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/
for instructions).
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2024-03-30 18:42 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-03-26 14:12 [PATCH 0/2] arm64: dts: qcom: msm8916/8216-samsung-fortuna: Add samsung,fortuna binding Raymond Hackley
2024-03-26 14:12 ` [PATCH 1/2] " Raymond Hackley
2024-03-30 18:42 ` Krzysztof Kozlowski
2024-03-26 14:12 ` [PATCH 2/2] dt-bindings: qcom: Document samsung,fortuna Raymond Hackley
2024-03-27 15:43 ` Rob Herring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).