From: Lothar Rubusch <l.rubusch@gmail.com>
To: lars@metafoo.de, Michael.Hennerich@analog.com, jic23@kernel.org,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
conor+dt@kernel.org
Cc: linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, eraretuya@gmail.com,
l.rubusch@gmail.com
Subject: [PATCH v5 2/7] iio: accel: adxl345: Group bus configuration
Date: Wed, 27 Mar 2024 22:03:15 +0000 [thread overview]
Message-ID: <20240327220320.15509-3-l.rubusch@gmail.com> (raw)
In-Reply-To: <20240327220320.15509-1-l.rubusch@gmail.com>
In the probe function group bus configuration and the indio_dev
initialization to improve readability.
Signed-off-by: Lothar Rubusch <l.rubusch@gmail.com>
---
drivers/iio/accel/adxl345_core.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/iio/accel/adxl345_core.c b/drivers/iio/accel/adxl345_core.c
index 35df5e372..5c24ef9ca 100644
--- a/drivers/iio/accel/adxl345_core.c
+++ b/drivers/iio/accel/adxl345_core.c
@@ -229,18 +229,18 @@ int adxl345_core_probe(struct device *dev, struct regmap *regmap)
if (!data->info)
return -ENODEV;
- /* Enable full-resolution mode */
- ret = regmap_update_bits(regmap, ADXL345_REG_DATA_FORMAT,
- ADXL345_DATA_FORMAT_MSK, ADXL345_DATA_FORMAT_FULL_RES);
- if (ret)
- return dev_err_probe(dev, ret, "Failed to set data range\n");
-
indio_dev->name = data->info->name;
indio_dev->info = &adxl345_info;
indio_dev->modes = INDIO_DIRECT_MODE;
indio_dev->channels = adxl345_channels;
indio_dev->num_channels = ARRAY_SIZE(adxl345_channels);
+ /* Enable full-resolution mode */
+ ret = regmap_update_bits(regmap, ADXL345_REG_DATA_FORMAT,
+ ADXL345_DATA_FORMAT_MSK, ADXL345_DATA_FORMAT_FULL_RES);
+ if (ret)
+ return dev_err_probe(dev, ret, "Failed to set data range\n");
+
/* Enable measurement mode */
ret = adxl345_powerup(data->regmap);
if (ret < 0)
--
2.25.1
next prev parent reply other threads:[~2024-03-27 22:03 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-27 22:03 [PATCH v5 0/7] iio: accel: adxl345: Add spi-3wire feature Lothar Rubusch
2024-03-27 22:03 ` [PATCH v5 1/7] iio: accel: adxl345: Make data_range obsolete Lothar Rubusch
2024-03-28 13:37 ` Jonathan Cameron
2024-03-29 0:03 ` Lothar Rubusch
2024-03-30 15:18 ` Jonathan Cameron
2024-03-27 22:03 ` Lothar Rubusch [this message]
2024-03-27 22:03 ` [PATCH v5 3/7] iio: accel: adxl345: Move defines to header Lothar Rubusch
2024-03-27 22:03 ` [PATCH v5 4/7] dt-bindings: iio: accel: adxl345: Add spi-3wire Lothar Rubusch
2024-03-28 9:22 ` Krzysztof Kozlowski
2024-03-28 9:57 ` Lothar Rubusch
2024-03-28 10:20 ` Lothar Rubusch
2024-03-27 22:03 ` [PATCH v5 5/7] iio: accel: adxl345: Pass function pointer to core Lothar Rubusch
2024-03-27 22:03 ` [PATCH v5 6/7] iio: accel: adxl345: Add comment to probe Lothar Rubusch
2024-03-27 22:03 ` [PATCH v5 7/7] iio: accel: adxl345: Add spi-3wire option Lothar Rubusch
2024-03-28 13:39 ` Jonathan Cameron
2024-03-29 0:33 ` Lothar Rubusch
2024-03-30 15:24 ` Jonathan Cameron
2024-04-01 16:06 ` Lothar Rubusch
2024-04-01 16:53 ` Jonathan Cameron
2024-04-02 10:11 ` Lothar Rubusch
2024-04-06 10:15 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240327220320.15509-3-l.rubusch@gmail.com \
--to=l.rubusch@gmail.com \
--cc=Michael.Hennerich@analog.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=eraretuya@gmail.com \
--cc=jic23@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).