* [PATCH 0/2] iio: imu: inv_icm42600: add support of ICM-42688-P @ 2024-03-29 15:15 inv.git-commit 2024-03-29 15:15 ` [PATCH 1/2] " inv.git-commit 2024-03-29 15:15 ` [PATCH 2/2] dt-bindings: iio: imu: add icm42688 inside inv_icm42600 inv.git-commit 0 siblings, 2 replies; 7+ messages in thread From: inv.git-commit @ 2024-03-29 15:15 UTC (permalink / raw) To: jic23, robh, krzysztof.kozlowski+dt, conor+dt Cc: lars, linux-iio, devicetree, Jean-Baptiste Maneyrol From: Jean-Baptiste Maneyrol <jean-baptiste.maneyrol@tdk.com> This series is for adding support of high-end specs ICM-42688-P chip. Jean-Baptiste Maneyrol (2): iio: imu: inv_icm42600: add support of ICM-42688-P dt-bindings: iio: imu: add icm42688 inside inv_icm42600 .../devicetree/bindings/iio/imu/invensense,icm42600.yaml | 1 + drivers/iio/imu/inv_icm42600/inv_icm42600.h | 2 ++ drivers/iio/imu/inv_icm42600/inv_icm42600_core.c | 5 +++++ drivers/iio/imu/inv_icm42600/inv_icm42600_i2c.c | 3 +++ drivers/iio/imu/inv_icm42600/inv_icm42600_spi.c | 3 +++ 5 files changed, 14 insertions(+) -- 2.34.1 ^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 1/2] iio: imu: inv_icm42600: add support of ICM-42688-P 2024-03-29 15:15 [PATCH 0/2] iio: imu: inv_icm42600: add support of ICM-42688-P inv.git-commit @ 2024-03-29 15:15 ` inv.git-commit 2024-03-29 15:15 ` [PATCH 2/2] dt-bindings: iio: imu: add icm42688 inside inv_icm42600 inv.git-commit 1 sibling, 0 replies; 7+ messages in thread From: inv.git-commit @ 2024-03-29 15:15 UTC (permalink / raw) To: jic23, robh, krzysztof.kozlowski+dt, conor+dt Cc: lars, linux-iio, devicetree, Jean-Baptiste Maneyrol From: Jean-Baptiste Maneyrol <jean-baptiste.maneyrol@tdk.com> Signed-off-by: Jean-Baptiste Maneyrol <jean-baptiste.maneyrol@tdk.com> --- drivers/iio/imu/inv_icm42600/inv_icm42600.h | 2 ++ drivers/iio/imu/inv_icm42600/inv_icm42600_core.c | 5 +++++ drivers/iio/imu/inv_icm42600/inv_icm42600_i2c.c | 3 +++ drivers/iio/imu/inv_icm42600/inv_icm42600_spi.c | 3 +++ 4 files changed, 13 insertions(+) diff --git a/drivers/iio/imu/inv_icm42600/inv_icm42600.h b/drivers/iio/imu/inv_icm42600/inv_icm42600.h index 0e290c807b0f..0566340b2660 100644 --- a/drivers/iio/imu/inv_icm42600/inv_icm42600.h +++ b/drivers/iio/imu/inv_icm42600/inv_icm42600.h @@ -22,6 +22,7 @@ enum inv_icm42600_chip { INV_CHIP_ICM42602, INV_CHIP_ICM42605, INV_CHIP_ICM42622, + INV_CHIP_ICM42688, INV_CHIP_ICM42631, INV_CHIP_NB, }; @@ -304,6 +305,7 @@ struct inv_icm42600_state { #define INV_ICM42600_WHOAMI_ICM42602 0x41 #define INV_ICM42600_WHOAMI_ICM42605 0x42 #define INV_ICM42600_WHOAMI_ICM42622 0x46 +#define INV_ICM42600_WHOAMI_ICM42688 0x47 #define INV_ICM42600_WHOAMI_ICM42631 0x5C /* User bank 1 (MSB 0x10) */ diff --git a/drivers/iio/imu/inv_icm42600/inv_icm42600_core.c b/drivers/iio/imu/inv_icm42600/inv_icm42600_core.c index a5e81906e37e..82e0a2e2ad70 100644 --- a/drivers/iio/imu/inv_icm42600/inv_icm42600_core.c +++ b/drivers/iio/imu/inv_icm42600/inv_icm42600_core.c @@ -87,6 +87,11 @@ static const struct inv_icm42600_hw inv_icm42600_hw[INV_CHIP_NB] = { .name = "icm42622", .conf = &inv_icm42600_default_conf, }, + [INV_CHIP_ICM42688] = { + .whoami = INV_ICM42600_WHOAMI_ICM42688, + .name = "icm42688", + .conf = &inv_icm42600_default_conf, + }, [INV_CHIP_ICM42631] = { .whoami = INV_ICM42600_WHOAMI_ICM42631, .name = "icm42631", diff --git a/drivers/iio/imu/inv_icm42600/inv_icm42600_i2c.c b/drivers/iio/imu/inv_icm42600/inv_icm42600_i2c.c index 1af559403ba6..ebb28f84ba98 100644 --- a/drivers/iio/imu/inv_icm42600/inv_icm42600_i2c.c +++ b/drivers/iio/imu/inv_icm42600/inv_icm42600_i2c.c @@ -84,6 +84,9 @@ static const struct of_device_id inv_icm42600_of_matches[] = { }, { .compatible = "invensense,icm42622", .data = (void *)INV_CHIP_ICM42622, + }, { + .compatible = "invensense,icm42688", + .data = (void *)INV_CHIP_ICM42688, }, { .compatible = "invensense,icm42631", .data = (void *)INV_CHIP_ICM42631, diff --git a/drivers/iio/imu/inv_icm42600/inv_icm42600_spi.c b/drivers/iio/imu/inv_icm42600/inv_icm42600_spi.c index 6be4ac794937..50217a10e0bb 100644 --- a/drivers/iio/imu/inv_icm42600/inv_icm42600_spi.c +++ b/drivers/iio/imu/inv_icm42600/inv_icm42600_spi.c @@ -80,6 +80,9 @@ static const struct of_device_id inv_icm42600_of_matches[] = { }, { .compatible = "invensense,icm42622", .data = (void *)INV_CHIP_ICM42622, + }, { + .compatible = "invensense,icm42688", + .data = (void *)INV_CHIP_ICM42688, }, { .compatible = "invensense,icm42631", .data = (void *)INV_CHIP_ICM42631, -- 2.34.1 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH 2/2] dt-bindings: iio: imu: add icm42688 inside inv_icm42600 2024-03-29 15:15 [PATCH 0/2] iio: imu: inv_icm42600: add support of ICM-42688-P inv.git-commit 2024-03-29 15:15 ` [PATCH 1/2] " inv.git-commit @ 2024-03-29 15:15 ` inv.git-commit 2024-03-29 15:49 ` Conor Dooley 1 sibling, 1 reply; 7+ messages in thread From: inv.git-commit @ 2024-03-29 15:15 UTC (permalink / raw) To: jic23, robh, krzysztof.kozlowski+dt, conor+dt Cc: lars, linux-iio, devicetree, Jean-Baptiste Maneyrol From: Jean-Baptiste Maneyrol <jean-baptiste.maneyrol@tdk.com> Add bindings for ICM-42688-P chip. Signed-off-by: Jean-Baptiste Maneyrol <jean-baptiste.maneyrol@tdk.com> --- .../devicetree/bindings/iio/imu/invensense,icm42600.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/iio/imu/invensense,icm42600.yaml b/Documentation/devicetree/bindings/iio/imu/invensense,icm42600.yaml index 7cd05bcbee31..152aec8d82ff 100644 --- a/Documentation/devicetree/bindings/iio/imu/invensense,icm42600.yaml +++ b/Documentation/devicetree/bindings/iio/imu/invensense,icm42600.yaml @@ -31,6 +31,7 @@ properties: - invensense,icm42602 - invensense,icm42605 - invensense,icm42622 + - invensense,icm42688 - invensense,icm42631 reg: -- 2.34.1 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH 2/2] dt-bindings: iio: imu: add icm42688 inside inv_icm42600 2024-03-29 15:15 ` [PATCH 2/2] dt-bindings: iio: imu: add icm42688 inside inv_icm42600 inv.git-commit @ 2024-03-29 15:49 ` Conor Dooley 2024-03-30 16:10 ` Jonathan Cameron 0 siblings, 1 reply; 7+ messages in thread From: Conor Dooley @ 2024-03-29 15:49 UTC (permalink / raw) To: inv.git-commit Cc: jic23, robh, krzysztof.kozlowski+dt, conor+dt, lars, linux-iio, devicetree, Jean-Baptiste Maneyrol [-- Attachment #1: Type: text/plain, Size: 1232 bytes --] On Fri, Mar 29, 2024 at 03:15:35PM +0000, inv.git-commit@tdk.com wrote: > From: Jean-Baptiste Maneyrol <jean-baptiste.maneyrol@tdk.com> > > Add bindings for ICM-42688-P chip. > > Signed-off-by: Jean-Baptiste Maneyrol <jean-baptiste.maneyrol@tdk.com> My initial thought was that you're missing a sign-off, but is "inv.git-commit@tdk.com" some system you have to bypass corporate email garbage? > --- > .../devicetree/bindings/iio/imu/invensense,icm42600.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/iio/imu/invensense,icm42600.yaml b/Documentation/devicetree/bindings/iio/imu/invensense,icm42600.yaml > index 7cd05bcbee31..152aec8d82ff 100644 > --- a/Documentation/devicetree/bindings/iio/imu/invensense,icm42600.yaml > +++ b/Documentation/devicetree/bindings/iio/imu/invensense,icm42600.yaml > @@ -31,6 +31,7 @@ properties: > - invensense,icm42602 > - invensense,icm42605 > - invensense,icm42622 > + - invensense,icm42688 Can you add this in alphanumerical order please? Also, this patch should be the first in the series. Thanks, Conor. > - invensense,icm42631 > > reg: > -- > 2.34.1 > [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 228 bytes --] ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 2/2] dt-bindings: iio: imu: add icm42688 inside inv_icm42600 2024-03-29 15:49 ` Conor Dooley @ 2024-03-30 16:10 ` Jonathan Cameron 2024-04-01 11:04 ` Conor Dooley 0 siblings, 1 reply; 7+ messages in thread From: Jonathan Cameron @ 2024-03-30 16:10 UTC (permalink / raw) To: Conor Dooley Cc: inv.git-commit, robh, krzysztof.kozlowski+dt, conor+dt, lars, linux-iio, devicetree, Jean-Baptiste Maneyrol On Fri, 29 Mar 2024 15:49:26 +0000 Conor Dooley <conor@kernel.org> wrote: > On Fri, Mar 29, 2024 at 03:15:35PM +0000, inv.git-commit@tdk.com wrote: > > From: Jean-Baptiste Maneyrol <jean-baptiste.maneyrol@tdk.com> > > > > Add bindings for ICM-42688-P chip. > > > > Signed-off-by: Jean-Baptiste Maneyrol <jean-baptiste.maneyrol@tdk.com> > > My initial thought was that you're missing a sign-off, but is > "inv.git-commit@tdk.com" some system you have to bypass corporate email > garbage? Common enough setup, as long as the From: line matches the sign-off, git will ignore the email address used to send it when the patch is applied. > > > --- > > .../devicetree/bindings/iio/imu/invensense,icm42600.yaml | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/Documentation/devicetree/bindings/iio/imu/invensense,icm42600.yaml b/Documentation/devicetree/bindings/iio/imu/invensense,icm42600.yaml > > index 7cd05bcbee31..152aec8d82ff 100644 > > --- a/Documentation/devicetree/bindings/iio/imu/invensense,icm42600.yaml > > +++ b/Documentation/devicetree/bindings/iio/imu/invensense,icm42600.yaml > > @@ -31,6 +31,7 @@ properties: > > - invensense,icm42602 > > - invensense,icm42605 > > - invensense,icm42622 > > + - invensense,icm42688 > > Can you add this in alphanumerical order please? > > Also, this patch should be the first in the series. Agreed on both, otherwise this series LGTM Jonathan > > Thanks, > Conor. > > > - invensense,icm42631 > > > > reg: > > -- > > 2.34.1 > > ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 2/2] dt-bindings: iio: imu: add icm42688 inside inv_icm42600 2024-03-30 16:10 ` Jonathan Cameron @ 2024-04-01 11:04 ` Conor Dooley 2024-04-01 16:57 ` Jonathan Cameron 0 siblings, 1 reply; 7+ messages in thread From: Conor Dooley @ 2024-04-01 11:04 UTC (permalink / raw) To: Jonathan Cameron Cc: inv.git-commit, robh, krzysztof.kozlowski+dt, conor+dt, lars, linux-iio, devicetree, Jean-Baptiste Maneyrol [-- Attachment #1: Type: text/plain, Size: 1234 bytes --] On Sat, Mar 30, 2024 at 04:10:12PM +0000, Jonathan Cameron wrote: > On Fri, 29 Mar 2024 15:49:26 +0000 > Conor Dooley <conor@kernel.org> wrote: > > > On Fri, Mar 29, 2024 at 03:15:35PM +0000, inv.git-commit@tdk.com wrote: > > > From: Jean-Baptiste Maneyrol <jean-baptiste.maneyrol@tdk.com> > > > > > > Add bindings for ICM-42688-P chip. > > > > > > Signed-off-by: Jean-Baptiste Maneyrol <jean-baptiste.maneyrol@tdk.com> > > > > My initial thought was that you're missing a sign-off, but is > > "inv.git-commit@tdk.com" some system you have to bypass corporate email > > garbage? > > Common enough setup, as long as the From: line matches the sign-off, git will > ignore the email address used to send it when the patch is applied. Yeah, I know how it works, I do it all the time. Even found, or rather caused, a b4 bug where it would use the sending email in the eventual commit rather than the author: https://lore.kernel.org/tools/20230310192652.ymac3w2lucfdf34p@meerkat.local/ I'm just double checking that there's not a missing signoff. When I've seen these corp-email-bypass accounts before people set a proper "from" in git send-email so there's a name in it: "A Dev <inv.git-commit@tdk.com>" [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 228 bytes --] ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 2/2] dt-bindings: iio: imu: add icm42688 inside inv_icm42600 2024-04-01 11:04 ` Conor Dooley @ 2024-04-01 16:57 ` Jonathan Cameron 0 siblings, 0 replies; 7+ messages in thread From: Jonathan Cameron @ 2024-04-01 16:57 UTC (permalink / raw) To: Conor Dooley Cc: Jonathan Cameron, inv.git-commit, robh, krzysztof.kozlowski+dt, conor+dt, lars, linux-iio, devicetree, Jean-Baptiste Maneyrol On Mon, 1 Apr 2024 12:04:55 +0100 Conor Dooley <conor@kernel.org> wrote: > On Sat, Mar 30, 2024 at 04:10:12PM +0000, Jonathan Cameron wrote: > > On Fri, 29 Mar 2024 15:49:26 +0000 > > Conor Dooley <conor@kernel.org> wrote: > > > > > On Fri, Mar 29, 2024 at 03:15:35PM +0000, inv.git-commit@tdk.com wrote: > > > > From: Jean-Baptiste Maneyrol <jean-baptiste.maneyrol@tdk.com> > > > > > > > > Add bindings for ICM-42688-P chip. > > > > > > > > Signed-off-by: Jean-Baptiste Maneyrol <jean-baptiste.maneyrol@tdk.com> > > > > > > My initial thought was that you're missing a sign-off, but is > > > "inv.git-commit@tdk.com" some system you have to bypass corporate email > > > garbage? > > > > Common enough setup, as long as the From: line matches the sign-off, git will > > ignore the email address used to send it when the patch is applied. > > Yeah, I know how it works, I do it all the time. Even found, or rather > caused, a b4 bug where it would use the sending email in the eventual > commit rather than the author: > https://lore.kernel.org/tools/20230310192652.ymac3w2lucfdf34p@meerkat.local/ > > I'm just double checking that there's not a missing signoff. When I've > seen these corp-email-bypass accounts before people set a proper "from" > in git send-email so there's a name in it: "A Dev <inv.git-commit@tdk.com>" > Ah. Got it now :) I guess it depends on how their weird setup wires everything up! Jonathan ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2024-04-01 16:57 UTC | newest] Thread overview: 7+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2024-03-29 15:15 [PATCH 0/2] iio: imu: inv_icm42600: add support of ICM-42688-P inv.git-commit 2024-03-29 15:15 ` [PATCH 1/2] " inv.git-commit 2024-03-29 15:15 ` [PATCH 2/2] dt-bindings: iio: imu: add icm42688 inside inv_icm42600 inv.git-commit 2024-03-29 15:49 ` Conor Dooley 2024-03-30 16:10 ` Jonathan Cameron 2024-04-01 11:04 ` Conor Dooley 2024-04-01 16:57 ` Jonathan Cameron
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).