From: Krzysztof Kozlowski <krzk@kernel.org>
To: Conor Dooley <conor@kernel.org>,
Nicolas Ferre <nicolas.ferre@microchip.com>,
Claudiu Beznea <claudiu.beznea@tuxon.dev>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Lars Povlsen <lars.povlsen@microchip.com>,
Steen Hegelund <Steen.Hegelund@microchip.com>,
Daniel Machon <daniel.machon@microchip.com>,
UNGLinuxDriver@microchip.com,
"David S. Miller" <davem@davemloft.net>,
Bjarni Jonasson <bjarni.jonasson@microchip.com>,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: Krzysztof Kozlowski <krzk@kernel.org>
Subject: [PATCH RFT 09/10] arm64: dts: microchip: sparx5_pcb134: drop duplicated NOR flash
Date: Mon, 1 Apr 2024 17:37:39 +0200 [thread overview]
Message-ID: <20240401153740.123978-9-krzk@kernel.org> (raw)
In-Reply-To: <20240401153740.123978-1-krzk@kernel.org>
Since beginning the DTS extended the SPI0 in two places adding two SPI
muxes, each with same SPI NOR flash. Both used exactly the same
chip-selects, so this was clearly buggy code. Without checking in
datasheet, assume device has only one SPI NOR flash, so code was
duplicated.
Fixes dtc W=1 warnings:
sparx5_pcb134_board.dtsi:277.10-281.4: Warning (unique_unit_address_if_enabled): /axi@600000000/spi@600104000/flash@0: duplicate unit-address (also used in node /axi@600000000/spi@600104000/spi@0)
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
Not tested on hardware
---
.../boot/dts/microchip/sparx5_pcb134_board.dtsi | 16 ----------------
1 file changed, 16 deletions(-)
diff --git a/arch/arm64/boot/dts/microchip/sparx5_pcb134_board.dtsi b/arch/arm64/boot/dts/microchip/sparx5_pcb134_board.dtsi
index f165a409bc1d..dc7b59dfcb40 100644
--- a/arch/arm64/boot/dts/microchip/sparx5_pcb134_board.dtsi
+++ b/arch/arm64/boot/dts/microchip/sparx5_pcb134_board.dtsi
@@ -281,22 +281,6 @@ flash@0 {
};
};
-&spi0 {
- status = "okay";
- spi@0 {
- compatible = "spi-mux";
- mux-controls = <&mux>;
- #address-cells = <1>;
- #size-cells = <0>;
- reg = <0>; /* CS0 */
- flash@9 {
- compatible = "jedec,spi-nor";
- spi-max-frequency = <8000000>;
- reg = <0x9>; /* SPI */
- };
- };
-};
-
&sgpio0 {
status = "okay";
microchip,sgpio-port-ranges = <8 15>;
--
2.34.1
next prev parent reply other threads:[~2024-04-01 15:38 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-01 15:37 [PATCH RFT 01/10] arm64: dts: microchip: sparx5: fix mdio reg Krzysztof Kozlowski
2024-04-01 15:37 ` [PATCH 02/10] arm64: dts: microchip: sparx5: correct serdes unit address Krzysztof Kozlowski
2024-04-01 15:37 ` [PATCH 03/10] arm64: dts: microchip: sparx5_pcb134: add missing I2C mux unit addresses Krzysztof Kozlowski
2024-04-01 15:37 ` [PATCH 04/10] arm64: dts: microchip: sparx5_pcb135: " Krzysztof Kozlowski
2024-04-01 15:37 ` [PATCH 05/10] arm64: dts: microchip: sparx5_pcb134: align I2C mux node name with bindings Krzysztof Kozlowski
2024-04-01 15:37 ` [PATCH 06/10] arm64: dts: microchip: sparx5_pcb135: " Krzysztof Kozlowski
2024-04-01 15:37 ` [PATCH 07/10] arm64: dts: microchip: sparx5_pcb134: drop LED unit addresses Krzysztof Kozlowski
2024-04-01 15:37 ` [PATCH 08/10] arm64: dts: microchip: sparx5_pcb135: " Krzysztof Kozlowski
2024-04-01 15:37 ` Krzysztof Kozlowski [this message]
2024-04-05 12:10 ` [PATCH RFT 09/10] arm64: dts: microchip: sparx5_pcb134: drop duplicated NOR flash Steen Hegelund
2024-04-05 15:45 ` Krzysztof Kozlowski
2024-04-01 15:37 ` [PATCH RFT 10/10] arm64: dts: microchip: sparx5_pcb135: " Krzysztof Kozlowski
2024-04-05 12:11 ` Steen Hegelund
2024-04-05 15:46 ` Krzysztof Kozlowski
2024-04-02 6:26 ` [PATCH RFT 01/10] arm64: dts: microchip: sparx5: fix mdio reg Horatiu Vultur
2024-04-02 14:00 ` Steen Hegelund
2024-04-02 17:46 ` Conor Dooley
2024-04-03 13:03 ` Steen Hegelund
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240401153740.123978-9-krzk@kernel.org \
--to=krzk@kernel.org \
--cc=Steen.Hegelund@microchip.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=bjarni.jonasson@microchip.com \
--cc=claudiu.beznea@tuxon.dev \
--cc=conor@kernel.org \
--cc=daniel.machon@microchip.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lars.povlsen@microchip.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nicolas.ferre@microchip.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).