From: Jonathan Cameron <Jonathan.Cameron@Huawei.com>
To: Conor Dooley <conor@kernel.org>
Cc: Jonathan Cameron <jic23@kernel.org>, <inv.git-commit@tdk.com>,
<robh@kernel.org>, <krzysztof.kozlowski+dt@linaro.org>,
<conor+dt@kernel.org>, <lars@metafoo.de>,
<linux-iio@vger.kernel.org>, <devicetree@vger.kernel.org>,
Jean-Baptiste Maneyrol <jean-baptiste.maneyrol@tdk.com>
Subject: Re: [PATCH 2/2] dt-bindings: iio: imu: add icm42688 inside inv_icm42600
Date: Mon, 1 Apr 2024 17:57:15 +0100 [thread overview]
Message-ID: <20240401175715.000049de@Huawei.com> (raw)
In-Reply-To: <20240401-marshy-derby-e22a469dd555@spud>
On Mon, 1 Apr 2024 12:04:55 +0100
Conor Dooley <conor@kernel.org> wrote:
> On Sat, Mar 30, 2024 at 04:10:12PM +0000, Jonathan Cameron wrote:
> > On Fri, 29 Mar 2024 15:49:26 +0000
> > Conor Dooley <conor@kernel.org> wrote:
> >
> > > On Fri, Mar 29, 2024 at 03:15:35PM +0000, inv.git-commit@tdk.com wrote:
> > > > From: Jean-Baptiste Maneyrol <jean-baptiste.maneyrol@tdk.com>
> > > >
> > > > Add bindings for ICM-42688-P chip.
> > > >
> > > > Signed-off-by: Jean-Baptiste Maneyrol <jean-baptiste.maneyrol@tdk.com>
> > >
> > > My initial thought was that you're missing a sign-off, but is
> > > "inv.git-commit@tdk.com" some system you have to bypass corporate email
> > > garbage?
> >
> > Common enough setup, as long as the From: line matches the sign-off, git will
> > ignore the email address used to send it when the patch is applied.
>
> Yeah, I know how it works, I do it all the time. Even found, or rather
> caused, a b4 bug where it would use the sending email in the eventual
> commit rather than the author:
> https://lore.kernel.org/tools/20230310192652.ymac3w2lucfdf34p@meerkat.local/
>
> I'm just double checking that there's not a missing signoff. When I've
> seen these corp-email-bypass accounts before people set a proper "from"
> in git send-email so there's a name in it: "A Dev <inv.git-commit@tdk.com>"
>
Ah. Got it now :)
I guess it depends on how their weird setup wires everything up!
Jonathan
prev parent reply other threads:[~2024-04-01 16:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-29 15:15 [PATCH 0/2] iio: imu: inv_icm42600: add support of ICM-42688-P inv.git-commit
2024-03-29 15:15 ` [PATCH 1/2] " inv.git-commit
2024-03-29 15:15 ` [PATCH 2/2] dt-bindings: iio: imu: add icm42688 inside inv_icm42600 inv.git-commit
2024-03-29 15:49 ` Conor Dooley
2024-03-30 16:10 ` Jonathan Cameron
2024-04-01 11:04 ` Conor Dooley
2024-04-01 16:57 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240401175715.000049de@Huawei.com \
--to=jonathan.cameron@huawei.com \
--cc=conor+dt@kernel.org \
--cc=conor@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=inv.git-commit@tdk.com \
--cc=jean-baptiste.maneyrol@tdk.com \
--cc=jic23@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).