Re: [PATCH v6 10/11] riscv: dts: add initial canmv-k230 and k230-evb dts

Conor Dooley
2025-12-26T15:30:39Z

[-- Attachment #1: Type: text/plain, Size: 1016 bytes --]

On Thu, Dec 25, 2025 at 03:11:27PM +0800, Jiayu Du wrote:
> On Sat, Mar 23, 2024 at 08:12:22PM +0800, Yangyu Chen wrote:
> ...
> > diff --git a/arch/riscv/boot/dts/canaan/k230.dtsi b/arch/riscv/boot/dts/canaan/k230.dtsi
> ...
> > +
> > + aliases {
> > + serial0 = &uart0;
> > + };
>
> The aliases should be set in the board-level dts file,
> so please consider removing the aliases.
>
> ...
> > +
> > + plic: interrupt-controller@f00000000 {
> > + compatible = "canaan,k230-plic" ,"thead,c900-plic";
> Incorrect comma separation. It should be: "canaan,k230-plic", "thead,c900-plic";

If you send a follow-up patch, I'll squash it into my current k230
branch:
https://git.kernel.org/pub/scm/linux/kernel/git/conor/linux.git/log/?h=k230-basic

> > + reg = <0xf 0x00000000 0x0 0x04000000>;
> > + interrupts-extended = <&cpu0_intc 11>, <&cpu0_intc 9>;
> > + interrupt-controller;
> > + #address-cells = <0>;
> > + #interrupt-cells = <2>;
> ...
> > --
> > 2.43.0
> >
>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]