devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 1/2] arm64: dts: apm: storm: move non-MMIO node out of soc
@ 2024-04-02 20:08 Krzysztof Kozlowski
  2024-04-02 20:08 ` [PATCH 2/2] arm64: dts: apm: shadowcat: " Krzysztof Kozlowski
  2024-04-24  6:54 ` [PATCH 1/2] arm64: dts: apm: storm: " Krzysztof Kozlowski
  0 siblings, 2 replies; 3+ messages in thread
From: Krzysztof Kozlowski @ 2024-04-02 20:08 UTC (permalink / raw)
  To: Khuong Dinh, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	devicetree, linux-kernel
  Cc: Krzysztof Kozlowski

Non-MMIO devices, like fixed-clocks, should not be within simple-bus.

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
 arch/arm64/boot/dts/apm/apm-storm.dtsi | 13 +++++++------
 1 file changed, 7 insertions(+), 6 deletions(-)

diff --git a/arch/arm64/boot/dts/apm/apm-storm.dtsi b/arch/arm64/boot/dts/apm/apm-storm.dtsi
index 988928c60f15..633d8418f7cc 100644
--- a/arch/arm64/boot/dts/apm/apm-storm.dtsi
+++ b/arch/arm64/boot/dts/apm/apm-storm.dtsi
@@ -112,6 +112,13 @@ gic: interrupt-controller@78010000 {
 		interrupts = <1 9 0xf04>;	/* GIC Maintenence IRQ */
 	};
 
+	refclk: refclk {
+		compatible = "fixed-clock";
+		#clock-cells = <1>;
+		clock-frequency = <100000000>;
+		clock-output-names = "refclk";
+	};
+
 	timer {
 		compatible = "arm,armv8-timer";
 		interrupts = <1 0 0xff08>,	/* Secure Phys IRQ */
@@ -137,12 +144,6 @@ clocks {
 			#address-cells = <2>;
 			#size-cells = <2>;
 			ranges;
-			refclk: refclk {
-				compatible = "fixed-clock";
-				#clock-cells = <1>;
-				clock-frequency = <100000000>;
-				clock-output-names = "refclk";
-			};
 
 			pcppll: pcppll@17000100 {
 				compatible = "apm,xgene-pcppll-clock";
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [PATCH 2/2] arm64: dts: apm: shadowcat: move non-MMIO node out of soc
  2024-04-02 20:08 [PATCH 1/2] arm64: dts: apm: storm: move non-MMIO node out of soc Krzysztof Kozlowski
@ 2024-04-02 20:08 ` Krzysztof Kozlowski
  2024-04-24  6:54 ` [PATCH 1/2] arm64: dts: apm: storm: " Krzysztof Kozlowski
  1 sibling, 0 replies; 3+ messages in thread
From: Krzysztof Kozlowski @ 2024-04-02 20:08 UTC (permalink / raw)
  To: Khuong Dinh, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	devicetree, linux-kernel
  Cc: Krzysztof Kozlowski

Non-MMIO devices, like fixed-clocks, should not be within simple-bus.

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
 arch/arm64/boot/dts/apm/apm-shadowcat.dtsi | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/arch/arm64/boot/dts/apm/apm-shadowcat.dtsi b/arch/arm64/boot/dts/apm/apm-shadowcat.dtsi
index 65ebac3082e2..ea5721ea02f0 100644
--- a/arch/arm64/boot/dts/apm/apm-shadowcat.dtsi
+++ b/arch/arm64/boot/dts/apm/apm-shadowcat.dtsi
@@ -211,6 +211,13 @@ v2m15: v2m@f0000 {
 		};
 	};
 
+	refclk: refclk {
+		compatible = "fixed-clock";
+		#clock-cells = <1>;
+		clock-frequency = <100000000>;
+		clock-output-names = "refclk";
+	};
+
 	pmu {
 		compatible = "arm,armv8-pmuv3";
 		interrupts = <1 12 0xff04>;
@@ -236,13 +243,6 @@ clocks {
 			#size-cells = <2>;
 			ranges;
 
-			refclk: refclk {
-				compatible = "fixed-clock";
-				#clock-cells = <1>;
-				clock-frequency = <100000000>;
-				clock-output-names = "refclk";
-			};
-
 			pmdpll: pmdpll@170000f0 {
 				compatible = "apm,xgene-pcppll-v2-clock";
 				#clock-cells = <1>;
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH 1/2] arm64: dts: apm: storm: move non-MMIO node out of soc
  2024-04-02 20:08 [PATCH 1/2] arm64: dts: apm: storm: move non-MMIO node out of soc Krzysztof Kozlowski
  2024-04-02 20:08 ` [PATCH 2/2] arm64: dts: apm: shadowcat: " Krzysztof Kozlowski
@ 2024-04-24  6:54 ` Krzysztof Kozlowski
  1 sibling, 0 replies; 3+ messages in thread
From: Krzysztof Kozlowski @ 2024-04-24  6:54 UTC (permalink / raw)
  To: Khuong Dinh, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	devicetree, linux-kernel, Krzysztof Kozlowski
  Cc: Krzysztof Kozlowski


On Tue, 02 Apr 2024 22:08:17 +0200, Krzysztof Kozlowski wrote:
> Non-MMIO devices, like fixed-clocks, should not be within simple-bus.
> 

Almost a month passed, no replies from maintainers about picking it up. Dunno,
looks abandoned, so let me grab this. If anyone else wants to pick it up, let
me know.

Applied, thanks!

[1/2] arm64: dts: apm: storm: move non-MMIO node out of soc
      https://git.kernel.org/krzk/linux-dt/c/0fbadd0568e4dab360d4d3092d236ce5fafb24ed
[2/2] arm64: dts: apm: shadowcat: move non-MMIO node out of soc
      https://git.kernel.org/krzk/linux-dt/c/4a3e011b7b9955f030df1423c7a54f7e4bd874bd

Best regards,
-- 
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2024-04-24  6:54 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-04-02 20:08 [PATCH 1/2] arm64: dts: apm: storm: move non-MMIO node out of soc Krzysztof Kozlowski
2024-04-02 20:08 ` [PATCH 2/2] arm64: dts: apm: shadowcat: " Krzysztof Kozlowski
2024-04-24  6:54 ` [PATCH 1/2] arm64: dts: apm: storm: " Krzysztof Kozlowski

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).