From: Lee Jones <lee@kernel.org>
To: Andreas Kemnade <andreas@kemnade.info>
Cc: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
conor+dt@kernel.org, mazziesaccount@gmail.com,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] mfd: rohm-bd71828: Add software-compatible variant BD71879
Date: Fri, 5 Apr 2024 07:35:18 +0100 [thread overview]
Message-ID: <20240405063518.GA6194@google.com> (raw)
In-Reply-To: <20240402193515.513713-3-andreas@kemnade.info>
On Tue, 02 Apr 2024, Andreas Kemnade wrote:
> Add the BD71879 PMIC which is software-compatible to the BD71828, so reuse
> the same device_type enum.
>
> Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
> Suggested-by: Matti Vaittinen <mazziesaccount@gmail.com>
> ---
> drivers/mfd/rohm-bd71828.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/mfd/rohm-bd71828.c b/drivers/mfd/rohm-bd71828.c
> index 4a1fa8a0d76a..f0b444690d4d 100644
> --- a/drivers/mfd/rohm-bd71828.c
> +++ b/drivers/mfd/rohm-bd71828.c
> @@ -585,6 +585,10 @@ static const struct of_device_id bd71828_of_match[] = {
> {
> .compatible = "rohm,bd71828",
> .data = (void *)ROHM_CHIP_TYPE_BD71828,
> + }, {
> + .compatible = "rohm,bd71879",
> + /* equivalent from a software point of view */
Nit: Sentences start with capital letters.
> + .data = (void *)ROHM_CHIP_TYPE_BD71828,
> }, {
> .compatible = "rohm,bd71815",
> .data = (void *)ROHM_CHIP_TYPE_BD71815,
> --
> 2.39.2
>
--
Lee Jones [李琼斯]
prev parent reply other threads:[~2024-04-05 6:35 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-02 19:35 [PATCH 0/2] mfd: Add ROHM BD71879 Andreas Kemnade
2024-04-02 19:35 ` [PATCH 1/2] dt-bindings: " Andreas Kemnade
2024-04-03 8:23 ` Matti Vaittinen
2024-04-04 6:59 ` Krzysztof Kozlowski
2024-04-04 10:30 ` Andreas Kemnade
2024-04-04 12:04 ` Krzysztof Kozlowski
2024-04-05 6:01 ` Matti Vaittinen
2024-04-05 6:31 ` Andreas Kemnade
2024-04-05 6:35 ` Krzysztof Kozlowski
2024-04-05 6:58 ` Matti Vaittinen
2024-04-02 19:35 ` [PATCH 2/2] mfd: rohm-bd71828: Add software-compatible variant BD71879 Andreas Kemnade
2024-04-03 8:21 ` Matti Vaittinen
2024-04-05 6:35 ` Lee Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240405063518.GA6194@google.com \
--to=lee@kernel.org \
--cc=andreas@kemnade.info \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mazziesaccount@gmail.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).