From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f179.google.com (mail-pf1-f179.google.com [209.85.210.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C521712EBE4 for ; Fri, 5 Apr 2024 07:40:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712302858; cv=none; b=httwk0iMIamrlDTfYaRIckCw+eQUCP48+lhFdtdYBe4BF0W5tsv8ABpEeqtQbzlsCq/zbj2zcWFxBuVAUZzZlA8hXPPqdUZITX2Lf8Gz9Ani0r7ZggtDd2UXgsDV6bkcSrCRk0OegBHibPmx+IMMFgDcNhN/8ei2QYOm97FMM08= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712302858; c=relaxed/simple; bh=TlV2tfNsy0zEXW78TY+Y9hKkNagEtGiiitnOqeo8Nr0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=nXQTqgryQ/PLeMrRKUCNxvu2KcU5VCv4kN/zsyRNDGUMiu9HKscyoUU89jx2eD769MEPoK0CzMMkKwX2+FdcTwpZBFwLd+J6TlJ53SDTcFaCIKAWaHpzN2odBOqeIDtpwzMoXJf1UMMGwWQ99byUVcq4KJxaeMwnKrcmKTN6icM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=RHrlE0Ny; arc=none smtp.client-ip=209.85.210.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="RHrlE0Ny" Received: by mail-pf1-f179.google.com with SMTP id d2e1a72fcca58-6ecee1f325bso1404131b3a.2 for ; Fri, 05 Apr 2024 00:40:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1712302855; x=1712907655; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=i1a6gAQh2PhrhPbXculVO9O3NtZn8zLGPDuyjie7Sr0=; b=RHrlE0NyBj9DZq6tajOxAjVnUDk3t2Kjq/T3h7fg6hknd8mVeNu//PpgZrEdiGR7LW /1NdqJmH1sZtfqKdOVSPtDSDsc1nHYnS04SXAFpKW50x3G4npFMfSYxary7bRX6aWROP RIEy93zhapai3yWdwkfIWFc4ur/qUQp2VxhIcw9EonqjosCu0a7cPG/pAqc/FkaEOINF TlrILtZEGaGvoAUPIfze3BtRapD6GX27RE0SGe63KEZrg3u78GyNSZlrPe7NRQIIEDxu IBAQ7hlv+R6hpYqvG/4EqucG/KctvaMZIz9VwKNCsj9piInQcExEFjH+4g1bY0qZSBEn /8ww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712302855; x=1712907655; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=i1a6gAQh2PhrhPbXculVO9O3NtZn8zLGPDuyjie7Sr0=; b=tMDNHjZVCucX8zYdumZa+b4YzrwPdrHqATiRpoFfNdDL7bjjKktUAEufuTwt/8P0hn KsAzoUJ649tBzpXBwZkvkK4Mh8HLZRPv7ag4minaQwaYmpjiZaCF0J+HrDmlnhyIO3ju eV4vWkUcuNF2RBLlaI+cIIJAcUcNFXgBPHLwcreYFahRu494KnK/mddNwhNfOjIeMus1 p+mMLx66LH6XyZKQmGRHuMKfhcHaRIdLosMXVYZNswomx7P2HK0qZqLjxbgLSsOI0Sdq fAxQ84wUZ7g7wVhCC4UNBa6Cs66JTZM3S9A1ZmLvJMN3JXj/NWKewNiodr50eAxWRVKF vSTA== X-Forwarded-Encrypted: i=1; AJvYcCUooRLFLf57rRiyfklVNYUxDvl8rGFNZ0Y9ePfHy6G+QaMdMWh62nJxX3HmAQNL9TB+4UW9YFoHNXOwuv0Ry4akXk1XHCbJW7dpvw== X-Gm-Message-State: AOJu0YyebInj2NYMefZxoBYQti1HcTfQ2xUOAy8hg2EizGNk+RTZSZkz szF9zjf4RsArYg3bXVMUHOGhw8y9kCsLme8tIsq+yxavs86tUGKjr9ViVjfYEg== X-Google-Smtp-Source: AGHT+IGQzPSdv4xCm9KGESdaqlLSMA46b1EcN3+jKD7raTmoSF2Zx46In/rvazfGN0hikiiMIMSQ5g== X-Received: by 2002:a05:6a00:3c8c:b0:6ea:b48a:f971 with SMTP id lm12-20020a056a003c8c00b006eab48af971mr941273pfb.2.1712302854931; Fri, 05 Apr 2024 00:40:54 -0700 (PDT) Received: from thinkpad ([120.60.67.119]) by smtp.gmail.com with ESMTPSA id q26-20020a63505a000000b005df41b00ee9sm820523pgl.68.2024.04.05.00.40.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Apr 2024 00:40:54 -0700 (PDT) Date: Fri, 5 Apr 2024 13:10:44 +0530 From: Manivannan Sadhasivam To: Konrad Dybcio Cc: Krishna chaitanya chundru , Bjorn Andersson , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Rob Herring , Bjorn Helgaas , Krzysztof Kozlowski , Conor Dooley , Rob Herring , Johan Hovold , Brian Masney , Georgi Djakov , linux-arm-msm@vger.kernel.org, linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, vireshk@kernel.org, quic_vbadigan@quicinc.com, quic_skananth@quicinc.com, quic_nitegupt@quicinc.com, quic_parass@quicinc.com Subject: Re: [PATCH v8 2/7] arm64: dts: qcom: sm8450: Add interconnect path to PCIe node Message-ID: <20240405074044.GC2953@thinkpad> References: <20240302-opp_support-v8-0-158285b86b10@quicinc.com> <20240302-opp_support-v8-2-158285b86b10@quicinc.com> <4bd2e661-8e1e-41ff-9b7f-917bb92a196d@linaro.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <4bd2e661-8e1e-41ff-9b7f-917bb92a196d@linaro.org> On Wed, Mar 06, 2024 at 05:04:54PM +0100, Konrad Dybcio wrote: > > > On 3/2/24 04:59, Krishna chaitanya chundru wrote: > > Add pcie-mem & cpu-pcie interconnect path to the PCIe nodes. > > > > Reviewed-by: Manivannan Sadhasivam > > Signed-off-by: Krishna chaitanya chundru > > --- > > arch/arm64/boot/dts/qcom/sm8450.dtsi | 8 ++++++++ > > 1 file changed, 8 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/qcom/sm8450.dtsi b/arch/arm64/boot/dts/qcom/sm8450.dtsi > > index 01e4dfc4babd..6b1d2e0d9d14 100644 > > --- a/arch/arm64/boot/dts/qcom/sm8450.dtsi > > +++ b/arch/arm64/boot/dts/qcom/sm8450.dtsi > > @@ -1781,6 +1781,10 @@ pcie0: pcie@1c00000 { > > <0 0 0 3 &intc 0 0 0 151 IRQ_TYPE_LEVEL_HIGH>, /* int_c */ > > <0 0 0 4 &intc 0 0 0 152 IRQ_TYPE_LEVEL_HIGH>; /* int_d */ > > + interconnects = <&pcie_noc MASTER_PCIE_0 0 &mc_virt SLAVE_EBI1 0>, > > Please use QCOM_ICC_TAG_ALWAYS. > > > + <&gem_noc MASTER_APPSS_PROC 0 &config_noc SLAVE_PCIE_0 0>; > > And this path could presumably be demoted to QCOM_ICC_TAG_ACTIVE_ONLY? > I think it should be fine since there would be no register access done while the RPMh is put into sleep state. Krishna, can you confirm that by executing the CX shutdown with QCOM_ICC_TAG_ACTIVE_ONLY vote for cpu-pcie path on any supported platform? But if we do such change, then it should also be applied to other SoCs. - Mani -- மணிவண்ணன் சதாசிவம்