From: Conor Dooley <conor@kernel.org>
To: Matti Vaittinen <mazziesaccount@gmail.com>
Cc: Andreas Kemnade <andreas@kemnade.info>,
lee@kernel.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] dt-bindings: mfd: Add ROHM BD71879
Date: Wed, 10 Apr 2024 11:03:59 +0100 [thread overview]
Message-ID: <20240410-possum-lecturer-716185901aa5@spud> (raw)
In-Reply-To: <3d5df067-ec94-42c6-bbd0-43ce8cd53e40@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1267 bytes --]
On Wed, Apr 10, 2024 at 10:57:08AM +0300, Matti Vaittinen wrote:
> On 4/4/24 22:54, Andreas Kemnade wrote:
> > As this chip was seen in several devices in the wild, add it.
> >
> > Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
> > Suggested-by: Matti Vaittinen <mazziesaccount@gmail.com>
> > ---
> > .../devicetree/bindings/mfd/rohm,bd71828-pmic.yaml | 7 ++++++-
> > 1 file changed, 6 insertions(+), 1 deletion(-)
> >
> > diff --git a/Documentation/devicetree/bindings/mfd/rohm,bd71828-pmic.yaml b/Documentation/devicetree/bindings/mfd/rohm,bd71828-pmic.yaml
> > index 0b62f854bf6b..07f99738fcf6 100644
> > --- a/Documentation/devicetree/bindings/mfd/rohm,bd71828-pmic.yaml
> > +++ b/Documentation/devicetree/bindings/mfd/rohm,bd71828-pmic.yaml
> > @@ -17,7 +17,12 @@ description: |
> > properties:
> > compatible:
> > - const: rohm,bd71828
> > + oneOf:
> > + - const: rohm,bd71828
> > +
> > + - items:
> > + - const: rohm,bd71879
> > + - const: rohm,bd71828
> > reg:
> > description:
>
> Am I correct, this reads as:
>
> Either
> compatible = rohm,bd71828
> or
> compatible = rohm,bd71879, rohm,bd71828
>
> but not compatible = rohm,bd71879?
Correct.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2024-04-10 10:04 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-04 19:54 [PATCH v2 0/2] mfd: Add ROHM BD71879 Andreas Kemnade
2024-04-04 19:54 ` [PATCH v2 1/2] dt-bindings: " Andreas Kemnade
2024-04-05 6:56 ` Krzysztof Kozlowski
2024-04-10 7:57 ` Matti Vaittinen
2024-04-10 10:03 ` Conor Dooley [this message]
2024-04-10 10:57 ` Matti Vaittinen
2024-04-11 16:31 ` (subset) " Lee Jones
2024-04-04 19:54 ` [PATCH v2 2/2] mfd: rohm-bd71828: Add software-compatible variant BD71879 Andreas Kemnade
2024-04-05 7:00 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240410-possum-lecturer-716185901aa5@spud \
--to=conor@kernel.org \
--cc=andreas@kemnade.info \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mazziesaccount@gmail.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox