From: Lee Jones <lee@kernel.org>
To: Andre Przywara <andre.przywara@arm.com>
Cc: Chen-Yu Tsai <wens@csie.org>, Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-sunxi@lists.linux.dev,
Jernej Skrabec <jernej.skrabec@gmail.com>,
Samuel Holland <samuel@sholland.org>,
Ryan Walklin <ryan@testtoast.com>,
Chris Morgan <macroalpha82@gmail.com>
Subject: Re: [PATCH 0/4] regulator: Fix AXP717 PMIC support
Date: Thu, 11 Apr 2024 12:22:21 +0100 [thread overview]
Message-ID: <20240411112221.GG1980182@google.com> (raw)
In-Reply-To: <20240329235033.25309-1-andre.przywara@arm.com>
On Fri, 29 Mar 2024, Andre Przywara wrote:
> Here are some fixes to the AXP717 PMIC support series. Lee put that in
> an immutable branch already, so these here go on top.
> Patch 1 contains fixes to the regulator descriptions: the LDOs had the
> wrong supply source, and two numbers were wrong. The datasheet describes
> the voltage ranges and register values differently from what our macros
> expect, in a way that literally begs for off-by-ones, so here you go.
> I don't know if that's still feasible, but it would be a good candidate
> to squash into the patch that it fixes.
>
> The other three patches add the "boost" regulator, which is meant to
> provide the 5V USB VBUS power when operating from the battery. It's the
> usual trinity of binding/mfd/regulator patches.
> Again this could be squashed into the respective patches from the
> original series, if people agree.
>
> Please have a look and test on a device, since I could not do this.
>
> Based on mfd/ib-mfd-regulator-6.10, as detailed below.
>
> Cheers,
> Andre
>
> Andre Przywara (4):
> regulator: axp20x: AXP717: fix LDO supply rails and off-by-ones
> dt-bindings: mfd: x-powers,axp152: add boost regulator
> mfd: axp20x: AXP717: Add support for boost regulator
> regulator: axp20x: AXP717: Add boost regulator
>
> .../bindings/mfd/x-powers,axp152.yaml | 2 +-
> drivers/mfd/axp20x.c | 2 ++
> drivers/regulator/axp20x-regulator.c | 32 +++++++++++--------
> include/linux/mfd/axp20x.h | 3 ++
> 4 files changed, 24 insertions(+), 15 deletions(-)
I need an Ack from Mark before I can process these.
--
Lee Jones [李琼斯]
prev parent reply other threads:[~2024-04-11 11:22 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-29 23:50 [PATCH 0/4] regulator: Fix AXP717 PMIC support Andre Przywara
2024-03-29 23:50 ` [PATCH 1/4] regulator: axp20x: AXP717: fix LDO supply rails and off-by-ones Andre Przywara
2024-04-14 8:00 ` John Watts
2024-04-16 11:23 ` Andre Przywara
2024-04-16 13:30 ` John Watts
2024-03-29 23:50 ` [PATCH 2/4] dt-bindings: mfd: x-powers,axp152: add boost regulator Andre Przywara
2024-03-30 9:30 ` Krzysztof Kozlowski
2024-03-30 21:40 ` Andre Przywara
2024-03-30 21:40 ` Andre Przywara
2024-03-29 23:50 ` [PATCH 3/4] mfd: axp20x: AXP717: Add support for " Andre Przywara
2024-04-14 7:47 ` John Watts
2024-03-29 23:50 ` [PATCH 4/4] regulator: axp20x: AXP717: Add " Andre Przywara
2024-04-14 7:47 ` John Watts
2024-04-11 11:22 ` Lee Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240411112221.GG1980182@google.com \
--to=lee@kernel.org \
--cc=andre.przywara@arm.com \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jernej.skrabec@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=macroalpha82@gmail.com \
--cc=robh@kernel.org \
--cc=ryan@testtoast.com \
--cc=samuel@sholland.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).