From: Francesco Dolcini <francesco@dolcini.it>
To: Udit Kumar <u-kumar1@ti.com>
Cc: nm@ti.com, vigneshr@ti.com, linux-arm-kernel@lists.infradead.org,
devicetree@vger.kernel.org, kristo@kernel.org, robh@kernel.org,
krzk+dt@kernel.org, conor+dt@kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] arm64: dts: ti: k3-j784s4-evm: Arranging mux and macro update
Date: Mon, 15 Apr 2024 09:31:10 +0200 [thread overview]
Message-ID: <20240415073110.GA7360@francesco-nb> (raw)
In-Reply-To: <20240415063329.3286600-2-u-kumar1@ti.com>
Hello,
On Mon, Apr 15, 2024 at 12:03:26PM +0530, Udit Kumar wrote:
> Updating J784S4 macro for pin mux instead of J721S2.
>
> Also arranging pin mux in order of main_pmx0/1, wkup_pmx0/1/2/3
> along with fixing pin type for TX as output of wkup_uart.
Are you doing a refactoring + fixes in the same commit or I
misunderstood your commit message?
If this is the case I would suggest to have separate commit for the fix
and the refactoring, with the fix being first in the series and with a
fixes tag.
From a quick look, this comment may apply to other commits in the
series.
Thanks,
Francesco
next prev parent reply other threads:[~2024-04-15 7:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-15 6:33 [PATCH 0/4] Arranging mux and macro update Udit Kumar
2024-04-15 6:33 ` [PATCH 1/4] arm64: dts: ti: k3-j784s4-evm: " Udit Kumar
2024-04-15 7:31 ` Francesco Dolcini [this message]
2024-04-15 7:38 ` Kumar, Udit
2024-04-15 6:33 ` [PATCH 2/4] arm64: dts: ti: k3-am69-sk: Fix UART pin type " Udit Kumar
2024-04-15 6:33 ` [PATCH 3/4] arm64: dts: ti: k3-j7200: Arranging pin mux in order Udit Kumar
2024-04-15 6:33 ` [PATCH 4/4] arm64: dts: ti: k3-j721s2: " Udit Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240415073110.GA7360@francesco-nb \
--to=francesco@dolcini.it \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kristo@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nm@ti.com \
--cc=robh@kernel.org \
--cc=u-kumar1@ti.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox