devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Francesco Dolcini <francesco@dolcini.it>
To: Frank Li <Frank.Li@nxp.com>
Cc: Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Shawn Guo <shawnguo@kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Fabio Estevam <festevam@gmail.com>,
	devicetree@vger.kernel.org, imx@lists.linux.dev,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 02/10] arm64: dts: imx8qm-ss-audio: add audio nodes
Date: Tue, 16 Apr 2024 08:50:26 +0200	[thread overview]
Message-ID: <20240416065026.GA4165@francesco-nb> (raw)
In-Reply-To: <20240415-dts_8qm_audio-v1-2-2976c35a0c52@nxp.com>

Hello Frank,

On Mon, Apr 15, 2024 at 03:46:38PM -0400, Frank Li wrote:
> Add i.MX8QM audio related nodes and update eDMA[0,1]'s information.
> 
> Signed-off-by: Frank Li <Frank.Li@nxp.com>
> ---
>  arch/arm64/boot/dts/freescale/imx8qm-ss-audio.dtsi | 473 +++++++++++++++++++++
>  arch/arm64/boot/dts/freescale/imx8qm.dtsi          |  86 ++++
>  2 files changed, 559 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx8qm-ss-audio.dtsi b/arch/arm64/boot/dts/freescale/imx8qm-ss-audio.dtsi
> new file mode 100644
> index 0000000000000..ed5a1b4af1d76
> --- /dev/null
> +++ b/arch/arm64/boot/dts/freescale/imx8qm-ss-audio.dtsi
> @@ -0,0 +1,473 @@
> +// SPDX-License-Identifier: GPL-2.0+

OR MIT?

Normally for device tree files having both is preferred.

> +/*
> + * Copyright 2024 NXP
> + *	Dong Aisheng <aisheng.dong@nxp.com>
> + */
> +
> +/delete-node/ &acm;
> +/delete-node/ &sai4;
> +/delete-node/ &sai5;
> +/delete-node/ &sai4_lpcg;
> +/delete-node/ &sai5_lpcg;

Can you explain these delete-node ? This is something that I would
expect when a dtsi is previously included, not in this case.

Francesco


  reply	other threads:[~2024-04-16  6:50 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-15 19:46 [PATCH 00/10] arm64: dts: imx8qm Add audio\flexcan\i2c\fec1 nodes for imx8qm-mek board Frank Li
2024-04-15 19:46 ` [PATCH 01/10] arm64: dts: imx8-ss-audio: remove memory-region = <&dsp_reserved>; Frank Li
2024-04-15 19:46 ` [PATCH 02/10] arm64: dts: imx8qm-ss-audio: add audio nodes Frank Li
2024-04-16  6:50   ` Francesco Dolcini [this message]
2024-04-17 16:01     ` Frank Li
2024-04-17 17:20       ` Francesco Dolcini
2024-04-17 18:29         ` Frank Li
2024-04-15 19:46 ` [PATCH 03/10] arm64: dts: imx8qm-mek: add sai and wm8960 support Frank Li
2024-04-15 19:46 ` [PATCH 04/10] arm64: dts: imx8x: add cm41 subsystem dtsi Frank Li
2024-04-15 19:46 ` [PATCH 05/10] arm64: dts: imx8qm-mek: add i2c0 and children devices Frank Li
2024-04-15 19:46 ` [PATCH 06/10] arm64: dts: imx8qm-mek: add cm41_i2c " Frank Li
2024-04-15 19:46 ` [PATCH 07/10] arm64: dts: imx8qm-mek: add flexcan support Frank Li
2024-04-15 19:46 ` [PATCH 08/10] arm64: dts: imx8qm-mek: add lsio mu5 and mu6 Frank Li
2024-04-15 19:46 ` [PATCH 09/10] arm64: dts: imx8qm: add ocopt and fec_mac[0,1] Frank Li
2024-04-15 19:46 ` [PATCH 10/10] arm64: dts: imx8qm-mek: add fec2 support Frank Li
2024-04-16  6:52   ` Francesco Dolcini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240416065026.GA4165@francesco-nb \
    --to=francesco@dolcini.it \
    --cc=Frank.Li@nxp.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=imx@lists.linux.dev \
    --cc=kernel@pengutronix.de \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).