From: Rob Herring <robh@kernel.org>
To: skseofh@gmail.com
Cc: saravanak@google.com, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] of: of_reserved_mem: remove repeated call to get no-map property
Date: Tue, 16 Apr 2024 08:15:54 -0500 [thread overview]
Message-ID: <20240416131554.GA2105823-robh@kernel.org> (raw)
In-Reply-To: <20240412140938.137803-1-skseofh@gmail.com>
On Fri, Apr 12, 2024 at 11:09:38PM +0900, skseofh@gmail.com wrote:
> From: Daero Lee <skseofh@gmail.com>
>
> In __reserved_mem_alloc_size, of_get_flat_dt_prop is called and checked
> whether the "no-map" property exists for the node. In
> fdt_init_reserved_mem, the only caller of __reserved_mem_alloc_size,
> we checked this again for the same node. Therefore, repeated
> of_get_flat_dt_prop call was removed and 'nomap' was passed as an input
> parameter to the callee function.
This code is all about to get rearranged[1], so holding off on this.
Rob
[1] https://lore.kernel.org/lkml/20240328211543.191876-1-quic_obabatun@quicinc.com/
prev parent reply other threads:[~2024-04-16 13:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-12 14:09 [PATCH] of: of_reserved_mem: remove repeated call to get no-map property skseofh
2024-04-16 13:15 ` Rob Herring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240416131554.GA2105823-robh@kernel.org \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=saravanak@google.com \
--cc=skseofh@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).