From: Conor Dooley <conor@kernel.org>
To: Kousik Sanagavarapu <five231003@gmail.com>
Cc: Mark Brown <broonie@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Shuah Khan <skhan@linuxfoundation.org>,
Javier Carrasco <javier.carrasco.cruz@gmail.com>,
linux-spi@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] spi: dt-bindings: armada-3700: convert to dtschema
Date: Wed, 17 Apr 2024 16:13:49 +0100 [thread overview]
Message-ID: <20240417-clobber-brought-49867bc036bd@spud> (raw)
In-Reply-To: <20240417052729.6612-1-five231003@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 3557 bytes --]
On Wed, Apr 17, 2024 at 10:57:06AM +0530, Kousik Sanagavarapu wrote:
> Convert txt binding of marvell armada 3700 SoC spi controller to dtschema
> to allow for validation.
>
> Signed-off-by: Kousik Sanagavarapu <five231003@gmail.com>
> ---
> .../bindings/spi/marvell,armada-3700-spi.yaml | 55 +++++++++++++++++++
> .../bindings/spi/spi-armada-3700.txt | 25 ---------
> 2 files changed, 55 insertions(+), 25 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/spi/marvell,armada-3700-spi.yaml
> delete mode 100644 Documentation/devicetree/bindings/spi/spi-armada-3700.txt
>
> diff --git a/Documentation/devicetree/bindings/spi/marvell,armada-3700-spi.yaml b/Documentation/devicetree/bindings/spi/marvell,armada-3700-spi.yaml
> new file mode 100644
> index 000000000000..61caa1d86188
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/spi/marvell,armada-3700-spi.yaml
> @@ -0,0 +1,55 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/spi/marvell,armada-3700-spi.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Marvell Armada 3700 SPI Controller
> +
> +description:
> + The SPI controller on Marvell Armada 3700 SoC.
> +
> +maintainers:
> + - Kousik Sanagavarapu <five231003@gmail.com>
> +
> +allOf:
> + - $ref: spi-controller.yaml#
> +
> +properties:
> + compatible:
> + const: marvell,armada-3700-spi
> +
> + reg:
> + maxItems: 1
> +
> + interrupts:
> + maxItems: 1
> +
> + clocks:
> + maxItems: 1
> +
> + num-cs:
> + maxItems: 1
> +
> +required:
> + - compatible
> + - reg
> + - interrupts
> + - clocks
> +
> +unevaluatedProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/interrupt-controller/arm-gic.h>
> +
> + spi0: spi@10600 {
Iff there's a resubmission, drop the lavel here since it has no users.
Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
Cheers,
Conor.
> + compatible = "marvell,armada-3700-spi";
> + #address-cells = <1>;
> + #size-cells = <0>;
> + reg = <0x10600 0x5d>;
> + clocks = <&nb_perih_clk 7>;
> + interrupts = <GIC_SPI 0 IRQ_TYPE_LEVEL_HIGH>;
> + num-cs = <4>;
> + };
> +...
> diff --git a/Documentation/devicetree/bindings/spi/spi-armada-3700.txt b/Documentation/devicetree/bindings/spi/spi-armada-3700.txt
> deleted file mode 100644
> index 1564aa8c02cd..000000000000
> --- a/Documentation/devicetree/bindings/spi/spi-armada-3700.txt
> +++ /dev/null
> @@ -1,25 +0,0 @@
> -* Marvell Armada 3700 SPI Controller
> -
> -Required Properties:
> -
> -- compatible: should be "marvell,armada-3700-spi"
> -- reg: physical base address of the controller and length of memory mapped
> - region.
> -- interrupts: The interrupt number. The interrupt specifier format depends on
> - the interrupt controller and of its driver.
> -- clocks: Must contain the clock source, usually from the North Bridge clocks.
> -- num-cs: The number of chip selects that is supported by this SPI Controller
> -- #address-cells: should be 1.
> -- #size-cells: should be 0.
> -
> -Example:
> -
> - spi0: spi@10600 {
> - compatible = "marvell,armada-3700-spi";
> - #address-cells = <1>;
> - #size-cells = <0>;
> - reg = <0x10600 0x5d>;
> - clocks = <&nb_perih_clk 7>;
> - interrupts = <GIC_SPI 0 IRQ_TYPE_LEVEL_HIGH>;
> - num-cs = <4>;
> - };
> --
> 2.44.0.548.g91ec36f2cc
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2024-04-17 15:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-17 5:27 [PATCH] spi: dt-bindings: armada-3700: convert to dtschema Kousik Sanagavarapu
2024-04-17 15:13 ` Conor Dooley [this message]
2024-04-22 1:00 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240417-clobber-brought-49867bc036bd@spud \
--to=conor@kernel.org \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=five231003@gmail.com \
--cc=javier.carrasco.cruz@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=robh@kernel.org \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox