From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f181.google.com (mail-pf1-f181.google.com [209.85.210.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C9AA854737 for ; Wed, 17 Apr 2024 07:06:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.181 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713337592; cv=none; b=mr8cbfyCWunAxx58TLKAn6gUh4R/6BhvywldP7nTZYtaiox4A/l9FRhLAY88S+Tukn7FNqdTqS9t90SQe/C1uq0dL7uuC+ZIMXJa8Wn97fPjXQscw/4ldkSN9NamqiNlR2NZ7/k8SfdHgHxhPKmFIZYbqBMDANV8HSOyQjpL61Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713337592; c=relaxed/simple; bh=TOB6vp87U9Lnnn2dsE4owyfBnMI3t4WxK3sGEUGR9XI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Cppxr3Hwfi2lF/TAKZyRdBD2Vgy/+ZwWrrNmuSyrO/3PaDCHDD99qf9I9Xwt4EcAGwTrsktz8HDZxcmyobcp0tNyds1xXUy4n5mfDX3M7WiAU6ifq9r5Ielx7bkDgGFHBpRvHdYZ2lYQMeoQGNrcIJ/pxsXrzKT4yjJ2akyNU5E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=RUgCveJ6; arc=none smtp.client-ip=209.85.210.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="RUgCveJ6" Received: by mail-pf1-f181.google.com with SMTP id d2e1a72fcca58-6ed2dc03df6so4642145b3a.1 for ; Wed, 17 Apr 2024 00:06:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1713337590; x=1713942390; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=Id9wk8bOD3jpvQHQWy0txCOh7lELBvXiW74KprcLKWE=; b=RUgCveJ6QvF6PTGt7ORkajy1ZJT0hzUkS+VzTq0m7bBQK76HZD6gOQfWlXzMxBhbbY 6x15t1OU4V+r5YPUekLHJ64SYD7wEfqxTaBzGk2tNM1GUn7K9bccuat+UlGjxUFuo4Op V4BySagYccoRpTJM9+hwiOpYzwb/iR/Cfds4JQe8RB9Dol9V8UHbrCEkGRCyNS8Jbkz8 kHHkcV9LP3cuEzXtc7YN+/oSRq9X96dQtLr9oWF7Nbm61cXZDo2hLmZBZwGjFOONYuo0 /Vhvd39mDdN6pZhYZ7/L/XkqqzYgChHFUNVwlFGav0SZCUDAKCAarm8BKlUWp/J8nx4a UzwA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713337590; x=1713942390; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Id9wk8bOD3jpvQHQWy0txCOh7lELBvXiW74KprcLKWE=; b=eHJ3uYvkZ3cUzRoRO7D8wTSk7M2Na0qL0e7MEMXlAgIGRcPQf5GiR+w77b9mQrA7fC +rKoD1pj7X0TQUyg4vpL5Bnfwrq9sbdeST5vcteknmYkYWpwMhmbl98JRi6UDCMzaPW8 r27FZE1UJZ7aF1Oo5C+ne4YUeYPwhzvkTp435rcjFJDLFPuV2on2xir5IEXuagAjyBdl 0FJ4zz64P++3ytoU3I43rWdCpSqB/gnaCuIyrWI0vO+rAj5F35M/FJ3i1u4JPdonusLQ 8icG5nsnpd/9OMhftKEXfpLZJJ2C7qpoGEQa4NL95PV4FJGI0JkCXtXOCiUf/Va8A5lk EYdg== X-Forwarded-Encrypted: i=1; AJvYcCW6kL6TJOQPe5jX/T6wUH8lc8qZDU6vvO/jVDgHt2zA9YsB1QkR0JazKUNuMRNKigbQf/81pg8xN9ytIWl9jULilSSyunIkfq93Vg== X-Gm-Message-State: AOJu0YxUrscu+n1ulkZJcwzqKTmKtvjqvJ8xK0rtrBwzV59aacnqbXPN ywCqpx3COg36Zb01p/JS+gvAYquUuWstFehGGfLns1ZzyQw9oXz2zShfacW5/A== X-Google-Smtp-Source: AGHT+IH83KUdU6BtzRYL1t2NbRvI4qrrCGxtRd9cEdm+JtEHXxziFKFvGoFUMzWi78eYTsfdqTGaMA== X-Received: by 2002:a05:6a21:3a85:b0:1aa:755f:1746 with SMTP id zv5-20020a056a213a8500b001aa755f1746mr911915pzb.22.1713337589983; Wed, 17 Apr 2024 00:06:29 -0700 (PDT) Received: from thinkpad ([120.60.54.9]) by smtp.gmail.com with ESMTPSA id a21-20020aa78655000000b006e6c16179dbsm10134759pfo.24.2024.04.17.00.06.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Apr 2024 00:06:29 -0700 (PDT) Date: Wed, 17 Apr 2024 12:36:16 +0530 From: Manivannan Sadhasivam To: mr.nuke.me@gmail.com Cc: Dmitry Baryshkov , Bjorn Andersson , Konrad Dybcio , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Rob Herring , Bjorn Helgaas , Krzysztof Kozlowski , Conor Dooley , Vinod Koul , Kishon Vijay Abraham I , Michael Turquette , Stephen Boyd , linux-arm-msm@vger.kernel.org, linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org, linux-clk@vger.kernel.org Subject: Re: [PATCH v3 4/7] PCI: qcom: Add support for IPQ9574 Message-ID: <20240417070616.GB3894@thinkpad> References: <20240415182052.374494-1-mr.nuke.me@gmail.com> <20240415182052.374494-5-mr.nuke.me@gmail.com> <3cfc26e6-5587-d4a2-f217-1a30169ad1a0@gmail.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <3cfc26e6-5587-d4a2-f217-1a30169ad1a0@gmail.com> On Mon, Apr 15, 2024 at 03:07:02PM -0500, mr.nuke.me@gmail.com wrote: > > > On 4/15/24 15:04, Dmitry Baryshkov wrote: > > On Mon, 15 Apr 2024 at 21:22, Alexandru Gagniuc wrote: > > > > > > Add support for the PCIe on IPQ9574. The main difference from ipq6018 > > > is that the "iface" clock is not necessarry. Add a special case in > > > qcom_pcie_get_resources_2_9_0() to handle this. > > > > > > Signed-off-by: Alexandru Gagniuc > > > --- > > > drivers/pci/controller/dwc/pcie-qcom.c | 13 +++++++++---- > > > 1 file changed, 9 insertions(+), 4 deletions(-) > > > > > > diff --git a/drivers/pci/controller/dwc/pcie-qcom.c b/drivers/pci/controller/dwc/pcie-qcom.c > > > index 14772edcf0d3..10560d6d6336 100644 > > > --- a/drivers/pci/controller/dwc/pcie-qcom.c > > > +++ b/drivers/pci/controller/dwc/pcie-qcom.c > > > @@ -1101,15 +1101,19 @@ static int qcom_pcie_get_resources_2_9_0(struct qcom_pcie *pcie) > > > struct qcom_pcie_resources_2_9_0 *res = &pcie->res.v2_9_0; > > > struct dw_pcie *pci = pcie->pci; > > > struct device *dev = pci->dev; > > > - int ret; > > > + int ret, num_clks = ARRAY_SIZE(res->clks) - 1; > > > > > > - res->clks[0].id = "iface"; > > > + res->clks[0].id = "rchng"; > > > res->clks[1].id = "axi_m"; > > > res->clks[2].id = "axi_s"; > > > res->clks[3].id = "axi_bridge"; > > > - res->clks[4].id = "rchng"; > > > > > > - ret = devm_clk_bulk_get(dev, ARRAY_SIZE(res->clks), res->clks); > > > + if (!of_device_is_compatible(dev->of_node, "qcom,pcie-ipq9574")) { > > > + res->clks[4].id = "iface"; > > > + num_clks++; > > > + } > > > + > > > + ret = devm_clk_bulk_get(dev, num_clks, res->clks); > > > > Just use devm_clk_bulk_get_optional() here. > > Thank you! I wasn't sure if this was the correct solution here. I will get > this updated in v4. > Please rebase on top of [1] and mention the dependency in cover letter. - Mani [1] https://lore.kernel.org/linux-pci/20240417-pci-qcom-clk-bulk-v1-1-52ca19b3d6b2@linaro.org/ > Alex > > > > if (ret < 0) > > > return ret; > > > > > > @@ -1664,6 +1668,7 @@ static const struct of_device_id qcom_pcie_match[] = { > > > { .compatible = "qcom,pcie-ipq8064-v2", .data = &cfg_2_1_0 }, > > > { .compatible = "qcom,pcie-ipq8074", .data = &cfg_2_3_3 }, > > > { .compatible = "qcom,pcie-ipq8074-gen3", .data = &cfg_2_9_0 }, > > > + { .compatible = "qcom,pcie-ipq9574", .data = &cfg_2_9_0 }, > > > { .compatible = "qcom,pcie-msm8996", .data = &cfg_2_3_2 }, > > > { .compatible = "qcom,pcie-qcs404", .data = &cfg_2_4_0 }, > > > { .compatible = "qcom,pcie-sa8540p", .data = &cfg_sc8280xp }, > > > -- > > > 2.40.1 > > > > > > > > > > -- மணிவண்ணன் சதாசிவம்