devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Eddie James <eajames@linux.ibm.com>
To: linux-aspeed@lists.ozlabs.org
Cc: joel@jms.id.au, andrew@codeconstruct.com.au,
	devicetree@vger.kernel.org, linux-fsi@lists.ozlabs.org,
	robh@kernel.org, conor+dt@kernel.org, krzk+dt@kernel.org,
	jk@ozlabs.org, alistair@popple.id.au, eajames@linux.ibm.com,
	lakshmiy@us.ibm.com
Subject: [PATCH v3 0/3] fsi: sbefifo: Prevent async FFDC collection for Odyssey SBEFIFOs
Date: Fri, 19 Apr 2024 16:11:40 -0500	[thread overview]
Message-ID: <20240419211143.1039868-1-eajames@linux.ibm.com> (raw)

A new type of SBE, found on the Odyssey chip, will return any async FFDC in
the next transaction, so collecting the FFDC is unnecessary and results in
unexpected behavior. This difference in behavior between the Odyssey SBE
and the POWER9/10 SBEs wasn't apparent when support for the Odyssey was
added. To fix the unexpected behavior, turn off the async collection fot
Odyssey SBEFIFOs.

Changes since v2:
 - Update commit messages slightly
 - Rename dts binding file
 - Remove '|' after description in dts binding
 - Change generic node name in dts binding to match fsi.txt

Changes since v1:
 - Change "ody" to "odyssey"
 - Fix minor issues in binding document

Eddie James (3):
  dt-bindings: fsi: Document the IBM SBEFIFO engine
  fsi: sbefifo: Prevent async FFDC collection for Odyssey SBEFIFOs
  ARM: dts: aspeed: Update Odyssey SBEFIFO compatible strings

 .../bindings/fsi/ibm,p9-sbefifo.yaml          | 39 +++++++++++
 .../dts/aspeed/aspeed-bmc-ibm-everest.dts     | 64 +++++++++----------
 .../arm/boot/dts/aspeed/ibm-power10-quad.dtsi | 64 +++++++++----------
 drivers/fsi/fsi-sbefifo.c                     | 37 +++++++++++
 4 files changed, 140 insertions(+), 64 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/fsi/ibm,p9-sbefifo.yaml

-- 
2.39.3


             reply	other threads:[~2024-04-19 21:18 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-19 21:11 Eddie James [this message]
2024-04-19 21:11 ` [PATCH v3 1/3] dt-bindings: fsi: Document the IBM SBEFIFO engine Eddie James
2024-04-20 10:54   ` Conor Dooley
2024-04-21 23:02   ` Andrew Jeffery
2024-04-25 21:38     ` Eddie James
2024-04-26  0:05       ` Andrew Jeffery
2024-04-19 21:11 ` [PATCH v3 2/3] fsi: sbefifo: Prevent async FFDC collection for Odyssey SBEFIFOs Eddie James
2024-04-19 21:11 ` [PATCH v3 3/3] ARM: dts: aspeed: Update Odyssey SBEFIFO compatible strings Eddie James

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240419211143.1039868-1-eajames@linux.ibm.com \
    --to=eajames@linux.ibm.com \
    --cc=alistair@popple.id.au \
    --cc=andrew@codeconstruct.com.au \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=jk@ozlabs.org \
    --cc=joel@jms.id.au \
    --cc=krzk+dt@kernel.org \
    --cc=lakshmiy@us.ibm.com \
    --cc=linux-aspeed@lists.ozlabs.org \
    --cc=linux-fsi@lists.ozlabs.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).