Re: [PATCH 3/8] dt-bindings: adc: axi-adc: add clocks property

Jonathan Cameron
2024-04-20T15:04:16Z

On Fri, 19 Apr 2024 17:36:46 +0200
Nuno Sa via B4 Relay <devnull+nuno.sa.analog.com@kernel.org> wrote:

> From: Nuno Sa <nuno.sa@analog.com>
>
> Add a required clock property as we can't access the device registers if
> the AXI bus clock is not properly enabled.
>
> Signed-off-by: Nuno Sa <nuno.sa@analog.com>
Fix, or doesn't matter until this series?

Obviously should have been in the binding anyway, but whether
it matters already affects whether this should go to stable or not.

Jonathan

> ---
> Documentation/devicetree/bindings/iio/adc/adi,axi-adc.yaml | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/iio/adc/adi,axi-adc.yaml b/Documentation/devicetree/bindings/iio/adc/adi,axi-adc.yaml
> index 3d49d21ad33df..e1f450b80db27 100644
> --- a/Documentation/devicetree/bindings/iio/adc/adi,axi-adc.yaml
> +++ b/Documentation/devicetree/bindings/iio/adc/adi,axi-adc.yaml
> @@ -28,6 +28,9 @@ properties:
> reg:
> maxItems: 1
>
> + clocks:
> + maxItems: 1
> +
> dmas:
> maxItems: 1
>
> @@ -48,6 +51,7 @@ required:
> - compatible
> - dmas
> - reg
> + - clocks
>
> additionalProperties: false
>
> @@ -58,6 +62,7 @@ examples:
> reg = <0x44a00000 0x10000>;
> dmas = <&rx_dma 0>;
> dma-names = "rx";
> + clocks = <&axi_clk>;
> #io-backend-cells = <0>;
> };
> ...
>