From: Rob Herring <robh@kernel.org>
To: Frank Li <Frank.li@nxp.com>
Cc: Laurentiu Mihalcea <laurentiumihalcea111@gmail.com>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
Daniel Baluta <daniel.baluta@nxp.com>,
Shengjiu Wang <shengjiu.wang@nxp.com>,
Liu Ying <victor.liu@nxp.com>,
Laurentiu Mihalcea <laurentiu.mihalcea@nxp.com>,
devicetree@vger.kernel.org, imx@lists.linux.dev,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/3] dt-bindings: dsp: support imx8ulp dsp clocks
Date: Mon, 22 Apr 2024 09:24:49 -0500 [thread overview]
Message-ID: <20240422142449.GA1186917-robh@kernel.org> (raw)
In-Reply-To: <ZiGLxBa8CMsaRSTc@lizhi-Precision-Tower-5810>
On Thu, Apr 18, 2024 at 05:08:20PM -0400, Frank Li wrote:
> On Thu, Apr 18, 2024 at 11:37:18PM +0300, Laurentiu Mihalcea wrote:
> > From: Laurentiu Mihalcea <laurentiu.mihalcea@nxp.com>
> >
> > i.MX8ULP DSP node needs a MU clock, but doesn't need
> > a debug clock. Change "clocks" and "clock-names" properties
> > to allow for this case.
> >
> > Signed-off-by: Laurentiu Mihalcea <laurentiu.mihalcea@nxp.com>
> > ---
> > .../devicetree/bindings/dsp/fsl,dsp.yaml | 51 ++++++++++++++-----
> > 1 file changed, 39 insertions(+), 12 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/dsp/fsl,dsp.yaml b/Documentation/devicetree/bindings/dsp/fsl,dsp.yaml
> > index 9af40da5688e..4a39d57b1cc6 100644
> > --- a/Documentation/devicetree/bindings/dsp/fsl,dsp.yaml
> > +++ b/Documentation/devicetree/bindings/dsp/fsl,dsp.yaml
> > @@ -30,22 +30,12 @@ properties:
> > maxItems: 1
> >
> > clocks:
> > - items:
> > - - description: ipg clock
> > - - description: ocram clock
> > - - description: core clock
> > - - description: debug interface clock
> > - - description: message unit clock
> > minItems: 3
> > + maxItems: 5
> >
> > clock-names:
> > - items:
> > - - const: ipg
> > - - const: ocram
> > - - const: core
> > - - const: debug
> > - - const: mu
> > minItems: 3
> > + maxItems: 5
> >
> > power-domains:
> > description:
> > @@ -93,6 +83,43 @@ required:
> > - memory-region
> >
> > allOf:
> > + - if:
> > + properties:
> > + compatible:
> > + contains:
> > + const: fsl,imx8ulp-hifi4
> > + then:
> > + properties:
> > + clocks:
> > + items:
> > + - description: ipg clock
> > + - description: ocram clock
> > + - description: core clock
> > + - description: message unit clock
> > + clock-names:
> > + items:
> > + - const: ipg
> > + - const: ocram
> > + - const: core
> > + - const: mu
> > + else:
> > + properties:
> > + clocks:
> > + items:
> > + - description: ipg clock
> > + - description: ocram clock
> > + - description: core clock
> > + - description: debug interface clock
> > + - description: message unit clock
> > + minItems: 3
> > + clock-names:
> > + items:
> > + - const: ipg
> > + - const: ocram
> > + - const: core
> > + - const: debug
> > + - const: mu
> > + minItems: 3
>
> According to your descript, look like only clk "debug" is difference.
>
> How about
>
> clocks:
> items:
> - description: ipg clock
> - description: ocram clock
> - description: core clock
> - description: message unit clock
> - description: debug interface clock
>
> clock-names:
> items:
> - const: ipg
> - const: ocram
> - const: core
> - const: mu
> - const: debug
You can't change the existing order, so this does not work.
Rob
next prev parent reply other threads:[~2024-04-22 14:24 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-18 20:37 [PATCH 0/3] Add DSP node for imx8ulp Laurentiu Mihalcea
2024-04-18 20:37 ` [PATCH 1/3] dt-bindings: dsp: support imx8ulp dsp clocks Laurentiu Mihalcea
2024-04-18 21:08 ` Frank Li
2024-04-22 14:24 ` Rob Herring [this message]
2024-04-22 14:26 ` Rob Herring
2024-04-18 20:37 ` [PATCH 2/3] dt-bindings: mfd: add schema for 8ulp AVD-SIM Laurentiu Mihalcea
2024-04-18 21:10 ` Frank Li
2024-04-22 14:29 ` Rob Herring
2024-05-09 18:48 ` Laurentiu Mihalcea
2024-05-13 9:02 ` Krzysztof Kozlowski
2024-04-18 20:37 ` [PATCH 3/3] arm64: dts: imx8ulp: add DSP node Laurentiu Mihalcea
2024-04-18 21:17 ` Frank Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240422142449.GA1186917-robh@kernel.org \
--to=robh@kernel.org \
--cc=Frank.li@nxp.com \
--cc=conor+dt@kernel.org \
--cc=daniel.baluta@nxp.com \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=imx@lists.linux.dev \
--cc=kernel@pengutronix.de \
--cc=krzk+dt@kernel.org \
--cc=laurentiu.mihalcea@nxp.com \
--cc=laurentiumihalcea111@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=shengjiu.wang@nxp.com \
--cc=victor.liu@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).