From: Conor Dooley <conor@kernel.org>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Thomas Bonnefille <thomas.bonnefille@bootlin.com>,
jszhang@kernel.org, guoren@kernel.org, wefu@redhat.com,
andi.shyti@kernel.org, robh@kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org, miquel.raynal@bootlin.com,
thomas.petazzoni@bootlin.com, linux-riscv@lists.infradead.org,
linux-i2c@vger.kernel.org, devicetree@vger.kernel.org,
paul.walmsley@sifive.com, palmer@dabbelt.com,
aou@eecs.berkeley.edu
Subject: Re: [PATCH 2/4] riscv: boot: dts: thead: Fix node ordering in TH1520 device tree
Date: Thu, 25 Apr 2024 17:39:37 +0100 [thread overview]
Message-ID: <20240425-mouse-unfair-1e0d9b19c713@spud> (raw)
In-Reply-To: <bc69023d-5e70-4d5d-96d1-f298cec5b59d@kernel.org>
[-- Attachment #1: Type: text/plain, Size: 691 bytes --]
On Thu, Apr 25, 2024 at 11:49:10AM +0200, Krzysztof Kozlowski wrote:
> On 25/04/2024 10:21, Thomas Bonnefille wrote:
> > According to the device tree coding style, nodes shall be ordered by
> > unit address in ascending order.
> >
> > Signed-off-by: Thomas Bonnefille <thomas.bonnefille@bootlin.com>
>
> Please use subject prefixes matching the subsystem. You can get them for
> example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory
> your patch is touching.
Ye, odd when the rest of the commits don't have it :)
I picked up this patch cos I'm prob gonna finalise what I'm sending
for 6.10 by the end of the week and saw no reason to not take the
cleanup.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2024-04-25 16:39 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-25 8:21 [PATCH 0/4] Add I2C support on TH1520 Thomas Bonnefille
2024-04-25 8:21 ` [PATCH 1/4] dt-bindings: i2c: dw: Document compatible thead,th1520-i2c Thomas Bonnefille
2024-04-25 9:48 ` Krzysztof Kozlowski
2024-04-25 8:21 ` [PATCH 2/4] riscv: boot: dts: thead: Fix node ordering in TH1520 device tree Thomas Bonnefille
2024-04-25 9:49 ` Krzysztof Kozlowski
2024-04-25 16:39 ` Conor Dooley [this message]
2024-04-25 8:21 ` [PATCH 3/4] riscv: dts: thead: Add TH1520 I2C nodes Thomas Bonnefille
2024-04-29 13:35 ` Emil Renner Berthing
2024-04-25 8:21 ` [PATCH 4/4] riscv: dts: thead: Enable I2C on the BeagleV-Ahead Thomas Bonnefille
2024-04-29 13:38 ` Emil Renner Berthing
2024-04-25 9:00 ` [PATCH 0/4] Add I2C support on TH1520 Conor Dooley
2024-04-25 9:42 ` Thomas Bonnefille
2024-04-25 15:10 ` Drew Fustini
2024-04-25 14:51 ` Rob Herring
2024-04-25 16:35 ` Conor Dooley
2024-04-26 14:12 ` Thomas Bonnefille
2024-04-26 14:42 ` Conor Dooley
2024-04-29 13:07 ` Thomas Bonnefille
2024-04-29 13:24 ` Conor Dooley
2024-04-25 16:37 ` (subset) " Conor Dooley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240425-mouse-unfair-1e0d9b19c713@spud \
--to=conor@kernel.org \
--cc=andi.shyti@kernel.org \
--cc=aou@eecs.berkeley.edu \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=guoren@kernel.org \
--cc=jszhang@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=miquel.raynal@bootlin.com \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=robh@kernel.org \
--cc=thomas.bonnefille@bootlin.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=wefu@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).