devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Rob Herring (Arm)" <robh@kernel.org>
To: Masahiro Yamada <masahiroy@kernel.org>,
	Nathan Chancellor <nathan@kernel.org>,
	Nicolas Schier <nicolas@fjasle.eu>
Cc: linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org,
	devicetree@vger.kernel.org
Subject: [PATCH] dt-bindings: kbuild: Fix dt_binding_check for arch without dts directory
Date: Tue, 30 Apr 2024 15:29:29 -0500	[thread overview]
Message-ID: <20240430202928.1143802-3-robh@kernel.org> (raw)

Commit 1d06c77d93da ("dt-bindings: kbuild: Add separate
target/dependency for processed-schema.json") placed setting CHECK_DTBS
for 'dt_binding_check' target within the section that depends on having
arch/$ARCH/boot/dts/ which x86 doesn't have for example. That results in
the schema checks not running for the examples. Move setting it back out
of the conditional section as it was (CHECK_DT_BINDING is still
replaced).

Fixes: 1d06c77d93da ("dt-bindings: kbuild: Add separate target/dependency for processed-schema.json")
Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
---
Cc: devicetree@vger.kernel.org

Masahiro, Please take this as the above commit is in your tree.

 Makefile | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/Makefile b/Makefile
index f4fe5b0ea931..43a2a630436a 100644
--- a/Makefile
+++ b/Makefile
@@ -1403,7 +1403,7 @@ dtbs: dtbs_prepare
 # dtbs_install depend on it as dtbs_install may run as root.
 dtbs_prepare: include/config/kernel.release scripts_dtc
 
-ifneq ($(filter dt_binding_check dtbs_check, $(MAKECMDGOALS)),)
+ifneq ($(filter dtbs_check, $(MAKECMDGOALS)),)
 export CHECK_DTBS=y
 endif
 
@@ -1422,6 +1422,10 @@ endif
 
 endif
 
+ifneq ($(filter dt_binding_check, $(MAKECMDGOALS)),)
+export CHECK_DTBS=y
+endif
+
 PHONY += scripts_dtc
 scripts_dtc: scripts_basic
 	$(Q)$(MAKE) $(build)=scripts/dtc
-- 
2.43.0


             reply	other threads:[~2024-04-30 20:30 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-30 20:29 Rob Herring (Arm) [this message]
2024-05-02 11:06 ` [PATCH] dt-bindings: kbuild: Fix dt_binding_check for arch without dts directory Masahiro Yamada

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240430202928.1143802-3-robh@kernel.org \
    --to=robh@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=masahiroy@kernel.org \
    --cc=nathan@kernel.org \
    --cc=nicolas@fjasle.eu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).